Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0041239Openbravo ERP00. Application dictionarypublic2019-07-02 16:012019-08-22 14:44
shuehner 
alostale 
normalmajorhave not tried
closedfixed 
5
 
3.0PR19Q43.0PR19Q4 
caristu
Core
No
0041239: ADTreeDatasourceService.{getNodeChildenQuery,nodeHasChildren, nodeConformsToWhereClause) are not using bind-params
Those functions are not using bind-params.


when fixing please apply new HQL-style to all 3 HQL's in the file
-
No tags attached.
depends on backport 00412483.0PR19Q3 closed alostale ADTreeDatasourceService.{getNodeChildenQuery,nodeHasChildren, nodeConformsToWhereClause) are not using bind-params 
depends on backport 00412493.0PR19Q2.1 closed alostale ADTreeDatasourceService.{getNodeChildenQuery,nodeHasChildren, nodeConformsToWhereClause) are not using bind-params 
depends on backport 00412503.0PR19Q1.2 closed platform ADTreeDatasourceService.{getNodeChildenQuery,nodeHasChildren, nodeConformsToWhereClause) are not using bind-params 
related to defect 0041293 closed alostale apply HQL style guide to ADTreeDatasourceService 
blocks design defect 0038136 acknowledged Triage Platform Base Tracking issue: Find & Fix queries not using bind-params but embedding values into query string 
Issue History
2019-07-02 16:01shuehnerNew Issue
2019-07-02 16:01shuehnerAssigned To => platform
2019-07-02 16:01shuehnerModules => Core
2019-07-02 16:01shuehnerTriggers an Emergency Pack => No
2019-07-02 16:02shuehnerRelationship addedblocks 0038136
2019-07-03 15:26alostaleReview Assigned To => caristu
2019-07-03 15:26alostaleSummaryATTreeDatasourceService.{getNodeChildenQuery,nodeHasChildren, nodeConformsToWhereClause) are not using bind-params => ADTreeDatasourceService.{getNodeChildenQuery,nodeHasChildren, nodeConformsToWhereClause) are not using bind-params
2019-07-03 15:26alostaleStatusnew => scheduled
2019-07-03 15:26alostaleAssigned Toplatform => alostale
2019-07-04 12:02shuehnerTarget Version => 3.0PR19Q4
2019-07-05 10:34hgbotCheckin
2019-07-05 10:34hgbotNote Added: 0113196
2019-07-05 10:34hgbotStatusscheduled => resolved
2019-07-05 10:34hgbotResolutionopen => fixed
2019-07-05 10:34hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/4d817788ca2f4448174f58d38a52c1c30ddfe44f [^]
2019-07-05 18:38caristuNote Added: 0113208
2019-07-05 18:38caristuStatusresolved => closed
2019-07-05 18:38caristuFixed in Version => 3.0PR19Q4
2019-07-09 08:47alostaleRelationship addedrelated to 0041293
2019-08-22 14:44hudsonbotCheckin
2019-08-22 14:44hudsonbotNote Added: 0114137

Notes
(0113196)
hgbot   
2019-07-05 10:34   
Repository: erp/devel/pi
Changeset: 4d817788ca2f4448174f58d38a52c1c30ddfe44f
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Wed Jul 03 15:38:10 2019 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/4d817788ca2f4448174f58d38a52c1c30ddfe44f [^]

fixed bug 041239: use bind parameters in ADTreeDatasourceService

  * Use parameter in query in getNodeChildrenQuery method where possible
  * Do not use deprecated OBDal.getReadableOrganizationsInClause method
  * Properly escape paremeter values in clasues coming from AD

---
M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/ADTreeDatasourceService.java
M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/TreeDatasourceService.java
---
(0113208)
caristu   
2019-07-05 18:38   
Reviewed
(0114137)
hudsonbot   
2019-08-22 14:44   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ad3efd3bd07c [^]
Maturity status: Test