Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041238Openbravo ERP09. Financial managementpublic2019-07-02 15:582019-08-22 14:44
Reportershuehner 
Assigned Tocollazoandy4 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR19Q4Fixed in Version3.0PR19Q4 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0041238: FIN_Utility.{isPeriodOpen,isReversePayment,getOrderedPaymentDetailList) are not using bind-params
DescriptionThis code is not using bind-params:

a.) major isPeriodOpen (i.e. call via Reconciliation.java)
b.) isReversePayment,getOrderedPaymentDetailList

When fixing please apply new HQL-Style to all 7 cases in this file.
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 00412613.0PR19Q3 closed Triage Omni OMS FIN_Utility.{isPeriodOpen,isReversePayment,getOrderedPaymentDetailList) are not using bind-params 
depends on backport 00412623.0PR19Q2.1 closed collazoandy4 FIN_Utility.{isPeriodOpen,isReversePayment,getOrderedPaymentDetailList) are not using bind-params 
depends on backport 00412633.0PR19Q1.3 closed Triage Omni OMS FIN_Utility.{isPeriodOpen,isReversePayment,getOrderedPaymentDetailList) are not using bind-params 
related to defect 0041424 closed AtulOpenbravo Several unused methods in FIN_Utility.java 
blocks design defect 0038136 acknowledged Triage Platform Base Tracking issue: Find & Fix queries not using bind-params but embedding values into query string 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-07-02 15:58shuehnerNew Issue
2019-07-02 15:58shuehnerAssigned To => Triage Finance
2019-07-02 15:58shuehnerModules => Core
2019-07-02 15:58shuehnerTriggers an Emergency Pack => No
2019-07-02 15:58shuehnerRelationship addedblocks 0038136
2019-07-03 17:01shuehnerStatusnew => scheduled
2019-07-03 17:01shuehnerTarget Version => 3.0PR19Q4
2019-07-04 17:48SandrahuguetAssigned ToTriage Finance => collazoandy4
2019-07-09 17:14SandrahuguetAssigned Tocollazoandy4 => AtulOpenbravo
2019-07-09 17:47SandrahuguetAssigned ToAtulOpenbravo => collazoandy4
2019-07-13 14:46collazoandy4Note Added: 0113342
2019-07-16 18:22hgbotCheckin
2019-07-16 18:22hgbotNote Added: 0113450
2019-07-16 18:26dmiguelezNote Added: 0113457
2019-07-16 18:26dmiguelezStatusscheduled => resolved
2019-07-16 18:26dmiguelezFixed in Version => 3.0PR19Q4
2019-07-16 18:26dmiguelezFixed in SCM revision => https://code.openbravo.com/erp/devel/pi/rev/1b97ac29aee5 [^]
2019-07-16 18:26dmiguelezResolutionopen => fixed
2019-07-16 18:27dmiguelezReview Assigned To => dmiguelez
2019-07-16 18:27dmiguelezNote Added: 0113458
2019-07-16 18:27dmiguelezStatusresolved => closed
2019-07-22 22:11collazoandy4Relationship addedblocks 0041424
2019-07-22 22:13collazoandy4Relationship deletedblocks 0041424
2019-07-22 22:13collazoandy4Relationship addedrelated to 0041424
2019-08-22 14:44hudsonbotCheckin
2019-08-22 14:44hudsonbotNote Added: 0114153

Notes
(0113342)
collazoandy4   
2019-07-13 14:46   
Test Plan
  Go to Sales Invoice and create one record for Alimentos y Supermercados, S.A
    Create a new record in Lines tab:
      Product: Limonada 0,5L
      Invoiced Quantity: 10
    Complete the invoice
  Go to Payment In and create a new record for same BP
    Clic on Add Details and select previous invoice
    Clic on Reactivate and check the process ends without error
(0113450)
hgbot   
2019-07-16 18:22   
Repository: erp/devel/pi
Changeset: 1b97ac29aee5716785117b890cfdab4bc0b6a713
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Tue Jul 16 16:48:06 2019 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/1b97ac29aee5716785117b890cfdab4bc0b6a713 [^]

iFixes issue 41238: FIN_Utility is not using bind-params

The isPeriodOpen, isReversePayment and getOrderedPaymentDetailList methods was
updated with bind-params

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/utility/FIN_Utility.java
---
(0113457)
dmiguelez   
2019-07-16 18:26   
Fixed by commit: https://code.openbravo.com/erp/devel/pi/rev/1b97ac29aee5 [^]
(0113458)
dmiguelez   
2019-07-16 18:27   
Code Review + Testing Ok
(0114153)
hudsonbot   
2019-08-22 14:44   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ad3efd3bd07c [^]
Maturity status: Test