Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041236Openbravo ERP09. Financial managementpublic2019-07-02 15:502019-08-22 14:45
Reportershuehner 
Assigned Tocollazoandy4 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR19Q4Fixed in Version3.0PR19Q4 
Merge Request Status
Review Assigned ToSandrahuguet
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0041236: RecordID2Filling.getBPAccountList is not using bind-params
DescriptionThis code is not using bind-params:

      hqlString.append("select distinct ca.customerReceivablesNo, ca.customerPrepayment");
      hqlString.append(" from CustomerAccounts as ca");
      hqlString.append(" where ca.accountingSchema.id = '" + acctSchemaId + "'");
    } else {
      hqlString.append("select distinct va.vendorPrepayment, va.vendorLiability");// va.vendorServiceLiability,
      hqlString.append(" from VendorAccounts as va");
      hqlString.append(" where va.accountingSchema.id = '" + acctSchemaId + "'");

When fixing please apply new HQL-style to all 12 HQL's in this file.
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0041403 closed collazoandy4 Apply HQL style guide to RecordID2Filling 
blocks design defect 0038136 acknowledged Triage Platform Base Tracking issue: Find & Fix queries not using bind-params but embedding values into query string 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-07-02 15:50shuehnerNew Issue
2019-07-02 15:50shuehnerAssigned To => Triage Finance
2019-07-02 15:50shuehnerModules => Core
2019-07-02 15:50shuehnerTriggers an Emergency Pack => No
2019-07-02 15:51shuehnerRelationship addedblocks 0038136
2019-07-04 12:15shuehnerTarget Version => 3.0PR19Q4
2019-07-19 02:00collazoandy4Assigned ToTriage Finance => collazoandy4
2019-07-19 02:01collazoandy4Statusnew => scheduled
2019-07-21 08:11collazoandy4Note Added: 0113555
2019-08-07 09:29SandrahuguetRelationship addedrelated to 0041403
2019-08-07 09:52hgbotCheckin
2019-08-07 09:52hgbotNote Added: 0113861
2019-08-07 09:52hgbotStatusscheduled => resolved
2019-08-07 09:52hgbotResolutionopen => fixed
2019-08-07 09:52hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/ecc81d50e76fec395fce844b681bfc77d503ade3 [^]
2019-08-07 09:52SandrahuguetReview Assigned To => Sandrahuguet
2019-08-07 09:52SandrahuguetNote Added: 0113862
2019-08-07 09:52SandrahuguetStatusresolved => closed
2019-08-07 09:52SandrahuguetFixed in Version => 3.0PR19Q4
2019-08-22 14:45hudsonbotCheckin
2019-08-22 14:45hudsonbotNote Added: 0114211

Notes
(0113555)
collazoandy4   
2019-07-21 08:11   
Test Plan
  Go to Process Request and create a new record:
    Process: Open Balances: Review historical data
    Timming: Run Immediately
    Click on Reeschedule Process button and check the process ends without error
(0113861)
hgbot   
2019-08-07 09:52   
Repository: erp/devel/pi
Changeset: ecc81d50e76fec395fce844b681bfc77d503ade3
Author: Armaignac <collazoandy4 <at> gmail.com>
Date: Fri Jul 19 14:52:39 2019 -0400
URL: http://code.openbravo.com/erp/devel/pi/rev/ecc81d50e76fec395fce844b681bfc77d503ade3 [^]

Fixes issue 41236: RecordID2Filling.getBPAccountList is not using bind-params

Added bind-params to getBPAccountList

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/RecordID2Filling.java
---
(0113862)
Sandrahuguet   
2019-08-07 09:52   
code review + testing ok
(0114211)
hudsonbot   
2019-08-22 14:45   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ad3efd3bd07c [^]
Maturity status: Test