Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041235Openbravo ERP09. Financial managementpublic2019-07-02 15:482019-08-22 14:45
Reportershuehner 
Assigned Tocollazoandy4 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR19Q4Fixed in Version3.0PR19Q4 
Merge Request Status
Review Assigned ToSandrahuguet
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0041235: FIN_AddPaymentFromJournalLine.doExecute is not using bind-params
DescriptionThis code is not using bind-params:

          hsqlScript.append("where ad_isorgincluded('" + journalLine.getOrganization().getId()
              + "', o.id, o.client) <> -1 ");

When fixing please apply new HQL-style.
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on defect 0041391 closed collazoandy4 Apply HQL style guide to FIN_AddPaymentFromJournalLine 
blocks design defect 0038136 acknowledged Triage Platform Base Tracking issue: Find & Fix queries not using bind-params but embedding values into query string 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-07-02 15:48shuehnerNew Issue
2019-07-02 15:48shuehnerAssigned To => Triage Finance
2019-07-02 15:48shuehnerModules => Core
2019-07-02 15:48shuehnerTriggers an Emergency Pack => No
2019-07-02 15:49shuehnerRelationship addedblocks 0038136
2019-07-04 12:15shuehnerTarget Version => 3.0PR19Q4
2019-07-18 06:58collazoandy4Assigned ToTriage Finance => collazoandy4
2019-07-18 06:58collazoandy4Statusnew => scheduled
2019-07-18 14:29collazoandy4Note Added: 0113521
2019-08-05 09:46SandrahuguetRelationship addeddepends on 0041391
2019-08-05 13:19hgbotCheckin
2019-08-05 13:19hgbotNote Added: 0113809
2019-08-05 13:19hgbotStatusscheduled => resolved
2019-08-05 13:19hgbotResolutionopen => fixed
2019-08-05 13:19hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/cfa6474918cbc9652ad888c2412925538a2fb450 [^]
2019-08-05 13:22SandrahuguetReview Assigned To => Sandrahuguet
2019-08-05 13:22SandrahuguetNote Added: 0113811
2019-08-05 13:22SandrahuguetStatusresolved => closed
2019-08-05 13:22SandrahuguetFixed in Version => 3.0PR19Q4
2019-08-22 14:45hudsonbotCheckin
2019-08-22 14:45hudsonbotNote Added: 0114202

Notes
(0113521)
collazoandy4   
2019-07-18 14:29   
Test Plan
  Go to G/L Journal window and create a new record, Create valid records in Header and Lines tab for current period, click on Complete button and check the process ends without errors
(0113809)
hgbot   
2019-08-05 13:19   
Repository: erp/devel/pi
Changeset: cfa6474918cbc9652ad888c2412925538a2fb450
Author: Armaignac <collazoandy4 <at> gmail.com>
Date: Thu Jul 18 22:45:56 2019 -0400
URL: http://code.openbravo.com/erp/devel/pi/rev/cfa6474918cbc9652ad888c2412925538a2fb450 [^]

Fixes issue 41235:FIN_AddPaymentFromJournalLine.doExecute is not using
bind-params

Use bind params in HQL queries

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_AddPaymentFromJournalLine.java
---
(0113811)
Sandrahuguet   
2019-08-05 13:22   
code review + testing ok
(0114202)
hudsonbot   
2019-08-22 14:45   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ad3efd3bd07c [^]
Maturity status: Test