Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041234Openbravo ERP09. Financial managementpublic2019-07-02 15:472019-08-22 14:45
Reportershuehner 
Assigned Tocollazoandy4 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR19Q4Fixed in Version3.0PR19Q4 
Merge Request Status
Review Assigned ToSandrahuguet
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0041234: TransactionsDao.getCurrentlyClearedAmt is not using bind-param
DescriptionThis code is not using bind-params:
    final StringBuilder hqlString = new StringBuilder();
    hqlString.append("select sum(ft.depositAmount) - sum(ft.paymentAmount)");
    hqlString.append(" from FIN_Finacc_Transaction as ft");
    hqlString.append(" left outer join ft.reconciliation as rec");
    hqlString.append(" where ft.account.id = '" + strAccountId + "'");
    hqlString.append(" and rec.processed = 'N'");
    hqlString.append(" and ft.processed = 'Y'");

When fixing please apply new HQL-style to all 2 HQL's in the file.
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0041390 closed collazoandy4 Apply HQL style guide to TransactionsDao 
blocks design defect 0038136 acknowledged Triage Platform Base Tracking issue: Find & Fix queries not using bind-params but embedding values into query string 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-07-02 15:47shuehnerNew Issue
2019-07-02 15:47shuehnerAssigned To => Triage Finance
2019-07-02 15:47shuehnerModules => Core
2019-07-02 15:47shuehnerTriggers an Emergency Pack => No
2019-07-02 15:47shuehnerRelationship addedblocks 0038136
2019-07-04 12:14shuehnerTarget Version => 3.0PR19Q4
2019-07-17 16:18collazoandy4Assigned ToTriage Finance => collazoandy4
2019-07-17 16:18collazoandy4Statusnew => scheduled
2019-07-18 13:50collazoandy4Note Added: 0113517
2019-08-02 14:19SandrahuguetRelationship addedrelated to 0041390
2019-08-02 14:20hgbotCheckin
2019-08-02 14:20hgbotNote Added: 0113785
2019-08-02 14:20hgbotStatusscheduled => resolved
2019-08-02 14:20hgbotResolutionopen => fixed
2019-08-02 14:20hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/a2008d34b5b9905a4b6de90b3b5dcc4697d105b0 [^]
2019-08-02 14:20SandrahuguetReview Assigned To => Sandrahuguet
2019-08-02 14:20SandrahuguetNote Added: 0113787
2019-08-02 14:20SandrahuguetStatusresolved => closed
2019-08-02 14:20SandrahuguetFixed in Version => 3.0PR19Q4
2019-08-22 14:45hudsonbotCheckin
2019-08-22 14:45hudsonbotNote Added: 0114199

Notes
(0113517)
collazoandy4   
2019-07-18 13:50   
Test Plan
  Create a new Sales Invoice with 'Al contado' payment method and complete it and add a payment to it
  Go to Financial Account window and select Caja record
    Create a new Funds Transfer with the payment amount
    Select the transaccion created by the invoice and clic on Reconcile
      Select the two records and clic on Reconcilie
    Check the process ends with out errors
(0113785)
hgbot   
2019-08-02 14:20   
Repository: erp/devel/pi
Changeset: a2008d34b5b9905a4b6de90b3b5dcc4697d105b0
Author: Armaignac <collazoandy4 <at> gmail.com>
Date: Thu Jul 18 22:43:41 2019 -0400
URL: http://code.openbravo.com/erp/devel/pi/rev/a2008d34b5b9905a4b6de90b3b5dcc4697d105b0 [^]

Fixes issue 41234:TransactionsDao.getCurrentlyClearedAmt is not using bind-param

Use bind params in getCurrentlyClearedAmt query

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/dao/TransactionsDao.java
---
(0113787)
Sandrahuguet   
2019-08-02 14:20   
code review + testing ok
(0114199)
hudsonbot   
2019-08-22 14:45   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ad3efd3bd07c [^]
Maturity status: Test