Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041233Openbravo ERP09. Financial managementpublic2019-07-02 15:452019-08-22 14:45
Reportershuehner 
Assigned Tocollazoandy4 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR19Q4Fixed in Version3.0PR19Q4 
Merge Request Status
Review Assigned ToSandrahuguet
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0041233: MatchTransactionDao.getUnmatchedBankStatementLines
DescriptionThis code is not using bind-params

    final StringBuilder whereClause = new StringBuilder();
    whereClause.append(" as bsl ");
    whereClause.append(" where bsl.").append(FIN_BankStatementLine.PROPERTY_BANKSTATEMENT);
    whereClause.append(".").append(FIN_BankStatement.PROPERTY_ACCOUNT).append(".id = '");
    whereClause.append(account.getId()).append("'");
    whereClause.append(" and bsl.")
        .append(FIN_BankStatementLine.PROPERTY_FINANCIALACCOUNTTRANSACTION);
    whereClause.append(" is null");
    whereClause.append(" and bsl.bankStatement.processed = 'Y'");
Steps To Reproduce-
Proposed SolutionWhen fixing please apply new HQL-style to all 6 cases in this file
Additional Information
TagsNo tags attached.
Relationships
related to defect 0041389 closed collazoandy4 Apply HQL style guide to MatchTransactionDao 
blocks design defect 0038136 acknowledged Triage Platform Base Tracking issue: Find & Fix queries not using bind-params but embedding values into query string 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-07-02 15:45shuehnerNew Issue
2019-07-02 15:45shuehnerAssigned To => Triage Finance
2019-07-02 15:45shuehnerModules => Core
2019-07-02 15:45shuehnerTriggers an Emergency Pack => No
2019-07-02 15:46shuehnerRelationship addedblocks 0038136
2019-07-04 12:14shuehnerTarget Version => 3.0PR19Q4
2019-07-17 16:18collazoandy4Assigned ToTriage Finance => collazoandy4
2019-07-17 16:18collazoandy4Statusnew => scheduled
2019-07-18 14:10collazoandy4Note Added: 0113519
2019-08-02 09:31SandrahuguetRelationship addedrelated to 0041389
2019-08-02 11:56hgbotCheckin
2019-08-02 11:56hgbotNote Added: 0113779
2019-08-02 11:56hgbotStatusscheduled => resolved
2019-08-02 11:56hgbotResolutionopen => fixed
2019-08-02 11:56hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/964e7f0228d8fbcb1bb48f6723924fda9184d0fa [^]
2019-08-02 12:01SandrahuguetReview Assigned To => Sandrahuguet
2019-08-02 12:01SandrahuguetNote Added: 0113781
2019-08-02 12:01SandrahuguetStatusresolved => closed
2019-08-02 12:01SandrahuguetFixed in Version => 3.0PR19Q4
2019-08-22 14:45hudsonbotCheckin
2019-08-22 14:45hudsonbotNote Added: 0114197

Notes
(0113519)
collazoandy4   
2019-07-18 14:10   
Test Plan
  Go to Financial Account and select Bank Account 1 record
    Create a new record in Imported Bank Statement tab
      Create a new record in Lines tab (with any amount)
    Click on Match Statement and clic OK (First ok button to run algorithm)
      Click on + button select GL Item: Salaries and click on Done button
    Click on Reconcilie All button
(0113779)
hgbot   
2019-08-02 11:56   
Repository: erp/devel/pi
Changeset: 964e7f0228d8fbcb1bb48f6723924fda9184d0fa
Author: Armaignac <collazoandy4 <at> gmail.com>
Date: Thu Jul 18 22:37:16 2019 -0400
URL: http://code.openbravo.com/erp/devel/pi/rev/964e7f0228d8fbcb1bb48f6723924fda9184d0fa [^]

Fixes issue 41233: MatchTransactionDao is not using bind-params

Use bind params in HQL queries

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/dao/MatchTransactionDao.java
---
(0113781)
Sandrahuguet   
2019-08-02 12:01   
code review + testing ok
(0114197)
hudsonbot   
2019-08-22 14:45   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ad3efd3bd07c [^]
Maturity status: Test