Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041228Openbravo ERPZ. Otherspublic2019-07-02 13:142019-08-22 14:44
Reportervmromanos 
Assigned Tovmromanos 
PrioritynormalSeveritymajorReproducibilityN/A
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR19Q4Fixed in Version3.0PR19Q4 
Merge Request Status
Review Assigned ToSandrahuguet
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0041228: One-to-many clean up of existing columns (Functional)
DescriptionSince 19Q3 the one-to-many child properties automatically generated by DAL can be configured (see http://wiki.openbravo.com/wiki/Data_Access_Layer#Business_Object [^]). By default any new window won't have this relationship. However the existing columns will keep it.

It would be nice to review all the existing columns and remove this relationship where it doesn't make sense, therefore creating a controlled API change that will reduce the model complexity and will improve performance.
Steps To ReproduceNA
Proposed Solutionhttps://docs.google.com/spreadsheets/d/1hdwjGM4_3TJ-9Bcylh_w_MM54_1T_cUlicaPfEyH1MQ [^]
Additional Information
TagsNo tags attached.
Relationships
has duplicate design defect 0040914 closed Triage Omni OMS functional: review FK columns to set which ones shouldn't generate one-to-many property in parent entity 
causes defect 00412273.0PR19Q4 closed vmromanos API Change: One-to-many cleanup (Functional team) 
causes defect 0042023 closed inigo_lerga In End Year Close window Accounting Tab FinancialMgmtPeriod.getfinancialMgmtPeriodControlList is needed 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-07-02 13:14vmromanosNew Issue
2019-07-02 13:14vmromanosAssigned To => Triage Finance
2019-07-02 13:14vmromanosModules => Core
2019-07-02 13:14vmromanosTriggers an Emergency Pack => No
2019-07-02 13:14vmromanosRelationship addedcauses 0041227
2019-07-02 13:14vmromanosStatusnew => scheduled
2019-07-02 13:14vmromanosAssigned ToTriage Finance => vmromanos
2019-07-02 13:14vmromanosTarget Version => 3.0PR19Q4
2019-07-04 10:11hgbotCheckin
2019-07-04 10:11hgbotNote Added: 0113171
2019-07-04 10:11hgbotStatusscheduled => resolved
2019-07-04 10:11hgbotResolutionopen => fixed
2019-07-04 10:11hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/ff5106481e824ee169ac43f2f5b2d42fdf93104a [^]
2019-07-04 12:10hgbotCheckin
2019-07-04 12:10hgbotNote Added: 0113172
2019-07-05 09:11vmromanosReview Assigned To => Sandrahuguet
2019-07-08 15:26SandrahuguetNote Added: 0113217
2019-07-08 15:27SandrahuguetNote Added: 0113219
2019-07-08 15:27SandrahuguetStatusresolved => closed
2019-07-08 15:27SandrahuguetFixed in Version => 3.0PR19Q4
2019-07-23 15:43vmromanosRelationship addedhas duplicate 0040914
2019-08-22 14:44hudsonbotCheckin
2019-08-22 14:44hudsonbotNote Added: 0114133
2019-08-22 14:44hudsonbotCheckin
2019-08-22 14:44hudsonbotNote Added: 0114134
2019-10-15 15:33SandrahuguetRelationship addedcauses 0042023

Notes
(0113171)
hgbot   
2019-07-04 10:11   
Repository: erp/devel/pi
Changeset: ff5106481e824ee169ac43f2f5b2d42fdf93104a
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Thu Jul 04 10:03:15 2019 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/ff5106481e824ee169ac43f2f5b2d42fdf93104a [^]

Fixed issue 41228: One-to-many clean up of existing columns (Functional)

Reviewed all the existing columns (Functional) and removed the one-to-many relationship where it doesn't make sense, therefore creating a controlled API change that will reduce the model complexity and will improve performance.

See for details: https://docs.google.com/spreadsheets/d/1hdwjGM4_3TJ-9Bcylh_w_MM54_1T_cUlicaPfEyH1MQ [^]

---
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_COLUMN.xml
M modules/org.openbravo.client.widgets/src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_COLUMN.xml
---
(0113172)
hgbot   
2019-07-04 12:10   
Repository: erp/devel/pi
Changeset: 794d0f20f14a9961d255cd32ce1f38e0dc56a6e9
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Thu Jul 04 12:03:02 2019 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/794d0f20f14a9961d255cd32ce1f38e0dc56a6e9 [^]

Related to issue 41228: One-to-many cleanup (Functional) finetune

Reverted back relationship beetween Order and Quotation list because it is used by a JUnit tests,
and on the other hand it might makes sense from a Functional POV

---
M src-db/database/sourcedata/AD_COLUMN.xml
---
(0113217)
Sandrahuguet   
2019-07-08 15:26   
Repository: erp/devel/pi
Changeset: fecfb6360b22
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Thu Jul 05 14:39:02 2019 +0200
URL: https://code.openbravo.com/erp/devel/pi/rev/fecfb6360b22 [^]

Related to 41228: Removed Costing related columns

---
M src-db/database/sourcedata/AD_COLUMN.xml
---
(0113219)
Sandrahuguet   
2019-07-08 15:27   
verified
(0114133)
hudsonbot   
2019-08-22 14:44   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ad3efd3bd07c [^]
Maturity status: Test
(0114134)
hudsonbot   
2019-08-22 14:44   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ad3efd3bd07c [^]
Maturity status: Test