Openbravo Issue Tracking System - Retail Modules |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0041216 | Retail Modules | Tests Stabilization | public | 2019-03-11 12:02 | 2019-07-15 10:02 |
|
| Reporter | gorka_gil | |
| Assigned To | gorka_gil | |
| Priority | normal | Severity | minor | Reproducibility | N/A |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | RR19Q1.2 | Fixed in Version | RR19Q1.2 | |
| Merge Request Status | |
| Review Assigned To | guilleaer |
| OBNetwork customer | No |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0041216: pi-mobile: wait for process to finish or till a new popup is opened |
| Description | In this issue:
https://issues.openbravo.com/view.php?id=40266 [^]
Pi-mobile was changed to wait for the finish of all processes after all taps and writes.
As part of this change was needed to introduce the pause and resume of process when a popup is opened, so the tests can write in that popup.
The problem is that this popup sometimes is opened as part of a hook, and inside the hook don't have the process id to do a pause/resume of the process.
The new idea is instead do a pause/resume of the processes is that the tests wait for the end of the process or if a new popup is opened. For that, before a tap should be needed to save the number of opened popups and after the tap, check that the number of opened popups has not increase.
The problem with this new idea is that some actions don't open a popup, for example the write of user and pass in the authorization popup for prepayment.
And for this cases is needed a tap or write that don't wait for processes.
Some of the are a bit risky, like for example the click on search for giftcards or creditnotes, that do a request to the backend, and don't wait for the processes in these cases is not very good. |
| Steps To Reproduce | - |
| Proposed Solution | |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | | blocks | defect | 0040348 | | closed | gorka_gil | pi-mobile: wait for process to finish or till a new popup is opened |
|
| Attached Files | |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2019-07-01 19:20 | gorka_gil | Type | defect => backport |
| 2019-07-01 19:20 | gorka_gil | Target Version | => RR19Q1.2 |
| 2019-07-01 19:23 | hgbot | Checkin | |
| 2019-07-01 19:23 | hgbot | Note Added: 0113130 | |
| 2019-07-01 19:23 | hgbot | Status | scheduled => resolved |
| 2019-07-01 19:23 | hgbot | Resolution | open => fixed |
| 2019-07-01 19:23 | hgbot | Fixed in SCM revision | http://code.openbravo.com/tools/automation/pi-mobile/rev/7d553108f4a028616b03ba208adac11b1cdde7be [^] => http://code.openbravo.com/retail/backports/3.0RR19Q1.2/pi-mobile/rev/a541d8291406c9ad17756b94858101f7d2d619ba [^] |
| 2019-07-01 19:23 | hgbot | Checkin | |
| 2019-07-01 19:23 | hgbot | Note Added: 0113131 | |
| 2019-07-08 18:48 | guilleaer | Review Assigned To | marvintm => guilleaer |
| 2019-07-08 18:48 | guilleaer | Status | resolved => closed |
| 2019-07-08 18:48 | guilleaer | Fixed in Version | => RR19Q1.2 |
| 2019-07-15 08:57 | hgbot | Checkin | |
| 2019-07-15 08:57 | hgbot | Note Added: 0113356 | |
| 2019-07-15 08:57 | hgbot | Status | closed => resolved |
| 2019-07-15 08:57 | hgbot | Fixed in SCM revision | http://code.openbravo.com/retail/backports/3.0RR19Q1.2/pi-mobile/rev/a541d8291406c9ad17756b94858101f7d2d619ba [^] => http://code.openbravo.com/tools/automation/pi-mobile/rev/a541d8291406c9ad17756b94858101f7d2d619ba [^] |
| 2019-07-15 08:58 | hgbot | Checkin | |
| 2019-07-15 08:58 | hgbot | Note Added: 0113357 | |
| 2019-07-15 10:02 | priyam | Note Added: 0113358 | |
| 2019-07-15 10:02 | priyam | Status | resolved => closed |
|
Notes |
|
|
(0113130)
|
|
hgbot
|
|
2019-07-01 19:23
|
|
Repository: retail/backports/3.0RR19Q1.2/pi-mobile
Changeset: a541d8291406c9ad17756b94858101f7d2d619ba
Author: Gorka Gil <gorka.gil <at> openbravo.com>
Date: Tue Mar 26 13:49:35 2019 +0100
URL: http://code.openbravo.com/retail/backports/3.0RR19Q1.2/pi-mobile/rev/a541d8291406c9ad17756b94858101f7d2d619ba [^]
Fixes issue 41216: wait for process to finish or till a new popup is opened
---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/terminals/WebPOSExtModulesTerminalHelper.java
M src-test/org/openbravo/test/mobile/retail/mobilecore/intuitive/IntuitiveCommandsMobileCore.java
M src-test/org/openbravo/test/mobile/retail/mobilecore/javascript/EnyoNode.java
M src-test/org/openbravo/test/mobile/retail/mobilecore/javascript/MobileCoreAPI.java
M src-test/org/openbravo/test/mobile/retail/mobilecore/utils/RetailUtils.java
---
|
|
|
|
(0113131)
|
|
hgbot
|
|
2019-07-01 19:23
|
|
Repository: retail/backports/3.0RR19Q1.2/pi-mobile
Changeset: 1b8880b0ab2a6bcb8f791682178094e20d74bdcb
Author: Gorka Gil <gorka.gil <at> openbravo.com>
Date: Tue Mar 26 19:54:09 2019 +0100
URL: http://code.openbravo.com/retail/backports/3.0RR19Q1.2/pi-mobile/rev/1b8880b0ab2a6bcb8f791682178094e20d74bdcb [^]
Related to issue 41216: improve the waitProcesses so if the current processes are the same that the previous ones, no need to wait
---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/terminals/WebPOSExtModulesTerminalHelper.java
M src-test/org/openbravo/test/mobile/retail/mobilecore/intuitive/IntuitiveCommandsMobileCore.java
M src-test/org/openbravo/test/mobile/retail/mobilecore/javascript/EnyoNode.java
M src-test/org/openbravo/test/mobile/retail/mobilecore/javascript/MobileCoreAPI.java
M src-test/org/openbravo/test/mobile/retail/mobilecore/utils/RetailUtils.java
---
|
|
|
|
(0113356)
|
|
hgbot
|
|
2019-07-15 08:57
|
|
Repository: tools/automation/pi-mobile
Changeset: a541d8291406c9ad17756b94858101f7d2d619ba
Author: Gorka Gil <gorka.gil <at> openbravo.com>
Date: Tue Mar 26 13:49:35 2019 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/a541d8291406c9ad17756b94858101f7d2d619ba [^]
Fixes issue 41216: wait for process to finish or till a new popup is opened
---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/terminals/WebPOSExtModulesTerminalHelper.java
M src-test/org/openbravo/test/mobile/retail/mobilecore/intuitive/IntuitiveCommandsMobileCore.java
M src-test/org/openbravo/test/mobile/retail/mobilecore/javascript/EnyoNode.java
M src-test/org/openbravo/test/mobile/retail/mobilecore/javascript/MobileCoreAPI.java
M src-test/org/openbravo/test/mobile/retail/mobilecore/utils/RetailUtils.java
---
|
|
|
|
(0113357)
|
|
hgbot
|
|
2019-07-15 08:58
|
|
Repository: tools/automation/pi-mobile
Changeset: 1b8880b0ab2a6bcb8f791682178094e20d74bdcb
Author: Gorka Gil <gorka.gil <at> openbravo.com>
Date: Tue Mar 26 19:54:09 2019 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/1b8880b0ab2a6bcb8f791682178094e20d74bdcb [^]
Related to issue 41216: improve the waitProcesses so if the current processes are the same that the previous ones, no need to wait
---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/terminals/WebPOSExtModulesTerminalHelper.java
M src-test/org/openbravo/test/mobile/retail/mobilecore/intuitive/IntuitiveCommandsMobileCore.java
M src-test/org/openbravo/test/mobile/retail/mobilecore/javascript/EnyoNode.java
M src-test/org/openbravo/test/mobile/retail/mobilecore/javascript/MobileCoreAPI.java
M src-test/org/openbravo/test/mobile/retail/mobilecore/utils/RetailUtils.java
---
|
|
|
|
(0113358)
|
|
priyam
|
|
2019-07-15 10:02
|
|
|
closing this issue, The status changed to resolve as part of merge back to automation/pi-mobile on 19Q1.2 publish |
|