Openbravo Issue Tracking System - Localization Pack: Spain
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041198Localization Pack: SpainMulti Dimensional Tax Reportpublic2019-06-27 18:052019-08-13 12:21
Reportershuehner 
Assigned Tocollazoandy4 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned ToSandrahuguet
Support ticket
OBNetwork customer
Regression introduced in release
Summary0041198: OBMTR30InvoiceTaxReportDao is not using bind-param.
DescriptionThis class has lots of cases not using bind-parameters for values both for simple value and list of value (n clauses).

Note: that setParameterList allows for easy use if lists directly.

Example can be in i.e. issue: 40580
Steps To Reproduce-
Proposed SolutionRewrite queries using bind-parameters for value.
Additional Information
TagsNo tags attached.
Relationships
related to defect 0041467 closed collazoandy4 Localization Pack: Spain Apply HQL style guide to OBMTR30InvoiceTaxReportDao 
blocks design defect 0038136 acknowledged Triage Platform Base Openbravo ERP Tracking issue: Find & Fix queries not using bind-params but embedding values into query string 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-06-27 18:05shuehnerNew Issue
2019-06-27 18:05shuehnerAssigned To => psanjuan
2019-06-27 18:06shuehnerRelationship addedblocks 0038136
2019-07-04 16:24shuehnerNote Added: 0113184
2019-07-04 16:47shuehnerAssigned Topsanjuan => Triage Finance
2019-07-05 15:16psanjuanAssigned ToTriage Finance => Opentix-Test
2019-07-26 08:20dmiguelezAssigned ToOpentix-Test => collazoandy4
2019-07-26 17:05collazoandy4Statusnew => scheduled
2019-07-31 17:34collazoandy4Note Added: 0113741
2019-08-12 13:23hgbotCheckin
2019-08-12 13:23hgbotNote Added: 0113948
2019-08-12 13:23hgbotStatusscheduled => resolved
2019-08-12 13:23hgbotResolutionopen => fixed
2019-08-12 13:23hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.module.invoiceTaxReportEnhanced30/rev/2bbba847a610ce0e31eed7ed8e62f73b2e0a4820 [^]
2019-08-12 13:23hgbotCheckin
2019-08-12 13:23hgbotNote Added: 0113949
2019-08-13 12:16hgbotCheckin
2019-08-13 12:16hgbotNote Added: 0113974
2019-08-13 12:16hgbotCheckin
2019-08-13 12:16hgbotNote Added: 0113975
2019-08-13 12:16hgbotCheckin
2019-08-13 12:16hgbotNote Added: 0113976
2019-08-13 12:20hgbotCheckin
2019-08-13 12:20hgbotNote Added: 0113977
2019-08-13 12:20SandrahuguetRelationship addedrelated to 0041467
2019-08-13 12:21SandrahuguetReview Assigned To => Sandrahuguet
2019-08-13 12:21SandrahuguetNote Added: 0113978
2019-08-13 12:21SandrahuguetStatusresolved => closed

Notes
(0113184)
shuehner   
2019-07-04 16:24   
NOTE: Same bug exists also in .cashvat module of this same report. Please also fix there
(0113741)
collazoandy4   
2019-07-31 17:34   
Test Plan
  Go to Multidimensional Tax Report and set
    From Date: 01-07-2018
    To Date: today
    Organization: F&B International Group Admin
    Business Partner: Bebidas Alegres, S.L, and Generación Eléctrica, S.A
    Tax Type: Tax
    Tax Rate: Adquisiciones IVA 21%
    Transaction Type: Purchase/Payments transactions
    Clic on HTML Format button and check the report is shown
    Clear BP filter and set: Moon Light Restaurants, Co.
    Tax Rate: CA Sales Tax - US State Sales
    Clic on HTML Format button and check the report is shown

Test Plan II
  Run the previous test plan for Multidimensional Tax Report Cash VAT
(0113948)
hgbot   
2019-08-12 13:23   
Repository: erp/pmods/org.openbravo.module.invoiceTaxReportEnhanced30
Changeset: 2bbba847a610ce0e31eed7ed8e62f73b2e0a4820
Author: Armaignac <collazoandy4 <at> gmail.com>
Date: Tue Jul 30 09:57:52 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.invoiceTaxReportEnhanced30/rev/2bbba847a610ce0e31eed7ed8e62f73b2e0a4820 [^]

Fixes issue 41198: OBMTR30InvoiceTaxReportDao is not using bind-param.

Added missing bind-parameters

---
M src/org/openbravo/module/invoiceTaxReportEnhanced30/ad_reports/OBMTR30InvoiceTaxReportDao.java
---
(0113949)
hgbot   
2019-08-12 13:23   
Repository: erp/pmods/org.openbravo.module.invoiceTaxReportEnhanced30
Changeset: dd8937209a5b925cc0d570abbbdd4a16f8736af8
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Mon Aug 12 12:52:52 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.invoiceTaxReportEnhanced30/rev/dd8937209a5b925cc0d570abbbdd4a16f8736af8 [^]

related to issue 41198 added IsIDFilter validation to currency param

---
M src/org/openbravo/module/invoiceTaxReportEnhanced30/ad_reports/OBMTR30_InvoiceTaxReportJR.java
---
(0113974)
hgbot   
2019-08-13 12:16   
Repository: erp/pmods/org.openbravo.module.invoiceTaxReportEnhanced30.cashvat
Changeset: c9f13b7bd0750b695779082a936e1732e986cc14
Author: Armaignac <collazoandy4 <at> gmail.com>
Date: Tue Jul 30 11:05:39 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.invoiceTaxReportEnhanced30.cashvat/rev/c9f13b7bd0750b695779082a936e1732e986cc14 [^]

Related to issue 41198: OBMTRCVInvoiceTaxReportDao is not using bind-param.

Added missing bind-parameters

---
M src/org/openbravo/module/invoiceTaxReportEnhanced30/cashvat/ad_reports/OBMTRCVInvoiceTaxReportDao.java
---
(0113975)
hgbot   
2019-08-13 12:16   
Repository: erp/pmods/org.openbravo.module.invoiceTaxReportEnhanced30.cashvat
Changeset: 882bbf770868dc77eabb673fb55ea94793f5798b
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Tue Aug 13 12:13:20 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.invoiceTaxReportEnhanced30.cashvat/rev/882bbf770868dc77eabb673fb55ea94793f5798b [^]

related to issue 41198 apply formater

---
M src/org/openbravo/module/invoiceTaxReportEnhanced30/cashvat/ad_reports/OBMTRCV_InvoiceTaxReportJR.java
---
(0113976)
hgbot   
2019-08-13 12:16   
Repository: erp/pmods/org.openbravo.module.invoiceTaxReportEnhanced30.cashvat
Changeset: c001d52cfb97c43aaf2b7e07b937d4fc55715b93
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Tue Aug 13 12:14:34 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.invoiceTaxReportEnhanced30.cashvat/rev/c001d52cfb97c43aaf2b7e07b937d4fc55715b93 [^]

related to issue 41198 added IsIDFilter validation to currency param in casvat module

---
M src/org/openbravo/module/invoiceTaxReportEnhanced30/cashvat/ad_reports/OBMTRCV_InvoiceTaxReportJR.java
---
(0113977)
hgbot   
2019-08-13 12:20   
Repository: erp/pmods/org.openbravo.module.invoiceTaxReportEnhanced30
Changeset: 251cb539621b973b160d86e968e79e8242e61af3
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Tue Aug 13 12:20:19 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.invoiceTaxReportEnhanced30/rev/251cb539621b973b160d86e968e79e8242e61af3 [^]

related to issue 41198 apply formater

---
M src/org/openbravo/module/invoiceTaxReportEnhanced30/ad_reports/OBMTR30_InvoiceTaxReportJR.java
---
(0113978)
Sandrahuguet   
2019-08-13 12:21   
code review + testing ok