Openbravo Issue Tracking System - Retail Modules |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0041197 | Retail Modules | Web POS | public | 2019-06-27 17:51 | 2019-07-19 08:04 |
|
| Reporter | asiermartirena | |
| Assigned To | asiermartirena | |
| Priority | normal | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | | Fixed in Version | RR19Q4 | |
| Merge Request Status | |
| Review Assigned To | aaroncalero |
| OBNetwork customer | |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0041197: When generating the invoice in Web POS, some properties must be avoided |
| Description | When creating an invoice in the Web POS, it is initially taken from the active order. This order has many parameters that can be removed, in order to make it lighter.
This also causes, in the specific case of the 'calculateReceiptCallbacks' property, that in some specific cases the flow can have a js error. As the property is an array, that means that is a referenced property, when it is cloned the new object still has the same reference to the original one, so the invoice can add new callbacks to the order. This must be avoided. |
| Steps To Reproduce | Create an order in the Web POS. Generate an invoice with it. Check, for example, that the payments information is sent in the invoice object. |
| Proposed Solution | |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | |
| Attached Files | |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2019-06-27 17:51 | asiermartirena | New Issue | |
| 2019-06-27 17:51 | asiermartirena | Assigned To | => asiermartirena |
| 2019-06-27 17:51 | asiermartirena | Triggers an Emergency Pack | => No |
| 2019-07-01 10:05 | asiermartirena | Type | defect => design defect |
| 2019-07-03 18:25 | hgbot | Checkin | |
| 2019-07-03 18:25 | hgbot | Note Added: 0113162 | |
| 2019-07-03 18:25 | hgbot | Status | new => resolved |
| 2019-07-03 18:25 | hgbot | Resolution | open => fixed |
| 2019-07-03 18:25 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e7151da9146686a076e02c679191c306c6b6f505 [^] |
| 2019-07-10 15:10 | adrianromero | Review Assigned To | => aaroncalero |
| 2019-07-10 15:10 | adrianromero | Note Added: 0113257 | |
| 2019-07-10 15:10 | adrianromero | Status | resolved => closed |
| 2019-07-10 15:10 | adrianromero | Fixed in Version | => RR19Q4 |
| 2019-07-11 15:31 | hgbot | Checkin | |
| 2019-07-11 15:31 | hgbot | Note Added: 0113278 | |
| 2019-07-11 15:31 | hgbot | Status | closed => resolved |
| 2019-07-11 15:31 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e7151da9146686a076e02c679191c306c6b6f505 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal-discounts/rev/e7151da9146686a076e02c679191c306c6b6f505 [^] |
| 2019-07-19 08:04 | aaroncalero | Status | resolved => closed |
|
Notes |
|
|
(0113162)
|
|
hgbot
|
|
2019-07-03 18:25
|
|
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: e7151da9146686a076e02c679191c306c6b6f505
Author: Asier Martirena <asier.martirena <at> openbravo.com>
Date: Wed Jul 03 18:25:14 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e7151da9146686a076e02c679191c306c6b6f505 [^]
Fixed issue 41197: When generating the invoice in Web POS, some properties must be avoided
The calculateReceiptCallbacks, calculatedInvoice, canceledorder, payments, json and undo properties must be removed or reset, because are not needed for invoices and the generating JSON can be much bigger than needed one.
---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
|
|
|
|
|
|
|
|
(0113278)
|
|
hgbot
|
|
2019-07-11 15:31
|
|
Repository: erp/pmods/org.openbravo.retail.posterminal-discounts
Changeset: e7151da9146686a076e02c679191c306c6b6f505
Author: Asier Martirena <asier.martirena <at> openbravo.com>
Date: Wed Jul 03 18:25:14 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal-discounts/rev/e7151da9146686a076e02c679191c306c6b6f505 [^]
Fixed issue 41197: When generating the invoice in Web POS, some properties must be avoided
The calculateReceiptCallbacks, calculatedInvoice, canceledorder, payments, json and undo properties must be removed or reset, because are not needed for invoices and the generating JSON can be much bigger than needed one.
---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
|
|