Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041196Retail ModulesWeb POSpublic2019-06-27 17:372019-07-11 18:57
Reporterasiermartirena 
Assigned Toasiermartirena 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR19Q4 
Merge Request Status
Review Assigned Toadrianromero
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0041196: When the multi order process fails in the preOrderSave hook, it is not correctly managed
DescriptionWhen the preOrderSave hook fails in the pay open tickets flow, the payments and tickets must return back to a initial state. Here there are two possibilities: Synchronized mode or not.
Without the synchronized mode, that means in the common mode, the orders must not return back fully to an initial status. Just the needed properties must return back to the initial status. In addition, the orderlist models must be updated. In this case, as the reference is the same to the multiorder object, won't be needed.
In the other hand, with synchronized mode, after the process fails, the order must return back to an initial status. For this purpose, the order must be fully restored with the frozen order, instead of just updating some properties. The orderlist records must also be updated, to use the new references.

For payments, is also necessary to restore fully to it's initial value.
Steps To ReproduceExecute a Pay Open Tickets flow and force the preOrderSave to fail.

Check that the orders are not correctly restores --> In the case of the common mode the order list models and multi order models are not now referencing to the same object. With synchronized mode, the same problem. Also, some values that have been modified during the preOrderSave hook have not been restored to it's initial value.

In payments --> Realize that only the origAmount property has been restored. The amount is still set to zero.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0041271 closed asiermartirena Layaways can generate shipments when the synchronization process have some failure 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-06-27 17:37asiermartirenaNew Issue
2019-06-27 17:37asiermartirenaAssigned To => asiermartirena
2019-06-27 17:37asiermartirenaTriggers an Emergency Pack => No
2019-07-03 18:24hgbotCheckin
2019-07-03 18:24hgbotNote Added: 0113161
2019-07-03 18:24hgbotStatusnew => resolved
2019-07-03 18:24hgbotResolutionopen => fixed
2019-07-03 18:24hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/741ba45e7f60034549e4772c0c00f6877b735393 [^]
2019-07-09 14:09adrianromeroRelationship addedrelated to 0041271
2019-07-10 14:58adrianromeroReview Assigned To => adrianromero
2019-07-10 14:58adrianromeroNote Added: 0113256
2019-07-10 14:58adrianromeroStatusresolved => closed
2019-07-10 14:58adrianromeroFixed in Version => RR19Q4
2019-07-11 15:31hgbotCheckin
2019-07-11 15:31hgbotNote Added: 0113277
2019-07-11 15:31hgbotStatusclosed => resolved
2019-07-11 15:31hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/741ba45e7f60034549e4772c0c00f6877b735393 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal-discounts/rev/741ba45e7f60034549e4772c0c00f6877b735393 [^]
2019-07-11 18:56guilleaerNote Deleted: 0113277
2019-07-11 18:57guilleaerNote Added: 0113304
2019-07-11 18:57guilleaerStatusresolved => closed

Notes
(0113161)
hgbot   
2019-07-03 18:24   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 741ba45e7f60034549e4772c0c00f6877b735393
Author: Asier Martirena <asier.martirena <at> openbravo.com>
Date: Wed Jul 03 18:24:13 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/741ba45e7f60034549e4772c0c00f6877b735393 [^]

Fixed issue 41196: When the multi order process fails in the preOrderSave hook, it is not correctly managed

Now, when the pay open tickets flow fails during the preOrderSave hook, the order data is restored depending on the synchronized mode status.
If the synchronized mode is disabled, instead of restoring the order model to the frozen model, only those needed properties are set to the initial status.
In synchronized mode, the full order is restored. This means that the backbone model is fully changed. In addition, now the order list model is also restored (updated) to the frozed model, maintaining the same object in both orderList and multiOrder lists.
In addition, payments are always fully restored to the frozen status. Up to now, only the 'origAmount' was restored, having, for example, the property 'amount' with value zero after the values were restored.

If the preOrderSave hook fails, the Web POS waits until all orders have been treated until they are restored, to avoid to restore data in and then to modify the order after that.

---
M web/org.openbravo.retail.posterminal/js/data/dataordersave.js
---
(0113256)
adrianromero   
2019-07-10 14:58   
Verified
(0113304)
guilleaer   
2019-07-11 18:57   
reclosed