Openbravo Issue Tracking System - Localization Pack: Spain
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041191Localization Pack: SpainAEAT 340public2019-06-27 12:032019-07-02 11:44
Reportershuehner 
Assigned Toshuehner 
PrioritynormalSeveritytrivialReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Tovmromanos
Support ticket
OBNetwork customer
Regression introduced in release
Summary0041191: Remove the old, unused, no longer useful junit tests
DescriptionThis module contains 3 junit tests still extending the long deprecated BaseTest class.

Checking on the tests;
- their build.xml to run it does not work
- The unit tests have not been run a long time
- checking with VMA they are no longer useful to keep
Steps To Reproduce-
Proposed SolutionRemove the nit-tests + the build.xml in the module which only exists to run those from commandline.
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041188 closed shuehner Remove the old, unused, no longer useful junit tests 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-06-27 12:03shuehnerNew Issue
2019-06-27 12:03shuehnerAssigned To => shuehner
2019-06-27 12:03shuehnerRelationship addedrelated to 0041188
2019-06-27 12:33hgbotCheckin
2019-06-27 12:33hgbotNote Added: 0113051
2019-06-27 12:33hgbotStatusnew => resolved
2019-06-27 12:33hgbotResolutionopen => fixed
2019-06-27 12:33hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.module.aeat340.es/rev/35e084c299890ddbb8e94d631acf0b07b38f5c1d [^]
2019-06-27 15:22vmromanosReview Assigned To => vmromanos
2019-06-27 15:22vmromanosNote Added: 0113058
2019-06-27 15:22vmromanosStatusresolved => closed
2019-07-02 11:43hgbotCheckin
2019-07-02 11:43hgbotNote Added: 0113137
2019-07-02 11:43hgbotStatusclosed => resolved
2019-07-02 11:43hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.module.aeat340.es/rev/35e084c299890ddbb8e94d631acf0b07b38f5c1d [^] => http://code.openbravo.com/erp/pmods/org.openbravo.module.aeat340.es/rev/aaf8c6a43072aae679b21cf02b425422ee5a5a56 [^]
2019-07-02 11:44vmromanosStatusresolved => closed

Notes
(0113051)
hgbot   
2019-06-27 12:33   
Repository: erp/pmods/org.openbravo.module.aeat340.es
Changeset: 35e084c299890ddbb8e94d631acf0b07b38f5c1d
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Thu Jun 27 12:33:34 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.aeat340.es/rev/35e084c299890ddbb8e94d631acf0b07b38f5c1d [^]

Fixed 41191. Remove old obsolete junit tests.

- build.xml was only to run those from commandline
- Test used deprecated BaseTest from pi
  - never used a long time
  - not useful to keep around

---
R build.xml
R src-test/org/openbravo/test/AEAT340NumericAmountTest.java
R src-test/org/openbravo/test/AEAT340NumericTaxRateTest.java
R src-test/org/openbravo/test/AEAT340UtilityTest.java
---
(0113058)
vmromanos   
2019-06-27 15:22   
Code review OK
(0113137)
hgbot   
2019-07-02 11:43   
Repository: erp/pmods/org.openbravo.module.aeat340.es
Changeset: aaf8c6a43072aae679b21cf02b425422ee5a5a56
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Thu Jun 27 12:33:34 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.aeat340.es/rev/aaf8c6a43072aae679b21cf02b425422ee5a5a56 [^]

Fixed 41191. Remove old obsolete junit tests.

- build.xml was only to run those from commandline
- Test used deprecated BaseTest from pi
  - never used a long time
  - not useful to keep around

---
R build.xml
R src-test/org/openbravo/test/AEAT340NumericAmountTest.java
R src-test/org/openbravo/test/AEAT340NumericTaxRateTest.java
R src-test/org/openbravo/test/AEAT340UtilityTest.java
---