Openbravo Issue Tracking System - Localization Pack: Spain
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041188Localization Pack: SpainAEAT 190public2019-06-27 11:322019-06-27 15:21
Reportershuehner 
Assigned Toshuehner 
PrioritynormalSeveritytrivialReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Tovmromanos
Support ticket
OBNetwork customer
Regression introduced in release
Summary0041188: Remove the old, unused, no longer useful junit tests
DescriptionThis module contains 2 junit tests still extending the long deprecated BaseTest class.

Checking on the tests;
- their build.xml to run it does not work
- The unit tests have not been run a long time
- checking with VMA they are no longer useful to keep
Steps To Reproduce-
Proposed SolutionRemove the 2 unit-tests + the build.xml in the module which only exists to run those from commandline.
Additional Information
TagsNo tags attached.
Relationships
related to feature request 0041190 closed shuehner Remove the old, unused, no longer useful junit tests 
related to feature request 0041191 closed shuehner Remove the old, unused, no longer useful junit tests 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-06-27 11:32shuehnerNew Issue
2019-06-27 11:32shuehnerAssigned To => shuehner
2019-06-27 11:33shuehnerSummaryRemove the old, unused, no longer useless junit tests => Remove the old, unused, no longer useful junit tests
2019-06-27 11:38hgbotCheckin
2019-06-27 11:38hgbotNote Added: 0113049
2019-06-27 11:38hgbotStatusnew => resolved
2019-06-27 11:38hgbotResolutionopen => fixed
2019-06-27 11:38hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.module.aeat190.es/rev/876013ee00eb419e1211c77c240064987c150cf2 [^]
2019-06-27 11:50shuehnerRelationship addedrelated to 0041190
2019-06-27 12:03shuehnerRelationship addedrelated to 0041191
2019-06-27 15:21vmromanosReview Assigned To => vmromanos
2019-06-27 15:21vmromanosNote Added: 0113056
2019-06-27 15:21vmromanosStatusresolved => closed

Notes
(0113049)
hgbot   
2019-06-27 11:38   
Repository: erp/pmods/org.openbravo.module.aeat190.es
Changeset: 876013ee00eb419e1211c77c240064987c150cf2
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Thu Jun 27 11:35:08 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.aeat190.es/rev/876013ee00eb419e1211c77c240064987c150cf2 [^]

Fixed 41188. Remove old obsolete junit tests.

- build.xml was only to run those from commandline
- Test used deprecated BaseTest from pi
  - never used a long time
  - not useful to keep around

---
R build.xml
R src-test/org/openbravo/test/AEAT190NumericAmountTest.java
R src-test/org/openbravo/test/AEAT190UtilityTest.java
---
(0113056)
vmromanos   
2019-06-27 15:21   
Code review OK