Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041143Retail ModulesWeb POSpublic2019-06-21 07:262019-06-24 15:49
Reporterguillermogil 
Assigned Toguillermogil 
PriorityhighSeverityminorReproducibilityN/A
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR19Q3 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0041143: Change price approval should be configurable for services
DescriptionChange price approval should be configurable for services to allow to modify prices without approval for services but not for products.

This will allow the following behaviors based on configuration:
1.-
Product: No Approval
Service: No Approval
2.-
Product: Approval
Service: No Approval
3.-
Product: Approval
Service: Approval
Steps To Reproduce- Configure Change Price approval

- Login on WebPOS
- Add a product with a service
- Modify the price of the service
- Approval raises

- Modify preference "Web POS Change Service Price Need Approval" to Value "N"

- Login on WebPOS
- Add a product with a service
- Modify the price of the service
- No approval is show
- Modify the price of the Product
- The approval is shown
Proposed SolutionSee diff attached
Additional Information
TagsNo tags attached.
Relationships
related to defect 0052436 closed ranjith_qualiantech_com The "Web POS Change Service Price Need Approval" preference is not working 
Attached Filesdiff 41143.diff (6,238) 2019-06-21 08:33
https://issues.openbravo.com/file_download.php?file_id=13043&type=bug
diff 41143Test.diff (7,446) 2019-06-24 07:34
https://issues.openbravo.com/file_download.php?file_id=13046&type=bug
Issue History
Date ModifiedUsernameFieldChange
2019-06-21 07:26guillermogilNew Issue
2019-06-21 07:26guillermogilAssigned To => guillermogil
2019-06-21 07:26guillermogilTriggers an Emergency Pack => No
2019-06-21 08:23guillermogilFile Added: 41143.diff
2019-06-21 08:33guillermogilFile Deleted: 41143.diff
2019-06-21 08:33guillermogilFile Added: 41143.diff
2019-06-21 11:03guillermogilFile Added: 41143Test.diff
2019-06-24 07:34guillermogilFile Deleted: 41143Test.diff
2019-06-24 07:34guillermogilFile Added: 41143Test.diff
2019-06-24 09:55hgbotCheckin
2019-06-24 09:55hgbotNote Added: 0112963
2019-06-24 09:55hgbotCheckin
2019-06-24 09:55hgbotNote Added: 0112964
2019-06-24 09:55hgbotStatusnew => resolved
2019-06-24 09:55hgbotResolutionopen => fixed
2019-06-24 09:55hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/4a1152e7ff006549e995350573b2db12e4239714 [^]
2019-06-24 09:55hgbotCheckin
2019-06-24 09:55hgbotNote Added: 0112965
2019-06-24 15:49marvintmReview Assigned To => marvintm
2019-06-24 15:49marvintmStatusresolved => closed
2019-06-24 15:49marvintmFixed in Version => RR19Q3
2023-05-15 14:06ranjith_qualiantech_comRelationship addedrelated to 0052436

Notes
(0112963)
hgbot   
2019-06-24 09:55   
Repository: tools/automation/pi-mobile
Changeset: f9f38c2f69397f01e989211804e43c0de6177d77
Author: Guillermo Gil <guillermo.gil <at> openbravo.com>
Date: Fri Jun 21 11:03:38 2019 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/f9f38c2f69397f01e989211804e43c0de6177d77 [^]

Related to issue 41143: Added test case

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/TestIdPack.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/multiselection/ChangePriceMultipleLinesServiceApproval.java
---
(0112964)
hgbot   
2019-06-24 09:55   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 4a1152e7ff006549e995350573b2db12e4239714
Author: Guillermo Gil <guillermo.gil <at> openbravo.com>
Date: Fri Jun 21 11:03:54 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/4a1152e7ff006549e995350573b2db12e4239714 [^]

Fixed Issue 41143: Change price approval should be configurable for services

---
M src-db/database/sourcedata/AD_REF_LIST.xml
M web/org.openbravo.retail.posterminal/js/actions/changeprice.js
---
(0112965)
hgbot   
2019-06-24 09:55   
Repository: tools/automation/pi-mobile
Changeset: 2ebd24e7d099194b1abae7bc9438be868ab02239
Author: Guillermo Gil <guillermo.gil <at> openbravo.com>
Date: Mon Jun 24 07:32:11 2019 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/2ebd24e7d099194b1abae7bc9438be868ab02239 [^]

Related to issue 41143: Fixed test case

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/multiselection/ChangePriceMultipleLinesServiceApproval.java
---