Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041134Openbravo ERPC. Securitypublic2019-06-20 13:362019-08-22 14:44
Reportergorkaion 
Assigned Tocaristu 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR19Q4 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0041134: Stateless Requests should not check concurrent user limit
DescriptionWhen executing a ExternalOrderLoader requests. It defined as a stateless request so it does not generate any session. But if all the concurrent users are currently logged a "No valid license" exception is thrown.

Stateless request should be able to login and execute normally even if the concurrent user limit is reached.

The authentication is done by the HttpSecureAppServlet. In the service method after the authentication in case of stateless request it is checked the forceSysAdminLogin() method. This method returns true in case the concurrent user limit is reached. Even though this kind of requests should not check it.
Steps To ReproduceOn an activated instance consume all available concurrent users.
Try to execute a call to ExternalOrderLoader using SoapUI or similar.
Proposed Solution
Modify the ActivationKey.checkOPSLimitations so when there is no activeSession (stateless request) the concurrent user limitation is not checked. Patch provided.
Additional Information
TagsNo tags attached.
Relationships
Attached Filesdiff issue41134.diff (642) 2019-06-20 13:37
https://issues.openbravo.com/file_download.php?file_id=13029&type=bug
Issue History
Date ModifiedUsernameFieldChange
2019-06-20 13:36gorkaionNew Issue
2019-06-20 13:36gorkaionAssigned To => platform
2019-06-20 13:36gorkaionModules => Core
2019-06-20 13:36gorkaionResolution time => 1562796000
2019-06-20 13:36gorkaionTriggers an Emergency Pack => No
2019-06-20 13:37gorkaionFile Added: issue41134.diff
2019-06-28 14:24caristuAssigned Toplatform => caristu
2019-06-28 14:24caristuStatusnew => acknowledged
2019-07-05 17:46hgbotCheckin
2019-07-05 17:46hgbotNote Added: 0113205
2019-07-05 18:11hgbotCheckin
2019-07-05 18:11hgbotNote Added: 0113206
2019-07-05 18:11hgbotStatusacknowledged => resolved
2019-07-05 18:11hgbotResolutionopen => fixed
2019-07-05 18:11hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/aac71461cf2f41f3a421ea1bb1d100d3b1ef962c [^]
2019-07-05 18:11caristuReview Assigned To => alostale
2019-07-05 18:11caristuProposed Solution updated
2019-07-12 11:41alostaleNote Added: 0113324
2019-07-12 11:41alostaleStatusresolved => closed
2019-07-12 11:41alostaleFixed in Version => 3.0PR19Q4
2019-08-22 14:44hudsonbotCheckin
2019-08-22 14:44hudsonbotNote Added: 0114138
2019-08-22 14:44hudsonbotCheckin
2019-08-22 14:44hudsonbotNote Added: 0114139

Notes
(0113205)
hgbot   
2019-07-05 17:46   
Repository: erp/devel/pi
Changeset: 17f2fcf4f7ea4bbc1915efd7e07ce882678503b7
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Fri Jul 05 17:46:35 2019 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/17f2fcf4f7ea4bbc1915efd7e07ce882678503b7 [^]

related to issue 41134: apply correct formatting

---
M src/org/openbravo/erpCommon/obps/ActivationKey.java
---
(0113206)
hgbot   
2019-07-05 18:11   
Repository: erp/devel/pi
Changeset: aac71461cf2f41f3a421ea1bb1d100d3b1ef962c
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Fri Jul 05 18:10:55 2019 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/aac71461cf2f41f3a421ea1bb1d100d3b1ef962c [^]

fixes issue 41134: Stateless Requests should not check concurrent user limit

  In case of stateless requests check OBPS limitations but do not check if the concurrent user limit is reached

---
M src/org/openbravo/base/secureApp/HttpSecureAppServlet.java
M src/org/openbravo/erpCommon/obps/ActivationKey.java
---
(0113324)
alostale   
2019-07-12 11:41   
reviewed + tested
(0114138)
hudsonbot   
2019-08-22 14:44   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ad3efd3bd07c [^]
Maturity status: Test
(0114139)
hudsonbot   
2019-08-22 14:44   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ad3efd3bd07c [^]
Maturity status: Test