Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041133Openbravo ERP07. Sales managementpublic2019-06-20 13:142019-08-22 11:29
Reporteraferraz 
Assigned Tononofrancisco 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR19Q3Fixed in Version 
Merge Request Status
Review Assigned ToSandrahuguet
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression levelProduction - QA Approved
Regression date2019-02-28
Regression introduced in release3.0PR19Q2
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/aed4d4a47cd18723828c141de4ab3e43b40c161d [^]
Triggers an Emergency PackNo
Summary0041133: Sales Representative selector doesn't filter by natural tree anymore
DescriptionAfter allowing cross organization reference in some SalesRep_ID columns, Sales Representative selector doesn't filter by natural tree anymore.
Steps To ReproduceUsing F&B group admin role:
- Create a new Sales Order
- Select F&B España - Región Norte organization
- Click on Sales Representative selector
Check Sales Representatives from USA are displayed.
Only Sales Representatives from Spain should be displayed.
Proposed SolutionAdd a validation to filter by natural tree organizations in following columns:
C_Order.SalesRep_ID
M_InOut.SalesRep_ID
C_Invoice.SalesRep_ID
Additional Information
TagsNo tags attached.
Relationships
depends on backport 00411373.0PR19Q2.1 closed nonofrancisco Openbravo ERP Sales Representative selector doesn't filter by natural tree anymore 
caused by feature request 0040257RR19Q2 closed aferraz Retail Modules Cross Store Payments & Returns project 
related to defect 00411323.0PR19Q3 closed nonofrancisco Openbravo ERP Business Partner selector doesn't filter by natural tree anymore 
related to feature request 0041135 new Triage Platform Base Openbravo ERP Add the ability to filter by natural tree in selectors based on columns allowing cross org reference 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-06-20 13:14aferrazNew Issue
2019-06-20 13:14aferrazAssigned To => Triage Finance
2019-06-20 13:14aferrazOBNetwork customer => No
2019-06-20 13:14aferrazModules => Core
2019-06-20 13:14aferrazRegression level => Production - QA Approved
2019-06-20 13:14aferrazRegression date => 2019-02-28
2019-06-20 13:14aferrazRegression introduced in release => 3.0PR19Q2
2019-06-20 13:14aferrazRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/aed4d4a47cd18723828c141de4ab3e43b40c161d [^]
2019-06-20 13:14aferrazTriggers an Emergency Pack => No
2019-06-20 13:14aferrazIssue generated from0041132
2019-06-20 13:16aferrazRelationship addedrelated to 0041132
2019-06-20 13:16aferrazRelationship addedcaused by 0040257
2019-06-20 13:45SandrahuguetAssigned ToTriage Finance => nonofrancisco
2019-06-20 13:51aferrazRelationship addedrelated to 0041135
2019-06-20 13:52aferrazTarget Version => 3.0PR19Q3
2019-06-20 15:54SandrahuguetStatusnew => scheduled
2019-06-20 20:24nonofranciscoNote Added: 0112925
2019-06-26 17:34hgbotCheckin
2019-06-26 17:34hgbotNote Added: 0113041
2019-06-26 17:34hgbotStatusscheduled => resolved
2019-06-26 17:34hgbotResolutionopen => fixed
2019-06-26 17:34hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/78b5dfcfa2ebe9670eeaa67f7b383f85f2712711 [^]
2019-06-26 17:45SandrahuguetReview Assigned To => Sandrahuguet
2019-06-26 17:45SandrahuguetNote Added: 0113044
2019-06-26 17:45SandrahuguetStatusresolved => closed
2019-06-26 17:45SandrahuguetFixed in Version => 3.0PR19Q3
2019-06-26 17:57SandrahuguetStatusclosed => new
2019-06-26 17:57SandrahuguetResolutionfixed => open
2019-06-26 17:57SandrahuguetFixed in Version3.0PR19Q3 =>
2019-06-27 08:42SandrahuguetStatusnew => scheduled
2019-06-27 08:42SandrahuguetStatusscheduled => resolved
2019-06-27 08:42SandrahuguetResolutionopen => fixed
2019-06-27 08:42SandrahuguetStatusresolved => closed
2019-06-28 00:15hudsonbotCheckin
2019-06-28 00:15hudsonbotNote Added: 0113085
2019-08-22 11:29SandrahuguetNote Added: 0114116

Notes
(0112925)
nonofrancisco   
2019-06-20 20:24   
Test Plan

As Openbravo / F&B International Group Admin:

Create a new Sales Order
  Organization: F&B España - Región Norte
  Click on Sales Representative selector
Verify just Sales Representatives from España are shown (Javier Martin and Juan López)
  Change Orgaization to F&B US East Coast
Verify just Sales Representatives from USA are shown (John Smith)
(0113041)
hgbot   
2019-06-26 17:34   
Repository: erp/devel/pi
Changeset: 78b5dfcfa2ebe9670eeaa67f7b383f85f2712711
Author: Nono Carballo <nonofce <at> gmail.com>
Date: Mon Jun 24 10:08:08 2019 -0400
URL: http://code.openbravo.com/erp/devel/pi/rev/78b5dfcfa2ebe9670eeaa67f7b383f85f2712711 [^]

Fixes issue 41133: Filters AD_User by natural tree organization

A new validation rule was added to filters AD_User by natural tree organization.
The new rule was applied to columns C_Order.SalesRep_ID, M_InOut.SalesRep_ID
and C_Invoice.SalesRep_ID.

Test class was updated.

---
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_VAL_RULE.xml
M src-test/src/org/openbravo/test/security/CrossOrganizationUI.java
---
(0113044)
Sandrahuguet   
2019-06-26 17:45   
code review + testing ok
(0113085)
hudsonbot   
2019-06-28 00:15   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/a42da0b1e061 [^]
Maturity status: Test
(0114116)
Sandrahuguet   
2019-08-22 11:29   
automated test created