Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041132Openbravo ERP07. Sales managementpublic2019-06-20 13:092019-08-22 11:29
Reporteraferraz 
Assigned Tononofrancisco 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR19Q3Fixed in Version3.0PR19Q3 
Merge Request Status
Review Assigned ToSandrahuguet
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelPre packaging ( pi )
Regression date2019-06-03
Regression introduced in releasepi
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/f5c363681f43fab6f8bcadd6aad21ec14be00edc [^]
Triggers an Emergency PackNo
Summary0041132: Business Partner selector doesn't filter by natural tree anymore
DescriptionAfter allowing cross organization reference in some C_BPartner_ID columns, Business Partner selector doesn't filter by natural tree anymore.
Steps To ReproduceUsing F&B group admin role:
- Create a new Sales Order
- Select F&B España - Región Norte organization
- Click on Business Partner selector
Check Business Partners from USA are displayed.
Only Business Partners from Spain should be displayed.
Proposed SolutionAdd a validation to filter by natural tree organizations in following columns:
C_Order.C_BPartner_ID
C_OrderLine.C_BPartner_ID
M_InOut.C_BPartner_ID
M_InOutLine.C_Bpartner_ID
C_Invoice.C_BPartner_ID
C_InvoiceLine.C_Bpartner_ID
Additional Information
TagsNo tags attached.
Relationships
related to defect 00411333.0PR19Q3 closed nonofrancisco Openbravo ERP Sales Representative selector doesn't filter by natural tree anymore 
caused by feature request 0041006RR19Q3 closed aferraz Retail Modules Cross Store Sales project 
related to feature request 0041135 new Triage Platform Base Openbravo ERP Add the ability to filter by natural tree in selectors based on columns allowing cross org reference 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-06-20 13:09aferrazNew Issue
2019-06-20 13:09aferrazAssigned To => Triage Finance
2019-06-20 13:09aferrazModules => Core
2019-06-20 13:09aferrazTriggers an Emergency Pack => No
2019-06-20 13:10aferrazRegression level => Pre packaging ( pi )
2019-06-20 13:10aferrazRegression date => 2019-06-03
2019-06-20 13:10aferrazRegression introduced in release => pi
2019-06-20 13:10aferrazRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/f5c363681f43fab6f8bcadd6aad21ec14be00edc [^]
2019-06-20 13:11aferrazRelationship addedcaused by 0041006
2019-06-20 13:14aferrazIssue cloned0041133
2019-06-20 13:16aferrazRelationship addedrelated to 0041133
2019-06-20 13:45SandrahuguetAssigned ToTriage Finance => nonofrancisco
2019-06-20 13:51aferrazRelationship addedrelated to 0041135
2019-06-20 22:49nonofranciscoStatusnew => scheduled
2019-06-20 22:55nonofranciscoNote Added: 0112926
2019-06-27 15:43hgbotCheckin
2019-06-27 15:43hgbotNote Added: 0113060
2019-06-27 15:43hgbotStatusscheduled => resolved
2019-06-27 15:43hgbotResolutionopen => fixed
2019-06-27 15:43hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/b0c04c46544d06ade4dcc2f5011c924c0d71497c [^]
2019-06-27 15:49SandrahuguetReview Assigned To => Sandrahuguet
2019-06-27 15:49SandrahuguetNote Added: 0113061
2019-06-27 15:49SandrahuguetStatusresolved => closed
2019-06-27 15:49SandrahuguetFixed in Version => 3.0PR19Q3
2019-06-28 00:15hudsonbotCheckin
2019-06-28 00:15hudsonbotNote Added: 0113086
2019-08-22 11:29SandrahuguetNote Added: 0114117

Notes
(0112926)
nonofrancisco   
2019-06-20 22:55   
Test Plan

As Openbravo / F&B International Group Admin:

Create a new Sales Order
  Organization: F&B España - Región Norte
  Click on Business Partners selector
Verify just Business Partner from España are shown
  Change Orgaization to F&B US East Coast
Verify just Business Partners from USA are shown

Verify the Business Partner selector behave the same in the following windows
  Purchase Order
  Goods Receipt
  Goods Shipment
  Sales Invoice
  Purchase Invoice
(0113060)
hgbot   
2019-06-27 15:43   
Repository: erp/devel/pi
Changeset: b0c04c46544d06ade4dcc2f5011c924c0d71497c
Author: Nono Carballo <nonofce <at> gmail.com>
Date: Thu Jun 27 08:57:55 2019 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/b0c04c46544d06ade4dcc2f5011c924c0d71497c [^]

Fixes issue 41132: Filter BusinessPartner by natural organization

A new Filter Expression was added to BusinessPartner selector to filter business
partner by natural organization. The filter expression adds the filter only if
the selector is being used by BusinessPartner column in tables C_INVOICE,
C_INVOICELINE, M_INOUT, M_INOUTLINE, C_ORDER and C_ORDERLINE

Test class was updated.

---
M src-db/database/sourcedata/OBUISEL_SELECTOR.xml
M src-test/src/org/openbravo/test/security/CrossOrganizationUI.java
A src/org/openbravo/erpCommon/info/BusinessPartnerSelectorFilterExpression.java
---
(0113061)
Sandrahuguet   
2019-06-27 15:49   
code review + testing ok
(0113086)
hudsonbot   
2019-06-28 00:15   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/a42da0b1e061 [^]
Maturity status: Test
(0114117)
Sandrahuguet   
2019-08-22 11:29   
automated test created