Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041127Retail ModulesWeb POSpublic2019-06-17 13:292019-07-12 15:10
Reporterguillermogil 
Assigned Toguilleaer 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR19Q2.1Fixed in VersionRR19Q2.1 
Merge Request Status
Review Assigned Toguilleaer
OBNetwork customer
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2019-12-16
Regression introduced in releaseRR19Q1
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/331aa4146a49 [^]
Triggers an Emergency PackNo
Summary0041127: QtyDelivered has changed its representation on DB
DescriptionQtyDelivered has changed its representation on DB and now is saved with decimal values and before 19Q1 it did not have decimal values at database level.
As an example:
On 18Q4 qtyDelivered at DB level was 1
On 19Q1 qtyDelivered at DB level is 1.0

As the representation of the value have changed some third party integration could be broken.

It will happen with every column saved with a "BigDecimal.valueof"
Previously it was a "new BigDecimal"

It will be needed to check OrderLoader to review all the properties that have changed.
We've identified QtyDelivered column but it is needed to check for more.
Steps To ReproduceCreate a ticket on WebPOS and check QtyDelivered column.
Proposed SolutionModify:
BigDecimal.valueOf(jsonOrderLine.getDouble("XXX"))

To:
new BigDecimal(jsonOrderLine.getString("XXX"))

See diff attached.
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0041103 closed guilleaer QtyDelivered has changed its representation on DB 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-06-19 16:05migueldejuanaTypedefect => backport
2019-06-19 16:05migueldejuanaTarget Version => RR19Q2.1
2019-06-19 16:10hgbotCheckin
2019-06-19 16:10hgbotNote Added: 0112899
2019-06-19 16:10hgbotStatusscheduled => resolved
2019-06-19 16:10hgbotResolutionopen => fixed
2019-06-19 16:10hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6bc44e82d318c0563a74a88db91941db7154bbb5 [^] => http://code.openbravo.com/retail/backports/3.0RR19Q2.1/org.openbravo.retail.posterminal/rev/fe2ee27e12d44a28fc68a11bf51cf819b01235b1 [^]
2019-06-19 16:12hgbotCheckin
2019-06-19 16:12hgbotNote Added: 0112900
2019-07-12 15:10guilleaerReview Assigned To => guilleaer
2019-07-12 15:10guilleaerStatusresolved => closed
2019-07-12 15:10guilleaerFixed in Version => RR19Q2.1

Notes
(0112899)
hgbot   
2019-06-19 16:10   
Repository: retail/backports/3.0RR19Q2.1/org.openbravo.retail.posterminal
Changeset: fe2ee27e12d44a28fc68a11bf51cf819b01235b1
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Wed Jun 19 16:10:39 2019 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR19Q2.1/org.openbravo.retail.posterminal/rev/fe2ee27e12d44a28fc68a11bf51cf819b01235b1 [^]

fixed Issue 41127: Use new instead of value of for qtyDelivered

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
---
(0112900)
hgbot   
2019-06-19 16:12   
Repository: retail/backports/3.0RR19Q2.1/pi-mobile
Changeset: 50359de9ba83a84500869d75575e3cf0c7c6158c
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Wed Jun 19 16:12:15 2019 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR19Q2.1/pi-mobile/rev/50359de9ba83a84500869d75575e3cf0c7c6158c [^]

Related to issue 41127: Adapt test

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/productlockeddiscontinued/VerifyProductDiscontinuedWithoutStock.java
---