Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041105Retail ModulesWeb POSpublic2019-06-17 14:172019-06-28 11:22
Reporterprakashmurugesan88 
Assigned Toranjith_qualiantech_com 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR19Q3 
Merge Request Status
Review Assigned Toguilleaer
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0041105: Validation for 'Web POS Forbid Anonymous Customer use a Credit Note ' is not working
DescriptionWhen the preference 'Web POS Forbid Anonymous Customer use a Credit Note ' is set.
It should not allow to create a credit note for "Anonymous Customer".
It should throw error on selecting the "Credit Note" payment.
However currently it is allowing to create credit note for "Anonymous Customer" even the preference is set.

Related to: https://issues.openbravo.com/view.php?id=37673 [^]
Steps To ReproduceIn Backend
Configure preference "'Web POS Forbid Anonymous Customer use a Credit Note'" with value "Y".

In WEBPOS:
Create an receipt for anonymous customer.
Do verified return for the created receipt.
Now in payment select the payment method "Credit Note".

Notice: No Error is thrown.

Expected: Error must be displayed.
Proposed SolutionIn afterPaymentSelectedHook implement OBMOBC_PrePaymentSelected instead of OBPOS_PrePaymentSelected
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-06-17 14:17prakashmurugesan88New Issue
2019-06-17 14:17prakashmurugesan88Assigned To => Retail
2019-06-17 14:17prakashmurugesan88Triggers an Emergency Pack => No
2019-06-17 14:23kchoperenaResolution time => 1561932000
2019-06-17 14:23kchoperenaDescription Updatedbug_revision_view_page.php?rev_id=18940#r18940
2019-06-17 14:23kchoperenaProposed Solution updated
2019-06-19 14:30ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2019-06-19 14:31ranjith_qualiantech_comStatusnew => scheduled
2019-06-26 15:59hgbotCheckin
2019-06-26 15:59hgbotNote Added: 0113037
2019-06-26 16:01hgbotCheckin
2019-06-26 16:01hgbotNote Added: 0113038
2019-06-26 16:01hgbotCheckin
2019-06-26 16:01hgbotNote Added: 0113039
2019-06-26 19:35hgbotCheckin
2019-06-26 19:35hgbotNote Added: 0113046
2019-06-27 13:15ranjith_qualiantech_comStatusscheduled => resolved
2019-06-27 13:15ranjith_qualiantech_comResolutionopen => fixed
2019-06-27 17:56guilleaerReview Assigned To => guilleaer
2019-06-27 17:57guilleaerStatusresolved => new
2019-06-27 17:57guilleaerResolutionfixed => open
2019-06-27 17:57guilleaerStatusnew => scheduled
2019-06-28 07:54hgbotCheckin
2019-06-28 07:54hgbotNote Added: 0113088
2019-06-28 07:54hgbotCheckin
2019-06-28 07:54hgbotNote Added: 0113089
2019-06-28 08:02hgbotCheckin
2019-06-28 08:02hgbotNote Added: 0113090
2019-06-28 11:14hgbotCheckin
2019-06-28 11:14hgbotNote Added: 0113093
2019-06-28 11:15hgbotCheckin
2019-06-28 11:15hgbotNote Added: 0113094
2019-06-28 11:15hgbotCheckin
2019-06-28 11:15hgbotNote Added: 0113095
2019-06-28 11:18ranjith_qualiantech_comStatusscheduled => resolved
2019-06-28 11:18ranjith_qualiantech_comResolutionopen => fixed
2019-06-28 11:22guilleaerStatusresolved => closed
2019-06-28 11:22guilleaerFixed in Version => RR19Q3

Notes
(0113037)
hgbot   
2019-06-26 15:59   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: d9555908473495ec4838367d31919a1a9c2ec64b
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Jun 26 19:28:59 2019 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/d9555908473495ec4838367d31919a1a9c2ec64b [^]

Related to issue 41105 : Added model args to OBMOBC_PrePaymentSelected hook

---
M web/org.openbravo.mobile.core/source/component/ob-keyboard.js
---
(0113038)
hgbot   
2019-06-26 16:01   
Repository: erp/pmods/org.openbravo.retail.giftcards
Changeset: b9b9be86397708e16d5dc6688a1f902aebf5f1d5
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Jun 26 19:30:51 2019 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/b9b9be86397708e16d5dc6688a1f902aebf5f1d5 [^]

Related to issue 41105 : Updated PrePaymentSelected hook when selecting payment method in payment tab

* In Pay open tickets, Anonymous Customer should be validated with all receipts
* OBPOS_PrePaymentSelected hook is replaced with OBMOBC_PrePaymentSelected,

---
M web/org.openbravo.retail.giftcards/js/hooks/afterPaymentSelectedHook.js
---
(0113039)
hgbot   
2019-06-26 16:01   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: f3c4aceacbe5dac4ab8ac9a609fb199eeb932475
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Jun 26 19:30:08 2019 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f3c4aceacbe5dac4ab8ac9a609fb199eeb932475 [^]

Related to issue 41105 : Removed unuseful canTap event for Payment method buttons

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/keyboard-toolbars.js
---
(0113046)
hgbot   
2019-06-26 19:35   
Repository: tools/automation/pi-mobile
Changeset: 0614fcca58edce0bafc7516918312efaea137971
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Jun 26 23:05:44 2019 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/0614fcca58edce0bafc7516918312efaea137971 [^]

Verifies issue 41105 : Modified Automated Test 'CreateCreditNoteWithAnonymous'

---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/creditnote/CreateCreditNoteWithAnonymous.java
---
(0113088)
hgbot   
2019-06-28 07:54   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 725a6375d0715a438b5e3cc3aeb0fdb1571b9651
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Fri Jun 28 11:23:54 2019 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/725a6375d0715a438b5e3cc3aeb0fdb1571b9651 [^]

Related to issue 41105 : Added Organization Anonymous Customer and Location in Terminal Properties

* Update Anonymous Customer condition instead terminal default customer

---
M src/org/openbravo/retail/posterminal/term/TerminalProperties.java
M web/org.openbravo.retail.posterminal/js/model/order.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/subwindows/customeraddress/components/sharedcomponents.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/subwindows/customers/components/sharedcomponents.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-left.js
---
(0113089)
hgbot   
2019-06-28 07:54   
Repository: erp/pmods/org.openbravo.retail.giftcards
Changeset: 302f5277ffe9e38fd364678e643faf3c1a1dd243
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Fri Jun 28 11:24:07 2019 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/302f5277ffe9e38fd364678e643faf3c1a1dd243 [^]

Related to issue 41105 : Update Anonymous Customer condition instead terminal default customer

---
M web/org.openbravo.retail.giftcards/js/hooks/afterPaymentSelectedHook.js
M web/org.openbravo.retail.giftcards/js/hooks/preOrderSaveHook.js
M web/org.openbravo.retail.giftcards/js/hooks/printGiftCardPrePrintHook.js
---
(0113090)
hgbot   
2019-06-28 08:02   
Repository: erp/pmods/org.openbravo.retail.contactinfoforproduct
Changeset: f0e1de330b9f8fa3dbe5c485491eb0038e82d5bd
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Fri Jun 28 11:31:56 2019 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.contactinfoforproduct/rev/f0e1de330b9f8fa3dbe5c485491eb0038e82d5bd [^]

Related to issue 41105 : Update Anonymous Customer condition instead terminal default customer

---
M web/org.openbravo.retail.contactinfoforproduct/js/modalItemDeclaration.js
---
(0113093)
hgbot   
2019-06-28 11:14   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 0e669adc22b617074c86d53e56aa7367ec18fac5
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Fri Jun 28 14:44:38 2019 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0e669adc22b617074c86d53e56aa7367ec18fac5 [^]

Related to issue 41105 : Backed out changeset: 725a6375d071

---
M src/org/openbravo/retail/posterminal/term/TerminalProperties.java
M web/org.openbravo.retail.posterminal/js/model/order.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/subwindows/customeraddress/components/sharedcomponents.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/subwindows/customers/components/sharedcomponents.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-left.js
---
(0113094)
hgbot   
2019-06-28 11:15   
Repository: erp/pmods/org.openbravo.retail.giftcards
Changeset: 3b769497ba6cbfa8008529eecf7ffd540c157b66
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Fri Jun 28 14:45:11 2019 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/3b769497ba6cbfa8008529eecf7ffd540c157b66 [^]

Related to issue 41105 : Backed out changeset: 302f5277ffe9

---
M web/org.openbravo.retail.giftcards/js/hooks/afterPaymentSelectedHook.js
M web/org.openbravo.retail.giftcards/js/hooks/preOrderSaveHook.js
M web/org.openbravo.retail.giftcards/js/hooks/printGiftCardPrePrintHook.js
---
(0113095)
hgbot   
2019-06-28 11:15   
Repository: erp/pmods/org.openbravo.retail.contactinfoforproduct
Changeset: 5dd030684b1e5ee63d66cfa685f586c4961689bb
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Fri Jun 28 14:45:24 2019 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.contactinfoforproduct/rev/5dd030684b1e5ee63d66cfa685f586c4961689bb [^]

Related to issue 41105 : Backed out changeset: f0e1de330b9f

---
M web/org.openbravo.retail.contactinfoforproduct/js/modalItemDeclaration.js
---