Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041094Openbravo ERPA. Platformpublic2019-06-14 09:242019-06-21 14:14
Reporterjarmendariz 
Assigned Tojarmendariz 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR19Q3 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0041094: Javascript formatting scripts fails on MacOSX
Descriptionjslint/jsformatter execution fails when executed in OSX. According to the provided screenshot, it is related to an argument using '--' in xargs.
Steps To ReproduceRun jslint, jsformatter or commit using the provided mercurial hooks on an OSX machine
Proposed SolutionThe syntax of some commands are slightly different between Linux/OSX. Change it and check it works on both machines
Additional Information
TagsNo tags attached.
Relationships
caused by feature request 0039983 closed jarmendariz Upgrade javascript linter and formatter 
Attached Filespng Screenshot from 2019-06-14 09-23-39.png (337,033) 2019-06-14 09:24
https://issues.openbravo.com/file_download.php?file_id=13019&type=bug
Issue History
Date ModifiedUsernameFieldChange
2019-06-14 09:24jarmendarizNew Issue
2019-06-14 09:24jarmendarizAssigned To => jarmendariz
2019-06-14 09:24jarmendarizFile Added: Screenshot from 2019-06-14 09-23-39.png
2019-06-14 09:24jarmendarizOBNetwork customer => No
2019-06-14 09:24jarmendarizModules => Core
2019-06-14 09:24jarmendarizTriggers an Emergency Pack => No
2019-06-14 09:25jarmendarizRelationship addedcaused by 0039983
2019-06-14 09:25jarmendarizStatusnew => scheduled
2019-06-17 11:37hgbotCheckin
2019-06-17 11:37hgbotNote Added: 0112809
2019-06-17 11:37hgbotStatusscheduled => resolved
2019-06-17 11:37hgbotResolutionopen => fixed
2019-06-17 11:37hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/a56212b85ebdfd89cf1a8b6e8509c9f832c1a9c8 [^]
2019-06-17 11:42jarmendarizReview Assigned To => caristu
2019-06-17 19:39hudsonbotCheckin
2019-06-17 19:39hudsonbotNote Added: 0112839
2019-06-21 14:14caristuNote Added: 0112943
2019-06-21 14:14caristuStatusresolved => closed
2019-06-21 14:14caristuFixed in Version => 3.0PR19Q3

Notes
(0112809)
hgbot   
2019-06-17 11:37   
Repository: erp/devel/pi
Changeset: a56212b85ebdfd89cf1a8b6e8509c9f832c1a9c8
Author: Javier Armendáriz <javier.armendariz <at> openbravo.com>
Date: Fri Jun 14 09:26:03 2019 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/a56212b85ebdfd89cf1a8b6e8509c9f832c1a9c8 [^]

Fixed issue 41094: Improved support for OSX

There are parts of the script that, although correct in linux, uses
options that are not supported on OSX:
* xargs --max-args is not present on OSX, replaced by -n
* find -printf is not present on BSD/OSX, for our purpose it can be
replaced by executing dirname

---
M modules/org.openbravo.client.kernel/jsformatter/jsformatter
M modules/org.openbravo.client.kernel/jsformatter/jsformatter-hg-hook
M modules/org.openbravo.client.kernel/jslint/jslint
M modules/org.openbravo.client.kernel/jslint/jslint-hg-hook
M modules/org.openbravo.client.kernel/jsutils/dir-functions
---
(0112839)
hudsonbot   
2019-06-17 19:39   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/2ad95dac1570 [^]
Maturity status: Test
(0112943)
caristu   
2019-06-21 14:14   
Reviewed