Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041068Openbravo ERPA. Platformpublic2019-06-11 10:452019-06-17 12:13
Reporteralostale 
Assigned Toalostale 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR19Q3 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0041068: incorrect CSS minification: repeated parameters are removed
DescriptionIn CSS minification repeated parameters are removed even they are necessary.
Steps To ReproduceThe following CSS:
.testElement { grid-template-columns: 1fr 1fr 1fr; }


gets minified to:
.testElement{grid-template-columns:1fr}


But this is not correct as the 3 repeated values should be kept.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0041060 closed alostale incorrect CSS minification: elements are incorrectly case lowered 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-06-11 10:45alostaleNew Issue
2019-06-11 10:45alostaleAssigned To => platform
2019-06-11 10:45alostaleModules => Core
2019-06-11 10:45alostaleTriggers an Emergency Pack => No
2019-06-11 10:46alostaleRelationship addedrelated to 0041060
2019-06-11 10:46alostaleAssigned Toplatform => alostale
2019-06-11 10:46alostaleReview Assigned To => caristu
2019-06-11 10:56hgbotCheckin
2019-06-11 10:56hgbotNote Added: 0112572
2019-06-11 10:56hgbotStatusnew => resolved
2019-06-11 10:56hgbotResolutionopen => fixed
2019-06-11 10:56hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/2548df988fe829bb199d4d139da930308f66683b [^]
2019-06-11 15:26hudsonbotCheckin
2019-06-11 15:26hudsonbotNote Added: 0112581
2019-06-17 12:13caristuNote Added: 0112813
2019-06-17 12:13caristuStatusresolved => closed
2019-06-17 12:13caristuFixed in Version => 3.0PR19Q3

Notes
(0112572)
hgbot   
2019-06-11 10:56   
Repository: erp/devel/pi
Changeset: 2548df988fe829bb199d4d139da930308f66683b
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Tue Jun 11 10:55:23 2019 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/2548df988fe829bb199d4d139da930308f66683b [^]

fixed bug 41068: incorrect CSS minification: repeated parameters are removed

  Do not try to remove any duplicated parameter

---
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/CSSMinimizer.java
M src-test/src/org/openbravo/client/kernel/CSSMinifier.java
---
(0112581)
hudsonbot   
2019-06-11 15:26   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/26c6f3135279 [^]
Maturity status: Test
(0112813)
caristu   
2019-06-17 12:13   
Code reviewed + tested OK.