Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041060Openbravo ERPA. Platformpublic2019-06-10 15:202019-06-17 12:12
Reporteralostale 
Assigned Toalostale 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR19Q3 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0041060: incorrect CSS minification: elements are incorrectly case lowered
DescriptionWhen CSS are minified (modules not in development), there are some mismatches due to incorrect capitalization.
Steps To ReproduceHaving the following CSS:

.testGridContainer {
    grid-template-areas: "obUiMultiColumn-left-leftToolbar obUiMultiColumn-right-rightToolbar";

}

.testGridElement {
    grid-area: obUiMultiColumn-left-leftToolbar;
}


It gets minified to:

.testGridContainer {
    grid-template-areas: "obUiMultiColumn-left-leftToolbar obUiMultiColumn-right-rightToolbar"

}

.testGridElement {
    grid-area: obuimulticolumn-left-lefttoolbar
}


Note grid-area value has been lower cased whereas grid-template-areas has preserved case, making it not to match.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0041068 closed alostale incorrect CSS minification: repeated parameters are removed 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-06-10 15:20alostaleNew Issue
2019-06-10 15:20alostaleAssigned To => platform
2019-06-10 15:20alostaleOBNetwork customer => No
2019-06-10 15:20alostaleModules => Core
2019-06-10 15:20alostaleTriggers an Emergency Pack => No
2019-06-10 17:34guilleaerNote Added: 0112553
2019-06-11 10:43alostaleSummaryincorrect CSS minification => incorrect CSS minification: elements are incorrectly case lowered
2019-06-11 10:46alostaleRelationship addedrelated to 0041068
2019-06-11 10:46alostaleAssigned Toplatform => alostale
2019-06-11 10:46alostaleReview Assigned To => caristu
2019-06-11 10:47alostaleNote Added: 0112570
2019-06-11 10:56hgbotCheckin
2019-06-11 10:56hgbotNote Added: 0112571
2019-06-11 10:56hgbotStatusnew => resolved
2019-06-11 10:56hgbotResolutionopen => fixed
2019-06-11 10:56hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/6efd74bcb00be75d8b2566bf6b2f9c00924b839a [^]
2019-06-11 15:26hudsonbotCheckin
2019-06-11 15:26hudsonbotNote Added: 0112580
2019-06-17 12:12caristuNote Added: 0112812
2019-06-17 12:12caristuStatusresolved => closed
2019-06-17 12:12caristuFixed in Version => 3.0PR19Q3

Notes
(0112553)
guilleaer   
2019-06-10 17:34   
I detected one case which is quite similar, also related with a css grid property

    grid-template-columns: 1fr 1fr 1fr;

Is converted by minifier to

    grid-template-columns: 1fr;

I have worked around the problem using repeat function which works fine

    grid-template-columns: repeat(3,1fr);
(0112570)
alostale   
2019-06-11 10:47   
The latest case reported a different issue 0041068
(0112571)
hgbot   
2019-06-11 10:56   
Repository: erp/devel/pi
Changeset: 6efd74bcb00be75d8b2566bf6b2f9c00924b839a
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Tue Jun 11 10:43:46 2019 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/6efd74bcb00be75d8b2566bf6b2f9c00924b839a [^]

fixed bug 41060: CSS minification: elements are incorrectly case lowered

  Do not lower case elements as it can cause mismatches.

---
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/CSSMinimizer.java
M src-test/src/org/openbravo/test/AllAntTaskTests.java
A src-test/src/org/openbravo/client/kernel/CSSMinifier.java
---
(0112580)
hudsonbot   
2019-06-11 15:26   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/26c6f3135279 [^]
Maturity status: Test
(0112812)
caristu   
2019-06-17 12:12   
Reviewed + tested OK.