Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041025Retail ModulesSessionspublic2019-06-04 16:472019-12-30 17:38
Reporterumartirena 
Assigned Toranjith_qualiantech_com 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR19Q4 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerGold
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0041025: Login process asks for Cash up unnecessarily if there is a cashup record in Errors While Importing
DescriptionLogin process asks for Cash up unnecessarily if there is a cashup record in Errors While Importing. It is necessary to close the store and open it again to be able to reproduce the issue.
Steps To ReproduceLogin in https://livebuilds.openbravo.com/retail_modules_pgsql_pi/web/org.openbravo.retail.posterminal/?terminal=VBS-1 [^]
 * Create a ticket
 * Before paying it open developer tools and a breakpoint in the 7th line of the following code (The idea is to force an Error While Importing)

 OB.UTIL.HookManager.executeHooks('OBPOS_PreOrderSave', {
          context: context,
          model: model,
          receipt: model.get('order')
        }, function (args) {
          var receipt = args.context.receipt;
          if (args && args.cancellation && args.cancellation === true) {
            args.context.receipt.set('isbeingprocessed', 'N');

 * Execute "receipt.set('isLayaway', true)"
 * Continue the execution.
 * After the order is closed make a cashup
 * Go to https://livebuilds.openbravo.com/retail_modules_pgsql_pi [^]
 * Check that there is an error for the previous Order and the Cashup.
 * Open Close Store
 * Close Vallblanca Store
 * It will ask for Close tills. Close them and again Close the Store
 * Open Vallblanca Store
 * Login in https://livebuilds.openbravo.com/retail_modules_pgsql_pi/web/org.openbravo.retail.posterminal/?terminal=VBS-1 [^]
 * Check that it asks for a cashup. Do it
 * Once finished login again. Check that again asks for a cashup and it is not possible any more to login in the application.
 * It should not ask for a cashup if there is one in Errors While Importing.
   
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0041446 closed ranjith_qualiantech_com Duplicated cashup requests under specific circumstances in Synchronized Mode 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-06-04 16:47umartirenaNew Issue
2019-06-04 16:47umartirenaAssigned To => Retail
2019-06-04 16:47umartirenaOBNetwork customer => Gold
2019-06-04 16:47umartirenaTriggers an Emergency Pack => No
2019-06-04 16:48umartirenaResolution time => 1561413600
2019-06-04 17:28lmonrealIssue Monitored: martinsdan
2019-06-04 17:28lmonrealIssue Monitored: lmonreal
2019-06-11 14:23ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2019-06-11 14:23ranjith_qualiantech_comStatusnew => scheduled
2019-07-04 08:21hgbotCheckin
2019-07-04 08:21hgbotNote Added: 0113165
2019-07-04 10:05hgbotCheckin
2019-07-04 10:05hgbotNote Added: 0113169
2019-07-04 13:17hgbotCheckin
2019-07-04 13:17hgbotNote Added: 0113179
2019-07-04 17:44ranjith_qualiantech_comStatusscheduled => resolved
2019-07-04 17:44ranjith_qualiantech_comResolutionopen => fixed
2019-07-05 09:03marvintmReview Assigned To => marvintm
2019-07-05 09:03marvintmStatusresolved => closed
2019-07-05 09:03marvintmFixed in Version => RR19Q4
2019-12-30 17:38ngarciaRelationship addedrelated to 0041446

Notes
(0113165)
hgbot   
2019-07-04 08:21   
Repository: erp/pmods/org.openbravo.retail.sessions
Changeset: 3e47afad082e0ddcb482af42e9c8ff91813e174c
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Jul 04 11:50:50 2019 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.sessions/rev/3e47afad082e0ddcb482af42e9c8ff91813e174c [^]

Related to issue 41025 : Force Cashup should not be shown if cashup record presents in errors list

* If terminal is closed in backoffice and cashup record presents in errors list,
  then when login, Force Cashup popup should not be shown

---
M src/org/openbravo/retail/sessions/TerminalProperties.java
---
(0113169)
hgbot   
2019-07-04 10:05   
Repository: erp/pmods/org.openbravo.retail.sessions
Changeset: 698a2bc50b453b76d90372e0163d3a504b068556
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Jul 04 13:35:10 2019 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.sessions/rev/698a2bc50b453b76d90372e0163d3a504b068556 [^]

Related to issue 41025 : Backed out changeset: 3e47afad082e

---
M src/org/openbravo/retail/sessions/TerminalProperties.java
---
(0113179)
hgbot   
2019-07-04 13:17   
Repository: erp/pmods/org.openbravo.retail.sessions
Changeset: 7291dd5d397d53ce830292a5636bc75ea8e8251c
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Jul 04 16:47:45 2019 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.sessions/rev/7291dd5d397d53ce830292a5636bc75ea8e8251c [^]

Related to issue 41025 : Force Cashup should not be shown if cashup record presents in errors list

* If terminal is closed in backoffice and cashup record presents in errors list,
  then when login, Force Cashup popup should not be shown

---
M src/org/openbravo/retail/sessions/TerminalProperties.java
---