0041024: Cannot open Payment Execution form if there are more than 1000 payment methods

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0041024

Openbravo ERP

09. Financial management

public

2019-05-28 17:19

2019-06-05 16:46

Reporter

ngarcia

Assigned To

nonofrancisco

Priority

urgent

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

3.0PR19Q1.2

Fixed in Version

3.0PR19Q1.2

Merge Request Status

Review Assigned To

Sandrahuguet

OBNetwork customer

Web browser

Modules

Core

Support ticket

Regression level

Production - Confirmed Stable

Regression date

2017-10-10

Regression introduced in release

3.0PR18Q1

Regression introduced by commit

https://code.openbravo.com/erp/devel/pi/rev/9cf1f8c7de280894eb268e310a732b3e61cd128d [^]

Triggers an Emergency Pack

Summary

0041024: Cannot open Payment Execution form if there are more than 1000 payment methods

Description

Cannot open Payment Execution form if there are more than 1000 payment methods

Steps To Reproduce

Log in with 'The White Valley Group Admin' role
Open the Payment Execution window
Check the following error is shown:
   "org.hibernate.exception.SQLGrammarException: could not execute query"
The log shows:

ERROR org.openbravo.advpaymentmngt.ad_forms.BatchPaymentExecution - Error captured:
org.hibernate.exception.SQLGrammarException: could not extract ResultSet
...
    at org.openbravo.dal.service.OBCriteria.list(OBCriteria.java:103) ~[OBCriteria.class:?]
    at org.openbravo.advpaymentmngt.dao.AdvPaymentMngtDao.getFilteredPaymentMethods(AdvPaymentMngtDao.java:874) ~[AdvPaymentMngtDao.class:?]
    at org.openbravo.advpaymentmngt.utility.FIN_Utility.getPaymentMethodList(FIN_Utility.java:505) ~[FIN_Utility.class:?]
    at org.openbravo.advpaymentmngt.ad_forms.BatchPaymentExecution.printPageDataSheet(BatchPaymentExecution.java:205) ~[BatchPaymentExecution.class:?]
    at org.openbravo.advpaymentmngt.ad_forms.BatchPaymentExecution.doPost(BatchPaymentExecution.java:85) ~[BatchPaymentExecution.class:?]

Proposed Solution

The problem is in the addPaymentMethodList function of AdvPaymentMngtDao class. The following line is leaving the paymentMethods empty

paymentMethods.removeAll(paymentMethodsToRemove);

and the following instruction is not calculating the size correctly:

paymentMethodsSize = paymentMethodsSize - 999;

so the following condition is included in the query:

or this_.Fin_Paymentmethod_ID in ()

Additional Information