Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041016Openbravo ERPA. Platformpublic2019-06-04 09:482019-06-14 11:00
Reporteregoitz 
Assigned Tocaristu 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR19Q3 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0041016: creating new record in grid, empty record generated if clicking line while retrieving defaults
DescriptionWhen creating a new record in grid view, if the new line is clicked while retrieving default values before it becomes editable, a new empty record is created.
Steps To Reproduce1. Apply the attached patch to make FIC slower
2. Open Sales Order window and create a new header
3. Go to child tab
4. Click on create one link
5. Before the new line becomes editable, click on Ordered Quantity field
  -> ERROR:
      - new empty record is created with all its fields in red and without any default value set



*see attached image
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 00398653.0PR19Q3 closed AugustoMauch [19Q1] [KS] It is possible to create an empty record from an empty record 
related to defect 0031571 closed caristu Error after canceling a record edition under some circumstances 
related to defect 00252173.0MP30 closed AugustoMauch When using tab to save a new record in the grid, the focus does not go to the next record 
related to defect 00247413.0MP28 closed AugustoMauch Error when inserting a row on grid mode pressing tab key for selecting a value on a selector 
related to defect 0019830 closed AugustoMauch Error message is not shown when using Enter key to exit an invalid row 
Attached Filespng Screenshot from 2019-06-04 09-47-57.png (119,592) 2019-06-04 09:48
https://issues.openbravo.com/file_download.php?file_id=13000&type=bug
png

diff 41016-mcve.diff (1,299) 2019-06-04 10:41
https://issues.openbravo.com/file_download.php?file_id=13002&type=bug
Issue History
Date ModifiedUsernameFieldChange
2019-06-04 09:48egoitzNew Issue
2019-06-04 09:48egoitzAssigned To => platform
2019-06-04 09:48egoitzFile Added: Screenshot from 2019-06-04 09-47-57.png
2019-06-04 09:48egoitzModules => Core
2019-06-04 09:48egoitzResolution time => 1560808800
2019-06-04 09:48egoitzTriggers an Emergency Pack => No
2019-06-04 09:48egoitzRelationship addedrelated to 0039865
2019-06-04 10:18egoitzNote Added: 0112369
2019-06-04 10:41alostaleFile Added: 41016-mcve.diff
2019-06-04 10:48alostaleSummaryIt is possible to create an empty record from an empty record (2) => creating new record in grid, empty record generated if clicking line while retrieving defaults
2019-06-04 10:48alostaleDescription Updatedbug_revision_view_page.php?rev_id=18871#r18871
2019-06-04 10:48alostaleSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=18873#r18873
2019-06-04 11:16alostaleStatusnew => acknowledged
2019-06-07 12:06caristuRelationship addedrelated to 0031571
2019-06-07 12:07caristuRelationship addedrelated to 0025217
2019-06-07 12:09caristuRelationship addedrelated to 0024741
2019-06-07 13:47caristuRelationship addedrelated to 0019830
2019-06-07 13:47caristuAssigned Toplatform => caristu
2019-06-07 13:47caristuStatusacknowledged => scheduled
2019-06-10 09:45hgbotCheckin
2019-06-10 09:45hgbotNote Added: 0112530
2019-06-10 09:45hgbotStatusscheduled => resolved
2019-06-10 09:45hgbotResolutionopen => fixed
2019-06-10 09:45hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/6beb7213986ff94c24d50bd7ee23ab1b4f72e4b6 [^]
2019-06-10 09:45caristuReview Assigned To => alostale
2019-06-10 14:05hudsonbotCheckin
2019-06-10 14:05hudsonbotNote Added: 0112538
2019-06-14 11:00alostaleNote Added: 0112785
2019-06-14 11:00alostaleStatusresolved => closed
2019-06-14 11:00alostaleFixed in Version => 3.0PR19Q3

Notes
(0112369)
egoitz   
2019-06-04 10:18   
Other way to reproduce:

1- Create header (Sales order)
2- cick on the child tab
3- click on the create one link
4-A new line appear
5- click on the header section
6 - the line appears in read
7 - click again on the child section and you are able to click on the new line tool bar button
(0112530)
hgbot   
2019-06-10 09:45   
Repository: erp/devel/pi
Changeset: 6beb7213986ff94c24d50bd7ee23ab1b4f72e4b6
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Fri Jun 07 15:20:19 2019 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/6beb7213986ff94c24d50bd7ee23ab1b4f72e4b6 [^]

fixes bug 41016: empty record created if clicking line while retrieving defaults

  The cell edition was being completed when clicking on a cell in the same row which is disabled. Because of this, it was possible to create an empty record without all the mandatory fields set.

  To avoid this problem, now the doCellEditEnd function takes into account if we are trying to move to a disabled cell and, in that case, if we have mandatory fields pending to be filled then the cell edit end process is not completed.

  Note that the getNextEditCell() function of the OBViewGrid returns null if the next cell to be edited is disabled. That is why are adding the "nextEditCell === null" check.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js
---
(0112538)
hudsonbot   
2019-06-10 14:05   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/3a803275fa99 [^]
Maturity status: Test
(0112785)
alostale   
2019-06-14 11:00   
reviewed + tested