0040994: Store server transition to offline has too long wait time, uses an old preference and can be simplified

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0040994

Retail Modules

StoreServer

public

2019-05-31 15:00

2019-06-08 16:54

Reporter

mtaal

Assigned To

mtaal

Priority

normal

Severity

minor

Reproducibility

have not tried

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

Merge Request Status

Review Assigned To

OBNetwork customer

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0040994: Store server transition to offline has too long wait time, uses an old preference and can be simplified

Description

The transition to offline process does different kinds of logic during the transition to offline which is not needed as it is already done before going to transition to offline:
- the intervaltime at the customer was set at 10 secs which was below the treshold in the code [6], so transition to offline always took 1 minute which is too long.
- checkoffline handlers [1] is already done here [2]
- it is using a wrong service to check cs availability [3], it should use [4]
- its checks stockmd to see if it is online or offline [5] but the decision to go offline is already made before so can't be repeated as one server can say yes go offline, while another says not can't go offline.

[1]
https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/ca7eed56ca97/src/org/openbravo/mobile/core/servercontroller/MobileMainServerCheck.java#l198 [^]

[2]
https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/ca7eed56ca97/src/org/openbravo/mobile/core/servercontroller/MobileServerController.java#l486 [^]

[3]
https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/ca7eed56ca97/src/org/openbravo/mobile/core/servercontroller/MobileMainServerCheck.java#l231 [^]

[4]
https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/tip/src/org/openbravo/mobile/core/servercontroller/MobileServerRequestExecutor.java#l310 [^]

[5]
https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/ca7eed56ca97/src/org/openbravo/mobile/core/servercontroller/MobileMainServerCheck.java#l206 [^]

[6]
https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/ca7eed56ca97/src/org/openbravo/mobile/core/servercontroller/MobileMainServerCheck.java#l72 [^]

Steps To Reproduce

Install multi-server

Proposed Solution

Just wait a preset configured time and then go offline. The wait time is needed to give the cs some time to sync latest informatiion

Additional Information