Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040983Retail ModulesStoreServerpublic2019-05-30 17:512019-06-05 10:43
Reporterjarmendariz 
Assigned Tojarmendariz 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0040983: ServerStatusLogger cannot be instantiated using Weld in ant task
DescriptionServerStatusLogger uses Weld to be instantiated as a singleton. In some scenarios (e.g. ant tasks), Weld is not available and build fails because the object cannot be properly instantiated.
Steps To ReproduceRunning data validation task:

ant -f modules/org.openbravo.replication.symmetricds/build.xml validate.store.data

This returns with an error and the following stacktrace:

/opt/OpenbravoERP/modules/org.openbravo.retail.storeserver.synchronization/build.xml:96: The following error occurred while executing this line:
/opt/OpenbravoERP/modules/org.openbravo.replication.symmetricds/build.xml:80: java.lang.ExceptionInInitializerError
        at org.openbravo.replication.symmetricds.validation.SynchronizationStoreDataValidator.<init>(SynchronizationStoreDataValidator.java:111)
        at org.openbravo.replication.symmetricds.task.StoreDataValidatorTask.doExecute(StoreDataValidatorTask.java:34)
        at org.openbravo.dal.core.DalInitializingTask.execute(DalInitializingTask.java:120)
        at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:292)
        at sun.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:498)
        at org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106)
        at org.apache.tools.ant.Task.perform(Task.java:350)
        at org.apache.tools.ant.Target.execute(Target.java:448)
        at org.apache.tools.ant.Target.performTasks(Target.java:469)
        at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1399)
        at org.apache.tools.ant.helper.SingleCheckExecutor.executeTargets(SingleCheckExecutor.java:36)
        at org.apache.tools.ant.Project.executeTargets(Project.java:1260)
        at org.apache.tools.ant.taskdefs.Ant.execute(Ant.java:446)
        at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:292)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:498)
        at org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106)
        at org.apache.tools.ant.Task.perform(Task.java:350)
        at org.apache.tools.ant.Target.execute(Target.java:448)
        at org.apache.tools.ant.Target.performTasks(Target.java:469)
        at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1399)
        at org.apache.tools.ant.Project.executeTarget(Project.java:1370)
        at org.apache.tools.ant.helper.DefaultExecutor.executeTargets(DefaultExecutor.java:41)
        at org.apache.tools.ant.Project.executeTargets(Project.java:1260)
        at org.apache.tools.ant.Main.runBuild(Main.java:849)
        at org.apache.tools.ant.Main.startAnt(Main.java:228)
        at org.apache.tools.ant.launch.Launcher.run(Launcher.java:283)
        at org.apache.tools.ant.launch.Launcher.main(Launcher.java:101)
Caused by: java.lang.NullPointerException
        at org.openbravo.base.weld.WeldUtils.getStaticInstanceBeanManager(WeldUtils.java:53)
        at org.openbravo.base.weld.WeldUtils.getInstanceFromStaticBeanManager(WeldUtils.java:91)
        at org.openbravo.mobile.core.servercontroller.MobileServerController.<clinit>(MobileServerController.java:56)
        ... 32 more
Proposed SolutionInstantiate the ServerStatusLogger using an static method ServerStatusLogger.getInstance()
Additional Information
TagsNo tags attached.
Relationships
related to feature request 0040814 closed jarmendariz Improve the traceability of the store server state transitions 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-05-30 17:51jarmendarizNew Issue
2019-05-30 17:51jarmendarizAssigned To => jarmendariz
2019-05-30 17:51jarmendarizTriggers an Emergency Pack => No
2019-05-30 17:51jarmendarizStatusnew => scheduled
2019-05-30 17:55hgbotCheckin
2019-05-30 17:55hgbotNote Added: 0112281
2019-05-30 17:55hgbotStatusscheduled => resolved
2019-05-30 17:55hgbotResolutionopen => fixed
2019-05-30 17:55hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/9afde210ce2065f305dde347e875287eb13b4842 [^]
2019-05-30 17:56hgbotCheckin
2019-05-30 17:56hgbotNote Added: 0112282
2019-05-31 09:27jarmendarizRelationship addedrelated to 0040814
2019-05-31 10:29hgbotCheckin
2019-05-31 10:29hgbotNote Added: 0112295
2019-05-31 10:32AugustoMauchReview Assigned To => AugustoMauch
2019-05-31 10:32AugustoMauchNote Added: 0112296
2019-05-31 10:32AugustoMauchStatusresolved => closed
2019-06-05 10:43hgbotCheckin
2019-06-05 10:43hgbotNote Added: 0112412

Notes
(0112281)
hgbot   
2019-05-30 17:55   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 9afde210ce2065f305dde347e875287eb13b4842
Author: Javier Armendáriz <javier.armendariz <at> openbravo.com>
Date: Thu May 30 17:17:48 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/9afde210ce2065f305dde347e875287eb13b4842 [^]

Fixed issue 40983: ServerStatusLogger cannot be instantiated using Weld

As there are situations where the Logger cannot be instantiated using Weld,
a static getInstance method were created to instantiate the logger

---
M src/org/openbravo/mobile/core/servercontroller/MobileMainServerCheck.java
M src/org/openbravo/mobile/core/servercontroller/MobileServerController.java
M src/org/openbravo/mobile/core/servercontroller/log/ServerStatusLogger.java
---
(0112282)
hgbot   
2019-05-30 17:56   
Repository: erp/pmods/org.openbravo.replication.symmetricds
Changeset: 9ebe68c6901128ad518cbfaafc86d03a4f079c40
Author: Javier Armendáriz <javier.armendariz <at> openbravo.com>
Date: Thu May 30 17:19:45 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.replication.symmetricds/rev/9ebe68c6901128ad518cbfaafc86d03a4f079c40 [^]

Related to issue 40983: Using the new method to instance logger

---
M src/org/openbravo/replication/symmetricds/SetupSymmetricListener.java
---
(0112295)
hgbot   
2019-05-31 10:29   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: a345dc1cb251d6cc729faf0828e0e65aaa4a1f13
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Fri May 31 10:29:37 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/a345dc1cb251d6cc729faf0828e0e65aaa4a1f13 [^]

Related with issue 40983: Adds to missing transition logs

---
M src/org/openbravo/mobile/core/servercontroller/MobileServerController.java
---
(0112296)
AugustoMauch   
2019-05-31 10:32   
Code reviewed and verified
(0112412)
hgbot   
2019-06-05 10:43   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 8f69290a3afff7fa35bcf2a7a5b8d49c26ecd0c5
Author: Javier Armendáriz <javier.armendariz <at> openbravo.com>
Date: Wed Jun 05 10:42:19 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/8f69290a3afff7fa35bcf2a7a5b8d49c26ecd0c5 [^]

Related to issue 40983: Removed weld instantiation of MobileServerController

Same as the ServerStatusLogger, in some scenarios (ant tasks), weld is not
available so it cannot be used to intantiate objects

---
M src/org/openbravo/mobile/core/servercontroller/MobileServerController.java
---