Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040975Openbravo ERP07. Sales managementpublic2019-05-30 13:172019-06-05 20:54
Reporterfrancisco 
Assigned Tononofrancisco 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in Version3.0PR19Q3 
Merge Request Status
Review Assigned ToSandrahuguet
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket10171
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0040975: [Sales order]Not taking the right conversion rate
DescriptionMaking a payment in sales order with multi currency is not taking the right conversion rate until the "deposit to" section is refresh
Steps To ReproduceTested in PI organization F&B España SA
Go to financial Account and create a new financial account with currency USD
Add the payment method "Transferencia"

In Payment Method window enable "Receive Payments in Multiple Currencies" for "Transferencia"

Create a sale in Sales Order
Book the sale
Add payment and select the financial account for USD in "Deposit To". On the right side of the screen appears the conversion rates that apply for the day selected in Payment Date.
Now change the "Payment date" and choose one you know it has a different conversion rate.
You can see the "Conversion rate" doesn't change, to refresh the value and see the real values, you have to go to "Deposit To" and change the financial account, when you come back to the one you want to use again, it is when the conversion rate is refresh and changes to the right one
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-05-30 13:17franciscoNew Issue
2019-05-30 13:17franciscoAssigned To => Triage Finance
2019-05-30 13:17franciscoOBNetwork customer => OBPS
2019-05-30 13:17franciscoModules => Core
2019-05-30 13:17franciscoSupport ticket => 10171
2019-05-30 13:17franciscoResolution time => 1560981600
2019-05-30 13:17franciscoTriggers an Emergency Pack => No
2019-05-30 16:48SandrahuguetAssigned ToTriage Finance => nonofrancisco
2019-06-04 17:27nonofranciscoStatusnew => scheduled
2019-06-04 17:27nonofranciscoNote Added: 0112387
2019-06-05 09:46hgbotCheckin
2019-06-05 09:46hgbotNote Added: 0112405
2019-06-05 09:46hgbotStatusscheduled => resolved
2019-06-05 09:46hgbotResolutionopen => fixed
2019-06-05 09:46hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/b03c10e80c924298754b421148ee05f3c846808d [^]
2019-06-05 09:46SandrahuguetReview Assigned To => Sandrahuguet
2019-06-05 09:46SandrahuguetNote Added: 0112406
2019-06-05 09:46SandrahuguetStatusresolved => closed
2019-06-05 09:46SandrahuguetFixed in Version => 3.0PR19Q3
2019-06-05 20:54hudsonbotCheckin
2019-06-05 20:54hudsonbotNote Added: 0112443

Notes
(0112387)
nonofrancisco   
2019-06-04 17:27   
Test Plan

As Openbravo/F&B International Group Admin
Go to financial Account and create a new financial account with currency USD
Add the payment method "Transferencia"

In Payment Method window enable "Receive Payments in Multiple Currencies" for "Transferencia"

Go to Sales Order window
Create a new Sales Order
Book the document
Click on Add Payment
Select the financial account for USD in "Deposit To".
Verify in the right side of the screen appears the conversion rates that apply for selected date in Payment Date.
Now set Payment Date to "04-06-2017"
You can see the "Conversion rate" is updated to the value "1.08"
Now set Payment Date to "01-01-2020"
You can see the "Conversion rate" is updated to the value "1.13"
(0112405)
hgbot   
2019-06-05 09:46   
Repository: erp/devel/pi
Changeset: b03c10e80c924298754b421148ee05f3c846808d
Author: Nono Carballo <nonofce <at> gmail.com>
Date: Mon Jun 03 16:53:26 2019 -0400
URL: http://code.openbravo.com/erp/devel/pi/rev/b03c10e80c924298754b421148ee05f3c846808d [^]

Fixes issue 40975: Updates conversion rates on payment date changes

A new function was defined for onChange event in Payment Date parameter, to
update conversion rates when payment date changes.

---
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/OBUIAPP_PARAMETER.xml
M modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-addPayment.js
---
(0112406)
Sandrahuguet   
2019-06-05 09:46   
code review + testing OK
(0112443)
hudsonbot   
2019-06-05 20:54   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/a8037910e3ad [^]
Maturity status: Test