Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040934Retail ModulesSessionspublic2019-05-22 10:402019-06-27 16:53
Reporterngarcia 
Assigned Torqueralta 
PriorityurgentSeveritymajorReproducibilityrandom
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR19Q3 
Merge Request Status
Review Assigned Toguilleaer
OBNetwork customerGold
Support ticket10017
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0040934: [Sessions] Completing multiple open till simultaneously can cause NumberFormatExceptions
DescriptionWith the Sessions module installed, completing multiple open tills at the same time (which can happen in a production environment when all terminals open the tills at the same time) can lead to NumberFormatException thrown in the server, leaving some of the Open Tills in the Errors While Importing POS Data window, with the following error:

ava.lang.NumberFormatException: For input string: ""
    at java.lang.NumberFormatException.forInputString(NumberFormatException.java:65)
    at java.lang.Long.parseLong(Long.java:601)
    at java.lang.Long.parseLong(Long.java:631)
    at java.text.DigitList.getLong(DigitList.java:195)
    at java.text.DecimalFormat.parse(DecimalFormat.java:2051)
    at java.text.SimpleDateFormat.subParse(SimpleDateFormat.java:1869)
    at java.text.SimpleDateFormat.parse(SimpleDateFormat.java:1514)
    at java.text.DateFormat.parse(DateFormat.java:364)
    at org.openbravo.retail.sessions.OpenSessionPOS.saveRecord(OpenSessionPOS.java:66)
Steps To Reproduce*
Proposed SolutionCheck if the same solution of 40474 should be applied over the following two clases:

OpenSessionPOS
SetBusinessDate
Additional Information
TagsNo tags attached.
Relationships
related to defect 0040474 closed ranjith_qualiantech_com [Sessions] Completing multiple cashups simultaneously can cause NumberFormatExceptions 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-05-22 10:40ngarciaNew Issue
2019-05-22 10:40ngarciaAssigned To => Retail
2019-05-22 10:40ngarciaOBNetwork customer => Gold
2019-05-22 10:40ngarciaSupport ticket => 10017
2019-05-22 10:40ngarciaResolution time => 1560290400
2019-05-22 10:40ngarciaTriggers an Emergency Pack => No
2019-05-22 10:40ngarciaIssue generated from0040474
2019-05-22 10:40ngarciaRelationship addedrelated to 0040474
2019-05-22 10:40ngarciaIssue Monitored: networkb
2019-05-28 04:59rqueraltaAssigned ToRetail => rqueralta
2019-05-28 04:59rqueraltaStatusnew => scheduled
2019-06-13 00:46hgbotCheckin
2019-06-13 00:46hgbotNote Added: 0112763
2019-06-13 00:46hgbotStatusscheduled => resolved
2019-06-13 00:46hgbotResolutionopen => fixed
2019-06-13 00:46hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.sessions/rev/fd1e9fcf97a78d890b0ee54fa98528014eb5e8ff [^]
2019-06-27 16:53guilleaerReview Assigned To => guilleaer
2019-06-27 16:53guilleaerStatusresolved => closed
2019-06-27 16:53guilleaerFixed in Version => RR19Q3

Notes
(0112763)
hgbot   
2019-06-13 00:46   
Repository: erp/pmods/org.openbravo.retail.sessions
Changeset: fd1e9fcf97a78d890b0ee54fa98528014eb5e8ff
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Wed Jun 12 18:36:49 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.sessions/rev/fd1e9fcf97a78d890b0ee54fa98528014eb5e8ff [^]

Fixed issue 40934: [Sessions] Completing multiple open till simultaneously can
cause NumberFormatExceptions

- If these two classes are called at the same time from multiple request, error
 occurs while parsing business date due to static identifier for DateFormat.

---
M src/org/openbravo/retail/sessions/OpenSessionPOS.java
M src/org/openbravo/retail/sessions/SetBusinessDate.java
---