Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0040927Openbravo ERPA. Platformpublic2019-05-21 16:012019-05-27 13:54
alostale 
alostale 
normalmajorhave not tried
closedfixed 
5
 
3.0PR19Q3 
caristu
Core
Coding ( Testing )
2019-05-21
pi
http://code.openbravo.com/erp/devel/pi/rev/2357e260529dfd5d7ad9da6b06d68fcb1c31e229 [^]
No
0040927: ModelProvider does not flag all entities with images
ModelProvider does not contain correct information about entities with images and files in case image FK columns are marked not to generate properties in parent.
1. Mark M_Product_Category.AD_Image_ID not to generate one-to-many property in parent entity:

   update ad_column set is_child_property_in_parent = 'N' where ad_column_id = 'F8F8B51087D44986A4864F6047FC44D4';

2. Run ImageTest unit test
  -> It fails because ModelProvider does not include ProductCategory entity as part of the entities with images
No tags attached.
related to defect 0040758 closed caristu In discount & promotions, with Combo discount type, the organization can not be modified 
caused by feature request 0040290 closed alostale do not generate one-to-many property in parent entity for all FK properties 
blocks design defect 0040906 closed alostale platform: review FK columns to set which ones shouldn't generate one-to-many property in parent entity 
Issue History
2019-05-21 16:01alostaleNew Issue
2019-05-21 16:01alostaleAssigned To => platform
2019-05-21 16:01alostaleModules => Core
2019-05-21 16:01alostaleTriggers an Emergency Pack => No
2019-05-21 16:01alostaleAssigned Toplatform => alostale
2019-05-21 16:02alostaleRegression level => Coding ( Testing )
2019-05-21 16:02alostaleRegression date => 2019-05-21
2019-05-21 16:02alostaleRegression introduced in release => pi
2019-05-21 16:02alostaleRegression introduced by commit => http://code.openbravo.com/erp/devel/pi/rev/2357e260529dfd5d7ad9da6b06d68fcb1c31e229 [^]
2019-05-21 16:02alostaleRelationship addedcaused by 0040290
2019-05-21 16:02alostaleRelationship addedblocks 0040906
2019-05-21 16:03alostaleRelationship addedrelated to 0040758
2019-05-21 16:03alostaleReview Assigned To => caristu
2019-05-21 16:15hgbotCheckin
2019-05-21 16:15hgbotNote Added: 0112056
2019-05-21 16:15hgbotStatusnew => resolved
2019-05-21 16:15hgbotResolutionopen => fixed
2019-05-21 16:15hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/073f41cdb73532a53845bea1a68e70511964108d [^]
2019-05-24 08:17caristuNote Added: 0112106
2019-05-24 08:17caristuStatusresolved => closed
2019-05-24 08:17caristuFixed in Version => 3.0PR19Q3
2019-05-27 13:54hudsonbotCheckin
2019-05-27 13:54hudsonbotNote Added: 0112167

Notes
(0112056)
hgbot   
2019-05-21 16:15   
Repository: erp/devel/pi
Changeset: 073f41cdb73532a53845bea1a68e70511964108d
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Tue May 21 15:56:38 2019 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/073f41cdb73532a53845bea1a68e70511964108d [^]

fixed bug 40927: ModelProvider does not flag all entities with images or files

  They were incorrectly marked only in case their one-to-many property in parent
  entity was marked to be genereted. They need to be marked in any case.

---
M src/org/openbravo/base/model/ModelProvider.java
---
(0112106)
caristu   
2019-05-24 08:17   
Reviewed
(0112167)
hudsonbot   
2019-05-27 13:54   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/bdad8ace6f89 [^]
Maturity status: Test