Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040915Openbravo ERPZ. Otherspublic2019-05-20 12:582019-05-20 13:03
Reporteralostale 
Assigned ToRetail 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusnewResolutionopen 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0040915: retail: review FK columns to set which ones shouldn't generate one-to-many property in parent entity
DescriptionAfter 0040290 implemented the capacity of defining which foreign key database column should generate a one-to-many property in their referenced parent entity, all existing columns were set to continue generating them in order to preserve backward compatibility.

All these columns should be now reviewed to decide, case by case, if those parent properties should be generated.
Steps To Reproduce-
Proposed SolutionThe following spreadsheet [1], lists all these columns for pi + retail pack. Splitting each of them by the owner team.

Column H (Keep) flags whether it should be kept (Y) or can be removed (N). When a column is marked to be removed, SQL column (K) generates the query to be run; grep column (J) contains a grep expression (check comment in header on how to use it) to look for HQL occurrences of the removed property in case there are occurrences (check for false positives), either the column cannot be removed or code needs to be fixed.

After executing the SQL, run ant.generate entities and rebuild the system to check for users of the deleted methods.

---
[1] https://docs.google.com/spreadsheets/d/1hdwjGM4_3TJ-9Bcylh_w_MM54_1T_cUlicaPfEyH1MQ/edit#gid=0 [^]
Additional Information
TagsPerformance
Relationships
related to design defect 0040906 closed alostale platform: review FK columns to set which ones shouldn't generate one-to-many property in parent entity 
depends on feature request 0040290 closed alostale do not generate one-to-many property in parent entity for all FK properties 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-05-20 12:58alostaleNew Issue
2019-05-20 12:58alostaleAssigned To => Retail
2019-05-20 12:58alostaleModules => Core
2019-05-20 12:58alostaleTriggers an Emergency Pack => No
2019-05-20 12:58alostaleIssue generated from0040906
2019-05-20 12:58alostaleRelationship addedrelated to 0040906
2019-05-20 12:58alostaleRelationship addeddepends on 0040290
2019-05-20 13:03alostaleTag Attached: Performance

There are no notes attached to this issue.