Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040912Retail ModulesWeb POSpublic2019-05-20 12:052019-06-24 17:57
Reporteraaroncalero 
Assigned Toaaroncalero 
PrioritynormalSeveritymajorReproducibilityN/A
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR19Q3 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0040912: Improve Service Price Rules to allow configuration of specific Price Rules for Products/Categories
DescriptionImprove Service Price Rules to allow configuration of specific Price Rules for Products/Categories.

Currently it is only possible to configure a service price rule for all relationships between a service and the related products. This development will enable configuring service price rules (each with their own dates and tranche limits) for specific relationships between the service and its related products and product categories
Steps To Reproduce-
Proposed Solution-
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-05-20 12:05aaroncaleroNew Issue
2019-05-20 12:05aaroncaleroAssigned To => aaroncalero
2019-05-20 12:05aaroncaleroOBNetwork customer => No
2019-05-20 12:05aaroncaleroTriggers an Emergency Pack => No
2019-05-20 12:13hgbotCheckin
2019-05-20 12:13hgbotNote Added: 0111917
2019-05-20 12:13hgbotStatusnew => resolved
2019-05-20 12:13hgbotResolutionopen => fixed
2019-05-20 12:13hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f608c35363e0735a663c50eacd04220c0378033e [^]
2019-05-20 12:15hgbotCheckin
2019-05-20 12:15hgbotNote Added: 0111918
2019-05-20 12:15hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f608c35363e0735a663c50eacd04220c0378033e [^] => http://code.openbravo.com/erp/devel/pi/rev/9e1c089e74fafb4a6dccc560939d8f7377bce493 [^]
2019-05-20 12:57hgbotCheckin
2019-05-20 12:57hgbotNote Added: 0111922
2019-05-20 13:47hgbotCheckin
2019-05-20 13:47hgbotNote Added: 0111923
2019-05-21 15:17hudsonbotCheckin
2019-05-21 15:17hudsonbotNote Added: 0112049
2019-05-21 15:17hudsonbotCheckin
2019-05-21 15:17hudsonbotNote Added: 0112053
2019-06-03 12:13marvintmReview Assigned To => marvintm
2019-06-03 12:13marvintmStatusresolved => closed
2019-06-03 12:13marvintmFixed in Version => RR19Q3
2019-06-24 17:55hgbotCheckin
2019-06-24 17:55hgbotNote Added: 0112985
2019-06-24 17:56hgbotCheckin
2019-06-24 17:56hgbotNote Added: 0112988
2019-06-24 17:57hgbotCheckin
2019-06-24 17:57hgbotNote Added: 0112989

Notes
(0111917)
hgbot   
2019-05-20 12:13   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: f608c35363e0735a663c50eacd04220c0378033e
Author: Aaron Calero <aaron.calero <at> openbravo.com>
Date: Mon May 20 12:07:53 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f608c35363e0735a663c50eacd04220c0378033e [^]

Fixed issue 40912: Improve Service Price Rules to allow configuration of specific SPRs for Products/Categories

---
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/OBMOBC_PROCESS_DEFINITION.xml
M src/org/openbravo/retail/posterminal/AssociateOrderLinesProperties.java
M src/org/openbravo/retail/posterminal/PaidReceiptRelatedLinesProperties.java
M src/org/openbravo/retail/posterminal/ServicePriceRuleVersionHQLCriteria.java
M src/org/openbravo/retail/posterminal/ServicesHQLCriteria.java
M src/org/openbravo/retail/posterminal/ServicesMultiselectionHQLCriteria.java
M src/org/openbravo/retail/posterminal/master/ServicePriceRuleVersion.java
M src/org/openbravo/retail/posterminal/master/ServicePriceRuleVersionProperties.java
M src/org/openbravo/retail/posterminal/process/HasServices.java
M web/org.openbravo.retail.posterminal/js/components/modalassociatetickets.js
M web/org.openbravo.retail.posterminal/js/components/order.js
M web/org.openbravo.retail.posterminal/js/components/renderorderline.js
M web/org.openbravo.retail.posterminal/js/components/servicesfilter.js
M web/org.openbravo.retail.posterminal/js/model/order.js
M web/org.openbravo.retail.posterminal/js/model/orderassociationsfilter.js
M web/org.openbravo.retail.posterminal/js/model/servicepriceruleversion.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-left.js
M web/org.openbravo.retail.posterminal/js/utils/ob-utilitiesuipos.js
A src/org/openbravo/retail/posterminal/ServicePriceRuleVersionHQLRangeCriteria.java
---
(0111918)
hgbot   
2019-05-20 12:15   
Repository: erp/devel/pi
Changeset: 9e1c089e74fafb4a6dccc560939d8f7377bce493
Author: Aaron Calero <aaron.calero <at> openbravo.com>
Date: Mon May 20 12:06:18 2019 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/9e1c089e74fafb4a6dccc560939d8f7377bce493 [^]

Fixed issue 40912: Improve Service Price Rules to allow configuration of specific SPRs for Products/Categories

---
M src-db/database/model/tables/M_SERVICEPRICERULE_VERSION.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/AD_REFERENCE.xml
M src-db/database/sourcedata/AD_REF_TABLE.xml
M src-db/database/sourcedata/AD_TAB.xml
M src/org/openbravo/common/actionhandler/ServiceRelatedLinePriceActionHandler.java
M src/org/openbravo/materialmgmt/ServicePriceUtils.java
M web/js/productServices.js
A src/org/openbravo/event/ProductPriceRuleVersionEventHandler.java
---
(0111922)
hgbot   
2019-05-20 12:57   
Repository: erp/devel/pi
Changeset: 9ee5dc3a2747aba852cc25fe456aff3d88751081
Author: Aaron Calero <aaron.calero <at> openbravo.com>
Date: Mon May 20 12:53:35 2019 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/9ee5dc3a2747aba852cc25fe456aff3d88751081 [^]

Related to issue 40912: Fixed dbcons

---
M src-db/database/sourcedata/AD_COLUMN.xml
---
(0111923)
hgbot   
2019-05-20 13:47   
Repository: tools/automation/pi-mobile
Changeset: ba0c4b9982ebf9c34b4b0274a1b847431b6bfd67
Author: Aaron Calero <aaron.calero <at> openbravo.com>
Date: Thu Jan 10 10:31:11 2019 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/ba0c4b9982ebf9c34b4b0274a1b847431b6bfd67 [^]

Related to issue 40912: Changes in RangesUniqueQuantityTest due to functional changes

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/services/serviceswithpricerules/RangesUniqueQuantityTest.java
---
(0112049)
hudsonbot   
2019-05-21 15:17   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9b8f37d9d85e [^]
Maturity status: Test
(0112053)
hudsonbot   
2019-05-21 15:17   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9b8f37d9d85e [^]
Maturity status: Test
(0112985)
hgbot   
2019-06-24 17:55   
Repository: tools/automation/pi-mobile
Changeset: e965446ab78ced3036f0d4ae864351f9dda55178
Author: Aaron Calero <aaron.calero <at> openbravo.com>
Date: Tue Jun 11 11:12:52 2019 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/e965446ab78ced3036f0d4ae864351f9dda55178 [^]

Related to issue 40912, related to issue 40913: Added automated tests

---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/TestIdExtModules.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/terminals/DeliveryModesHelper.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/TestIdPack.java
A src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/deliverymodes/deliveryrates/DeliveryRates_PayInDelivery_SingleDeliveryService.java
A src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/deliverymodes/deliveryrates/DeliveryRates_PayInDelivery_TwoDeliveryServices.java
A src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/deliverymodes/deliveryrates/DeliveryRates_PayInTicket_SingleDeliveryService.java
A src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/deliverymodes/deliveryrates/DeliveryRates_PayInTicket_TwoDeliveryServices.java
A src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/deliverymodes/deliveryrates/DeliveryRates_RemoveHomeDelivery.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/services/pricerulesenhancement/SPRE_PriceRuleSpecificForACategory.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/services/pricerulesenhancement/SPRE_PriceRuleSpecificForACategoryAndAProduct.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/services/pricerulesenhancement/SPRE_PriceRuleSpecificForAProduct.java
---
(0112988)
hgbot   
2019-06-24 17:56   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: dee3c9a94476aaa63b0dc9ed23f719ae23deb72b
Author: Aaron Calero <aaron.calero <at> openbravo.com>
Date: Tue Jun 11 11:31:06 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/dee3c9a94476aaa63b0dc9ed23f719ae23deb72b [^]

Related to issue 40912: Small query adjustments

---
M src/org/openbravo/retail/posterminal/ServicePriceRuleVersionHQLCriteria.java
M web/org.openbravo.retail.posterminal/js/components/servicesfilter.js
---
(0112989)
hgbot   
2019-06-24 17:57   
Repository: erp/pmods/org.openbravo.retail.sampledata
Changeset: 722f2a67a753b40cf252c073ea48009ac87f4d31
Author: Aaron Calero <aaron.calero <at> openbravo.com>
Date: Mon Jun 10 13:10:36 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.sampledata/rev/722f2a67a753b40cf252c073ea48009ac87f4d31 [^]

Related to issue 40912: Added sampledata

---
M referencedata/sampledata/The_White_Valley_Group/M_PRODUCT.xml
M referencedata/sampledata/The_White_Valley_Group/M_PRODUCTPRICE.xml
M referencedata/sampledata/The_White_Valley_Group/M_PRODUCT_ACCT.xml
M referencedata/sampledata/The_White_Valley_Group/M_PRODUCT_CATEGORY_SERVICE.xml
M referencedata/sampledata/The_White_Valley_Group/M_PRODUCT_SERVICE.xml
M referencedata/sampledata/The_White_Valley_Group/M_SERVICEPRICERULE.xml
M referencedata/sampledata/The_White_Valley_Group/M_SERVICEPRICERULE_VERSION.xml
M referencedata/sampledata/The_White_Valley_Group/OBRETCO_PROL_PRODUCT.xml
---