Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040894Retail ModulesStoreServerpublic2019-05-17 07:352019-05-31 09:00
Reporterguillermogil 
Assigned Tomtaal 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0040894: OBMOBC_MsgCentralServerNotAvailable is shown instead of the message
DescriptionOBMOBC_MsgCentralServerNotAvailable is shown instead of the message.
OBMOBCUtils.createSimpleErrorJson("OBMOBC_MsgCentralServerNotAvailable"); Does not get the message based on that searchkey.
Found in:
./org.openbravo.retail.storeserver.synchronization/src/org/openbravo/retail/storeserver/synchronization/RetailSynchronizationRequestHandler.java
./org.openbravo.mobile.core/src/org/openbravo/mobile/core/servercontroller/MultiServerJSONProcess.java
Steps To ReproduceIn a multiserver environment:
1. Log into a terminal for sellers with role Vendeur.
2. Add a customer.
3. Stop the central server
4. Open the Customer Card and start a new subscription.
---Message: OBMOBC_MsgCentralServerNotAvailable
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Filespng 5098.png (11,618) 2019-05-17 07:35
https://issues.openbravo.com/file_download.php?file_id=12958&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2019-05-17 07:35guillermogilNew Issue
2019-05-17 07:35guillermogilAssigned To => StoreServer
2019-05-17 07:35guillermogilFile Added: 5098.png
2019-05-17 07:35guillermogilTriggers an Emergency Pack => No
2019-05-29 17:38AugustoMauchNote Added: 0112239
2019-05-29 17:38AugustoMauchStatusnew => feedback
2019-05-30 09:33mtaalNote Added: 0112257
2019-05-30 11:21mtaalNote Added: 0112264
2019-05-30 11:32mtaalAssigned ToStoreServer => mtaal
2019-05-30 11:32mtaalReview Assigned To => AugustoMauch
2019-05-30 11:32hgbotCheckin
2019-05-30 11:32hgbotNote Added: 0112265
2019-05-30 11:32hgbotStatusfeedback => resolved
2019-05-30 11:32hgbotResolutionopen => fixed
2019-05-30 11:32hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/c6015c2882012fd884d23c8e3dc800db22c7490a [^]
2019-05-30 12:42hgbotCheckin
2019-05-30 12:42hgbotNote Added: 0112266
2019-05-31 08:59AugustoMauchNote Added: 0112288
2019-05-31 08:59AugustoMauchStatusresolved => closed
2019-05-31 09:00AugustoMauchSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=18847#r18847

Notes
(0112239)
AugustoMauch   
2019-05-29 17:38   
I could not reproduce the issue. When I stopped the central server and looked for a product, the proper message was shown.
(0112257)
mtaal   
2019-05-30 09:33   
Hi,
There are some steps in another issue description for reproducing it. My guess is that in that location the error message is handled differently.

"Steps to reproduce:

1. Log into a terminal for sellers with role Vendeur.
2. Add a customer.
3. Open the Customer Card and start a new subscription.
---Message: OBMOBC_MsgCentralServerNotAvailable

https://drive.google.com/open?id=1djAvl15QPxdLqCyhqLFi_7SzqWQrqh64" [^]
(0112264)
mtaal   
2019-05-30 11:21   
The solution seems to be to translate the message already here:
https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/tip/src/org/openbravo/mobile/core/servercontroller/MultiServerJSONProcess.java#l156 [^]
(0112265)
hgbot   
2019-05-30 11:32   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: c6015c2882012fd884d23c8e3dc800db22c7490a
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Thu May 30 11:32:47 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/c6015c2882012fd884d23c8e3dc800db22c7490a [^]

Fixes issue 40894: OBMOBC_MsgCentralServerNotAvailable is shown instead of the message
Translate the message on the server already

---
M src/org/openbravo/mobile/core/servercontroller/MultiServerJSONProcess.java
---
(0112266)
hgbot   
2019-05-30 12:42   
Repository: erp/pmods/org.openbravo.retail.storeserver.synchronization
Changeset: 6bf2248d610208a7f2a39bdb37c14f5f9247f4bd
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Thu May 30 12:42:14 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/6bf2248d610208a7f2a39bdb37c14f5f9247f4bd [^]

Related to issue 40894: OBMOBC_MsgCentralServerNotAvailable is shown instead of the message
Translate the message before returning it to webpos

---
M src/org/openbravo/retail/storeserver/synchronization/RetailSynchronizationRequestHandler.java
---
(0112288)
AugustoMauch   
2019-05-31 08:59   
Code reviewed and verified