Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040881Retail ModulesDiscounts by Totalpublic2019-05-15 10:142019-05-16 19:11
ReporterLeyre 
Assigned Toranjith_qualiantech_com 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR19Q3 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0040881: Error in console browser in a POS Terminal SCO, due to type "byTotal" discounts
DescriptionError in console browser in a POS Terminal SCO, due to type "byTotal" discounts
Steps To ReproduceBACKEND:

1. Define a discount type "User Defined Amount"
2. Define a discount type "Variable Discount per Total Amount"

WEB POS:
1. Add three units of a product, for example: Avalanche transceiver. This product must be marked as "non grouped"
2. Add the first defined discount -> User Defined Amount
3. Add the second defined discount -> Variable Discount per Total Amount
4. Go to SCO mode and verify that there are errors in the console.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Filespng byTotalDiscount.png (359,655) 2019-05-15 10:14
https://issues.openbravo.com/file_download.php?file_id=12948&type=bug
Issue History
Date ModifiedUsernameFieldChange
2019-05-15 10:14LeyreNew Issue
2019-05-15 10:14LeyreAssigned To => Retail
2019-05-15 10:14LeyreFile Added: byTotalDiscount.png
2019-05-15 10:14LeyreResolution time => 1558303200
2019-05-15 10:14LeyreTriggers an Emergency Pack => No
2019-05-15 10:15LeyreRelationship addedcaused by 0040666
2019-05-15 11:06LeyreRelationship deletedcaused by 0040666
2019-05-15 11:07LeyreResolution time1558303200 => 1559685600
2019-05-15 11:07LeyrePriorityimmediate => urgent
2019-05-15 13:59ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2019-05-15 13:59ranjith_qualiantech_comStatusnew => scheduled
2019-05-16 15:47hgbotCheckin
2019-05-16 15:47hgbotNote Added: 0111721
2019-05-16 15:48hgbotCheckin
2019-05-16 15:48hgbotNote Added: 0111722
2019-05-16 15:48hgbotStatusscheduled => resolved
2019-05-16 15:48hgbotResolutionopen => fixed
2019-05-16 15:48hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/51efe219a70508c64e0d4674afc61e605a9df04c [^]
2019-05-16 19:11marvintmReview Assigned To => marvintm
2019-05-16 19:11marvintmStatusresolved => closed
2019-05-16 19:11marvintmFixed in Version => RR19Q3

Notes
(0111721)
hgbot   
2019-05-16 15:47   
Repository: erp/pmods/org.openbravo.retail.discounts.bytotal
Changeset: 970860a0a15ee68c052733976a17c8fd366ea9b0
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu May 16 19:17:35 2019 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.bytotal/rev/970860a0a15ee68c052733976a17c8fd366ea9b0 [^]

Related to issue 40881 : New Backbone Collection has been created for receipt orderManualPromotions

---
M web/org.openbravo.retail.discounts.bytotal/js/preApplyDiscountsHook.js
---
(0111722)
hgbot   
2019-05-16 15:48   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 51efe219a70508c64e0d4674afc61e605a9df04c
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu May 16 19:17:46 2019 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/51efe219a70508c64e0d4674afc61e605a9df04c [^]

Fixed issue 40881 : Receipt orderManualPromotions should be initialized with Custom Backbone Collection and Model

* When receipt is saved with orderManualPromotions (By Total discounts),
  if we do refresh or change window from pointofsale to SCO, discountRule object present in orderManualPromotions is not converted to model.
  So when initializing the order, discountRule object from orderManualPromotions should be updated discount model

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---