Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040876Retail ModulesCash Managementpublic2019-05-14 18:062019-12-06 20:34
Reportersalvador_campanella 
Assigned Torqueralta 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in VersionRR19Q3 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0040876: Multiple payment methods are shown when their have the same financial account
DescriptionMultiple payment methods are shown when their have the same financial account
Steps To Reproduce[webPOS]
1. Login in terminal VBS-1,
2. Make a Sales order paying with cash
3. Make a Cash up

[Back Office]
4. Go to Channel-Touch point a select terminal VBS-1
5. Deactivate the payment method cash
6. Create a new payment method called cash2 with the same financial account of the cash payment method

[WebPOS]
7. Login in terminal VBS-1,
8. Open receipt made in the step 2
9. click in the amount button



Error: Both payments methods [ cash & cash2 ] are shown
Proposed SolutionWe need to join with the payment method through the financial account because that's the only link that we have in the payment itself to the terminal configuration, and therefore, in this configuration due to the join the payment method information will get duplicated.

In this case, we should order by "active" (to get active payment methods first) and then just limit the query so that we get the first record only.
Additional Information
TagsNo tags attached.
Relationships
related to defect 0049833RR20Q3.4 closed ranjith_qualiantech_com Reprinted simplified invoices with wrong payment names 
blocks defect 0042385 closed rqueralta Performance improvement in PaidReceipts query 
Attached Filespng issue.png (119,977) 2019-05-14 18:06
https://issues.openbravo.com/file_download.php?file_id=12947&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2019-05-14 18:06salvador_campanellaNew Issue
2019-05-14 18:06salvador_campanellaAssigned To => Retail
2019-05-14 18:06salvador_campanellaFile Added: issue.png
2019-05-14 18:06salvador_campanellaResolution time => 1559599200
2019-05-14 18:06salvador_campanellaTriggers an Emergency Pack => No
2019-05-15 10:17salvador_campanellaReproducibilityhave not tried => always
2019-05-16 18:41marvintmProposed Solution updated
2019-05-20 19:00rqueraltaAssigned ToRetail => rqueralta
2019-05-20 19:00rqueraltaStatusnew => scheduled
2019-05-23 13:53hgbotCheckin
2019-05-23 13:53hgbotNote Added: 0112093
2019-05-23 13:53hgbotStatusscheduled => resolved
2019-05-23 13:53hgbotResolutionopen => fixed
2019-05-23 13:53hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/54be9e67e61f0ae34a2a0058b27dc10b75d83c95 [^]
2019-05-23 17:01marvintmNote Added: 0112098
2019-05-23 17:01marvintmStatusresolved => new
2019-05-23 17:01marvintmResolutionfixed => open
2019-05-24 04:17hgbotCheckin
2019-05-24 04:17hgbotNote Added: 0112105
2019-05-24 04:17hgbotStatusnew => resolved
2019-05-24 04:17hgbotResolutionopen => fixed
2019-05-24 04:17hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/54be9e67e61f0ae34a2a0058b27dc10b75d83c95 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/207bbad2273539d0d826db0f4710e1729821c4bc [^]
2019-05-24 13:16marvintmReview Assigned To => marvintm
2019-05-24 13:16marvintmStatusresolved => closed
2019-05-24 13:16marvintmFixed in Version => RR19Q3
2019-06-14 16:17hgbotCheckin
2019-06-14 16:17hgbotNote Added: 0112791
2019-06-14 17:02hgbotCheckin
2019-06-14 17:02hgbotNote Added: 0112794
2019-10-09 13:39hgbotCheckin
2019-10-09 13:39hgbotNote Added: 0114989
2019-10-09 14:20hgbotCheckin
2019-10-09 14:20hgbotNote Added: 0114990
2019-11-26 10:02guilleaerRelationship addedblocks 0042385
2019-12-06 20:34hgbotCheckin
2019-12-06 20:34hgbotNote Added: 0116131
2022-07-19 08:54ranjith_qualiantech_comRelationship addedrelated to 0049833

Notes
(0112093)
hgbot   
2019-05-23 13:53   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 54be9e67e61f0ae34a2a0058b27dc10b75d83c95
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Tue May 21 15:03:52 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/54be9e67e61f0ae34a2a0058b27dc10b75d83c95 [^]

Fixed issue 40876: Multiple payment methods are shown when their have the same
financial account

- Filtered by active payment methods

---
M src/org/openbravo/retail/posterminal/PaidReceipts.java
---
(0112098)
marvintm   
2019-05-23 17:01   
It's not enough to just filter inactive payment methods, because then it would not be possible to load a ticket with an inactive payment method unless it was replaced by another one.

Instead, we should order by active in the query, so that if there are both an inactive and active payment method for the same financial account, then the active one gets prioritised when building the final payment object
(0112105)
hgbot   
2019-05-24 04:17   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 207bbad2273539d0d826db0f4710e1729821c4bc
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Thu May 23 18:24:44 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/207bbad2273539d0d826db0f4710e1729821c4bc [^]

Fixed issue 40876: Multiple payment methods are shown when their have the same
financial account

-Ordered payment methods by active and reduced payment type list to get just one
payment by financial account

---
M src/org/openbravo/retail/posterminal/PaidReceipts.java
---
(0112791)
hgbot   
2019-06-14 16:17   
Repository: erp/pmods/org.openbravo.retail.sampledata
Changeset: 3303a1ccb780edbca7822188569e06512ace776b
Author: Alejandro <alekosmp86 <at> gmail.com>
Date: Mon Jun 10 16:19:11 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.sampledata/rev/3303a1ccb780edbca7822188569e06512ace776b [^]

Related to issue 40876: added sampledata for testing purposes

---
M referencedata/sampledata/The_White_Valley_Group/OBPOS_APP_PAYMENT.xml
---
(0112794)
hgbot   
2019-06-14 17:02   
Repository: tools/automation/pi-mobile
Changeset: cff29ceaa2a85e3d50c467b91d69d933f00a7e20
Author: Alejandro <alekosmp86 <at> gmail.com>
Date: Mon Jun 10 16:49:27 2019 -0400
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/cff29ceaa2a85e3d50c467b91d69d933f00a7e20 [^]

Related to issue 40876: added automated test

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/TestIdPack.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cashmanagement/I40876_VerifyOnlyOnePayMethodShownIfSharesFinAcct.java
---
(0114989)
hgbot   
2019-10-09 13:39   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 0563fa0279f35e9e91b2815f445445efe27b02a1
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Wed Oct 09 13:38:33 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0563fa0279f35e9e91b2815f445445efe27b02a1 [^]

Related to issue 40876: Multiple payment methods are shown when their have the same financial account
* Terminal payment methods must be filtered by active field in Cashup process

---
M src/org/openbravo/retail/posterminal/master/Cashup.java
---
(0114990)
hgbot   
2019-10-09 14:20   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 471172acc58c5778749382047023cace8daf0187
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Wed Oct 09 14:20:14 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/471172acc58c5778749382047023cace8daf0187 [^]

Related to issue 40876: Multiple payment methods are shown when their have the same financial account
* Fix copyright notice in Cashup.java

---
M src/org/openbravo/retail/posterminal/master/Cashup.java
---
(0116131)
hgbot   
2019-12-06 20:34   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 386b15cdffb4e30cb73c0182275eff8cabe25236
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Thu Dec 05 16:43:31 2019 -0500
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/386b15cdffb4e30cb73c0182275eff8cabe25236 [^]

Related to issue 42385: Performance improvement in PaidReceipts query

- Readapted issue 40876 according to the solution of issue 42385 and added a new
index to improve the query

---
M src-db/database/model/tables/OBPOS_APP_PAYMENT.xml
M src/org/openbravo/retail/posterminal/Invoices.java
M src/org/openbravo/retail/posterminal/PaidReceipts.java
---