Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040875Retail ModulesStoreServerpublic2019-05-14 14:432019-05-20 11:50
ReporterAugustoMauch 
Assigned ToAugustoMauch 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tomtaal
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0040875: When sync fails because of version difference between central and store server, synchronization should not be stopped
DescriptionWhen there is a synchronization error from the central server to a store server, the synchronization from the central server to that store server is stopped automatically, to prevent sending the same invalid date over and over again.

The problem is that sometimes it makes sense to keep sending the data, because the synchronization error will be solved automatically. This is the case when the synchronization error is caused by version differences between the central and the store server.

In that case the central server should keep resending the outgoing batches.
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-05-14 14:43AugustoMauchNew Issue
2019-05-14 14:43AugustoMauchAssigned To => AugustoMauch
2019-05-14 14:43AugustoMauchTriggers an Emergency Pack => No
2019-05-15 09:43hgbotCheckin
2019-05-15 09:43hgbotNote Added: 0111686
2019-05-15 09:55hgbotCheckin
2019-05-15 09:55hgbotNote Added: 0111687
2019-05-15 09:55hgbotStatusnew => resolved
2019-05-15 09:55hgbotResolutionopen => fixed
2019-05-15 09:55hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.replication.symmetricds/rev/5e74e9de04d92aae1d829b4fe46dd4a611785540 [^]
2019-05-15 09:55AugustoMauchReview Assigned To => mtaal
2019-05-16 11:00mtaalNote Added: 0111712
2019-05-16 11:00mtaalStatusresolved => new
2019-05-16 11:00mtaalResolutionfixed => open
2019-05-16 16:45hgbotCheckin
2019-05-16 16:45hgbotNote Added: 0111725
2019-05-16 16:45hgbotStatusnew => resolved
2019-05-16 16:45hgbotResolutionopen => fixed
2019-05-16 16:45hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.replication.symmetricds/rev/5e74e9de04d92aae1d829b4fe46dd4a611785540 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/d1fdb754a48835fa6b29643c659414044bb9dcf2 [^]
2019-05-16 16:48AugustoMauchNote Edited: 0111725bug_revision_view_page.php?bugnote_id=0111725#r18785
2019-05-20 11:50mtaalNote Added: 0111798
2019-05-20 11:50mtaalStatusresolved => closed

Notes
(0111686)
hgbot   
2019-05-15 09:43   
Repository: erp/pmods/org.openbravo.retail.storeserver.synchronization
Changeset: 86069c4e06ce75c47b118c1a8d63dfc21ecc57a7
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Wed May 15 09:40:31 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/86069c4e06ce75c47b118c1a8d63dfc21ecc57a7 [^]

Related with issue 40875: Uses constant in exception message

The same exception message is referenced in two classes, better to extract it to a constant

---
M src/org/openbravo/retail/storeserver/synchronization/StoreServerIncomingSynchronizationPreventer.java
---
(0111687)
hgbot   
2019-05-15 09:55   
Repository: erp/pmods/org.openbravo.replication.symmetricds
Changeset: 5e74e9de04d92aae1d829b4fe46dd4a611785540
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Wed May 15 09:53:43 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.replication.symmetricds/rev/5e74e9de04d92aae1d829b4fe46dd4a611785540 [^]

Fixes issue 40875: Synch errors caused by version different dont stop synch

In this changeset [1], a change was introduced to automatically stop sending batches to a server
if a synchronization error is repeated several times. This was done because usually to fix a
sync error human intervention is needed, so it is pointless to keep sending the same data until
then.

But there is a case when the sync error will be automatically solved: when it is caused by version
difference. Now that case is taken into account, and the synchronization will not be automatically
stopped.

[1] https://code.openbravo.com/erp/pmods/org.openbravo.replication.symmetricds/rev/21181284ff5b [^]

---
M src/org/openbravo/replication/symmetricds/extensions/SynchronizationErrorAcknowledger.java
---
(0111712)
mtaal   
2019-05-16 11:00   
Also add priority change of channel for version info
(0111725)
hgbot   
2019-05-16 16:45   
(edited on: 2019-05-16 16:48)
Repository: erp/pmods/org.openbravo.retail.storeserver.synchronization
Changeset: d1fdb754a48835fa6b29643c659414044bb9dcf2
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Thu May 16 16:45:33 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/d1fdb754a48835fa6b29643c659414044bb9dcf2 [^]

Fixes issue 40875: Assigns a higher priority to mobile server channel

Now the mobile server channel has a higher priority than the Store Data channel. This way, when
there is an upgrade, the update module info will be synchronized even if there is a lot of data
pending to be synchronized on the Store Data channel.

Remember to execute the update.symmetric.ds.configuration task in the org.openbravo.replication.symmetricds module to update symmetricds configuration.

---
M src-db/database/sourcedata/STRSYNC_SYNCH_CHANNEL.xml
---
(0111798)
mtaal   
2019-05-20 11:50   
tested and reviewed