Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0040844Openbravo ERPZ. Otherspublic2019-04-18 14:022019-06-04 17:56
alostale 
nonofrancisco 
normalminorhave not tried
closedfixed 
5
 
3.0PR19Q2.13.0PR19Q2.1 
Sandrahuguet
Core
No
0040844: use proper html escape in old selectors
Old 2.50 selectors should use standard html escape rather than ad-hoc one.

Files to review:

$ grep -l "extends HttpSecureAppServlet" src/org/openbravo/erpCommon/info/*.java
src/org/openbravo/erpCommon/info/AccountElementValue.java
src/org/openbravo/erpCommon/info/Account.java
src/org/openbravo/erpCommon/info/AttributeSetInstance.java
src/org/openbravo/erpCommon/info/BusinessPartner.java
src/org/openbravo/erpCommon/info/BusinessPartnerMultiple.java
src/org/openbravo/erpCommon/info/DebtPayment.java
src/org/openbravo/erpCommon/info/DocTypeMultiple.java
src/org/openbravo/erpCommon/info/ImageInfoBLOB.java
src/org/openbravo/erpCommon/info/ImageInfo.java
src/org/openbravo/erpCommon/info/Invoice.java
src/org/openbravo/erpCommon/info/InvoiceLine.java
src/org/openbravo/erpCommon/info/Location.java
src/org/openbravo/erpCommon/info/Locator.java
src/org/openbravo/erpCommon/info/LocatorMultiple.java
src/org/openbravo/erpCommon/info/ProductComplete.java
src/org/openbravo/erpCommon/info/Product.java
src/org/openbravo/erpCommon/info/ProductMultiple.java
src/org/openbravo/erpCommon/info/Project.java
src/org/openbravo/erpCommon/info/ProjectMultiple.java
src/org/openbravo/erpCommon/info/SalesOrder.java
src/org/openbravo/erpCommon/info/SalesOrderLine.java
src/org/openbravo/erpCommon/info/ShipmentReceipt.java
src/org/openbravo/erpCommon/info/ShipmentReceiptLine.java
-
See attached example.
No tags attached.
blocks defect 0040646 closed nonofrancisco use proper html escape in old selectors 
Issue History
2019-05-10 20:34nonofranciscoTypedefect => backport
2019-05-10 20:34nonofranciscoTarget Version => 3.0PR19Q2
2019-05-23 18:04SandrahuguetTarget Version3.0PR19Q2 => 3.0PR19Q2.1
2019-06-04 17:54hgbotCheckin
2019-06-04 17:54hgbotNote Added: 0112389
2019-06-04 17:54hgbotStatusscheduled => resolved
2019-06-04 17:54hgbotResolutionopen => fixed
2019-06-04 17:54hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR19Q2.1/rev/f1f88ee0b68bd2a6c9c80b2b0476a21e44c78881 [^]
2019-06-04 17:56SandrahuguetReview Assigned To => Sandrahuguet
2019-06-04 17:56SandrahuguetNote Added: 0112392
2019-06-04 17:56SandrahuguetStatusresolved => closed
2019-06-04 17:56SandrahuguetFixed in Version => 3.0PR19Q2.1

Notes
(0112389)
hgbot   
2019-06-04 17:54   
Repository: erp/backports/3.0PR19Q2.1
Changeset: f1f88ee0b68bd2a6c9c80b2b0476a21e44c78881
Author: Nono Carballo <nonofce <at> gmail.com>
Date: Thu May 09 14:52:16 2019 -0400
URL: http://code.openbravo.com/erp/backports/3.0PR19Q2.1/rev/f1f88ee0b68bd2a6c9c80b2b0476a21e44c78881 [^]

Fixes issue 40844: Escapes properly HTML characters.

Instead of escape HTML characters manually, a function to do so is used.

---
M src/org/openbravo/erpCommon/info/Account.java
M src/org/openbravo/erpCommon/info/AccountElementValue.java
M src/org/openbravo/erpCommon/info/BusinessPartner.java
M src/org/openbravo/erpCommon/info/BusinessPartnerMultiple.java
M src/org/openbravo/erpCommon/info/DebtPayment.java
M src/org/openbravo/erpCommon/info/DocTypeMultiple.java
M src/org/openbravo/erpCommon/info/Invoice.java
M src/org/openbravo/erpCommon/info/InvoiceLine.java
M src/org/openbravo/erpCommon/info/Locator.java
M src/org/openbravo/erpCommon/info/LocatorMultiple.java
M src/org/openbravo/erpCommon/info/Product.java
M src/org/openbravo/erpCommon/info/ProductComplete.java
M src/org/openbravo/erpCommon/info/ProductMultiple.java
M src/org/openbravo/erpCommon/info/Project.java
M src/org/openbravo/erpCommon/info/ProjectMultiple.java
M src/org/openbravo/erpCommon/info/SalesOrder.java
M src/org/openbravo/erpCommon/info/SalesOrderLine.java
M src/org/openbravo/erpCommon/info/ShipmentReceipt.java
M src/org/openbravo/erpCommon/info/ShipmentReceiptLine.java
---
(0112392)
Sandrahuguet   
2019-06-04 17:56   
code review + testing ok