Openbravo Issue Tracking System - Retail Modules
View Issue Details
0040839Retail ModulesCash uppublic2019-05-10 14:042019-05-16 09:35
aaroncalero 
rqueralta 
highmajoralways
closedfixed 
5
 
RR19Q3 
marvintm
No
0040839: Partial Cash Up prints wrong amounts in the summary section
Partial Cash Up prints wrong amounts in the summary section, it shows "undefined" instead of showing real amounts.

In addition, if the environment is using the Sessions module, if the printing fails and the user clicks on cancel or closes the popup, the application performs a logout.
Login in backend, go to the Channel - Touchpoint window and configure the hardware url for the VBS-1 terminal.
Login in webpos, terminal VBS-1.
Turn on the hardware manager.
Click on the menu > Cash Up Partial
Click on Print & Close.
Check the hardware manager for the printed report
The parameters in the call to the print function in Partial Cash Up[1] are wrong: instead of following the "report, sumary, closed, callback" order (as defined by the function here[2]) the parameters are sent to the function in the order "report, closed, sumary, callback".

The boolean in place of the summary breaks the partial cashup printing, while the summary object in place of the closed boolean causes the sessions module to force a logout (since the print function has been overriden in that module).

The fix is simply to revert the order of the parameters to the correct order.


[1] https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/tip/web/org.openbravo.retail.posterminal/js/closecash/model/cashup-model.js#l838 [^]

[2] https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/tip/web/org.openbravo.retail.posterminal/js/closecash/model/cashup-print.js#l22 [^]
No tags attached.
Issue History
2019-05-10 14:04aaroncaleroNew Issue
2019-05-10 14:04aaroncaleroAssigned To => Retail
2019-05-10 14:04aaroncaleroResolution time => 1559253600
2019-05-10 14:04aaroncaleroTriggers an Emergency Pack => No
2019-05-11 13:49rqueraltaAssigned ToRetail => rqueralta
2019-05-11 13:49rqueraltaStatusnew => scheduled
2019-05-16 00:42hgbotCheckin
2019-05-16 00:42hgbotNote Added: 0111698
2019-05-16 00:42hgbotStatusscheduled => resolved
2019-05-16 00:42hgbotResolutionopen => fixed
2019-05-16 00:42hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d6c29e6e89fc27ae4210743498890fe585fa4250 [^]
2019-05-16 09:35marvintmReview Assigned To => marvintm
2019-05-16 09:35marvintmStatusresolved => closed
2019-05-16 09:35marvintmFixed in Version => RR19Q3

Notes
(0111698)
hgbot   
2019-05-16 00:42   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: d6c29e6e89fc27ae4210743498890fe585fa4250
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Tue May 14 13:50:54 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d6c29e6e89fc27ae4210743498890fe585fa4250 [^]

Fixed issue 40839: Partial Cash Up prints wrong amounts in the summary section

- Changed parameters order in printCashUp.print function call

---
M web/org.openbravo.retail.posterminal/js/closecash/model/cashup-model.js
---