Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040805Retail ModulesWeb POSpublic2019-05-07 18:572019-06-06 20:29
Reporterbarbararoncato 
Assigned Torqueralta 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR19Q3 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerGold
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0040805: Deferred service not invoiced.
DescriptionDeferred service not invoiced.
Steps To ReproduceSteps to reproduce:
1. Log into webPOS
2. Add a cliente with Invoice Terms = After Order Delivery
3. Select option "Layaway this receipt"
4. Add a product with stock and delivery condition = Pick and Carry
5. Click on the total amount and layaway the receipt
--- In backend, the layaway has qty delivered = 0 and qty invoiced = 0.
6. Go to webPOS again and open the layaway.
7. Add a deferred service and pay it totally.
--- In backend, the order with the service has qty delivered = 0 and qty invoiced = 0.
8. Go to webPOS again, open the layaway from step 5 and pay it totally.
--- In backend, the layaway now has qty delivered = 1 and qty invoiced = 1 the order with the service has qty delivered = 1 and qty invoiced = 0.


Order: https://drive.google.com/open?id=1HSQeFUefnkc-wIC-3w27dKmnLkEkRhxy [^]
Service: https://drive.google.com/open?id=1K5EpeOcnbQn9IiVZB845EAJyJWHR6eml [^]
Proposed SolutionSolution set in the attached file
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0041046RR19Q2.1 closed rqueralta Deferred service not invoiced. 
depends on backport 0041047RR19Q1.2 closed rqueralta Deferred service not invoiced. 
Attached Files? issue_40805.export (5,374) 2019-05-29 13:10
https://issues.openbravo.com/file_download.php?file_id=12992&type=bug
Issue History
Date ModifiedUsernameFieldChange
2019-05-07 18:57barbararoncatoNew Issue
2019-05-07 18:57barbararoncatoAssigned To => Retail
2019-05-07 18:57barbararoncatoOBNetwork customer => Gold
2019-05-07 18:57barbararoncatoTriggers an Emergency Pack => No
2019-05-08 17:54guillermogilResolution time => 1559080800
2019-05-08 17:54guillermogilSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=18737#r18737
2019-05-11 13:42rqueraltaAssigned ToRetail => rqueralta
2019-05-11 13:42rqueraltaStatusnew => scheduled
2019-05-14 18:22barbararoncatoSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=18775#r18775
2019-05-19 17:36hgbotCheckin
2019-05-19 17:36hgbotNote Added: 0111777
2019-05-19 17:36hgbotStatusscheduled => resolved
2019-05-19 17:36hgbotResolutionopen => fixed
2019-05-19 17:36hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b91896b961ed4f6b55530aece899434133dfad42 [^]
2019-05-28 20:28hgbotCheckin
2019-05-28 20:28hgbotNote Added: 0112216
2019-05-29 09:11guillermogilStatusresolved => new
2019-05-29 09:11guillermogilResolutionfixed => open
2019-05-29 13:10asiermartirenaFile Added: issue_40805.export
2019-05-29 13:37asiermartirenaProposed Solution updated
2019-05-29 17:17hgbotCheckin
2019-05-29 17:17hgbotNote Added: 0112236
2019-06-06 17:58hgbotCheckin
2019-06-06 17:58hgbotNote Added: 0112486
2019-06-06 17:59hgbotStatusnew => resolved
2019-06-06 17:59hgbotResolutionopen => fixed
2019-06-06 17:59hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b91896b961ed4f6b55530aece899434133dfad42 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/de25ae06a97c61851d685e8459402c3f5276f833 [^]
2019-06-06 20:21hgbotCheckin
2019-06-06 20:21hgbotNote Added: 0112488
2019-06-06 20:21hgbotCheckin
2019-06-06 20:21hgbotNote Added: 0112489
2019-06-06 20:21hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/de25ae06a97c61851d685e8459402c3f5276f833 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e06363a486fc092bdca7210773ff4db6ba5f3bb8 [^]
2019-06-06 20:24hgbotCheckin
2019-06-06 20:24hgbotNote Added: 0112490
2019-06-06 20:29marvintmStatusresolved => new
2019-06-06 20:29marvintmResolutionfixed => open
2019-06-06 20:29marvintmStatusnew => scheduled
2019-06-06 20:29marvintmStatusscheduled => resolved
2019-06-06 20:29marvintmFixed in Version => RR19Q3
2019-06-06 20:29marvintmResolutionopen => fixed
2019-06-06 20:29marvintmReview Assigned To => marvintm
2019-06-06 20:29marvintmStatusresolved => closed

Notes
(0111777)
hgbot   
2019-05-19 17:36   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: b91896b961ed4f6b55530aece899434133dfad42
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Wed May 15 18:41:17 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b91896b961ed4f6b55530aece899434133dfad42 [^]

Fixed issue 40805: Deferred service not invoiced.

- When a created invoice have services related without invoiced, the services
lines are added to the current invoice

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
---
(0112216)
hgbot   
2019-05-28 20:28   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: c7de4f837a3fa182c2666e7e4ef68b81dcfca7ef
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Tue May 28 08:40:14 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c7de4f837a3fa182c2666e7e4ef68b81dcfca7ef [^]

Related to issue 40805: Deferred service not invoiced.

Reverted changeset: b91896b961ed.

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
---
(0112236)
hgbot   
2019-05-29 17:17   
Repository: tools/automation/pi-mobile
Changeset: 47d1a6c6ed04ea9c88bc97e925f00e497e7f7f18
Author: Alejandro <alekosmp86 <at> gmail.com>
Date: Mon May 20 17:24:03 2019 -0400
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/47d1a6c6ed04ea9c88bc97e925f00e497e7f7f18 [^]

Related to issue 40805: added automated test

---
A src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/deliverymodes/I40805_VerifyDeferredServiceWithDeliveryModeIsInvoiced.java
---
(0112486)
hgbot   
2019-06-06 17:58   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: de25ae06a97c61851d685e8459402c3f5276f833
Author: Asier Martirena <asier.martirena <at> openbravo.com>
Date: Wed May 29 13:07:28 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/de25ae06a97c61851d685e8459402c3f5276f833 [^]

Fixed issue 40805: The deferred service can generate the invoice now

When a deferred service is delivered due to an order loader hook, the invoice is not created in the case that should. Now, it will be possible to load again that order in the Web POS and synchronize it again creating the invoice for the deferred service lines.

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0112488)
hgbot   
2019-06-06 20:21   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: af4491b69613b6bbe3010da1671f91903774ba52
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Thu Jun 06 13:41:44 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/af4491b69613b6bbe3010da1671f91903774ba52 [^]

Related to issue 40805: Backed out changeset: de25ae06a97c

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0112489)
hgbot   
2019-06-06 20:21   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: e06363a486fc092bdca7210773ff4db6ba5f3bb8
Author: Asier Martirena <asier.martirena <at> openbravo.com>
Date: Wed May 29 13:07:28 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e06363a486fc092bdca7210773ff4db6ba5f3bb8 [^]

Fixed issue 40805: The deferred service can generate the invoice now

When a deferred service is delivered due to an order loader hook, the invoice is not created in the case that should. Now, it will be possible to load again that order in the Web POS and synchronize it again creating the invoice for the deferred service lines.

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0112490)
hgbot   
2019-06-06 20:24   
Repository: tools/automation/pi-mobile
Changeset: 7f5c29bea82804b3a30838eba0233d20efae314d
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Thu Jun 06 14:24:01 2019 -0400
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/7f5c29bea82804b3a30838eba0233d20efae314d [^]

Related to issue 40805: The deferred service can generate the invoice now

- Changed the expected invoice quantity beacuse the layaway ticket is not invoiced

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/prepaymentsAndInvoiceTerms/ImmediatePayOpenTicketsPrepaymentAmountLayaway280.java
---