Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040776Openbravo ERP09. Financial managementpublic2019-04-10 12:352019-05-10 08:37
Reportershuehner 
Assigned ToTriage Omni OMS 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR19Q1.2Fixed in Version3.0PR19Q1.2 
Merge Request Status
Review Assigned ToSandrahuguet
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0040776: ResetAccounting.hasProcessing is not using bind-parameters
DescriptionThis code is not using bind-params:

    String hql = " select count(*) from ADColumn where table.id = '" + strTableId + "' "
        + " and lower(dBColumnName) = 'processing'";
    Query<Long> query = OBDal.getInstance().getSession().createQuery(hql, Long.class);
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0040579 closed Triage Omni OMS ResetAccounting.hasProcessing is not using bind-parameters 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-05-04 17:17nonofranciscoTypedefect => backport
2019-05-04 17:17nonofranciscoTarget Version => 3.0PR19Q1.1
2019-05-06 08:30SandrahuguetTarget Version3.0PR19Q1.1 => 3.0PR19Q1.2
2019-05-10 08:34hgbotCheckin
2019-05-10 08:34hgbotNote Added: 0111609
2019-05-10 08:34hgbotStatusscheduled => resolved
2019-05-10 08:34hgbotResolutionopen => fixed
2019-05-10 08:34hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR19Q1.2/rev/4158c90d38b2d39f0de6ffd715075c3cf7c0fb4d [^]
2019-05-10 08:37SandrahuguetReview Assigned To => Sandrahuguet
2019-05-10 08:37SandrahuguetNote Added: 0111611
2019-05-10 08:37SandrahuguetStatusresolved => closed
2019-05-10 08:37SandrahuguetFixed in Version => 3.0PR19Q1.2

Notes
(0111609)
hgbot   
2019-05-10 08:34   
Repository: erp/backports/3.0PR19Q1.2
Changeset: 4158c90d38b2d39f0de6ffd715075c3cf7c0fb4d
Author: Nono Carballo <nonofce <at> gmail.com>
Date: Mon Apr 22 16:23:50 2019 -0400
URL: http://code.openbravo.com/erp/backports/3.0PR19Q1.2/rev/4158c90d38b2d39f0de6ffd715075c3cf7c0fb4d [^]

Fixes issue 40776: Uses bind parameters in query

Instead of using string concatenation in query, bind parameters are used.

---
M src/org/openbravo/financial/ResetAccounting.java
---
(0111611)
Sandrahuguet   
2019-05-10 08:37   
code review + testing ok