Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0040775Openbravo ERP09. Financial managementpublic2019-04-10 12:352019-05-08 11:35
shuehner 
nonofrancisco 
normalminorhave not tried
closedfixed 
5
 
3.0PR19Q23.0PR19Q2 
Sandrahuguet
Core
No
0040775: ResetAccounting.hasProcessing is not using bind-parameters
This code is not using bind-params:

    String hql = " select count(*) from ADColumn where table.id = '" + strTableId + "' "
        + " and lower(dBColumnName) = 'processing'";
    Query<Long> query = OBDal.getInstance().getSession().createQuery(hql, Long.class);
-
No tags attached.
blocks defect 0040579 closed Triage Omni OMS ResetAccounting.hasProcessing is not using bind-parameters 
Issue History
2019-05-04 17:17nonofranciscoTypedefect => backport
2019-05-04 17:17nonofranciscoTarget Version => 3.0PR19Q2
2019-05-08 11:10SandrahuguetAssigned ToTriage Finance => nonofrancisco
2019-05-08 11:34hgbotCheckin
2019-05-08 11:34hgbotNote Added: 0111563
2019-05-08 11:34hgbotStatusscheduled => resolved
2019-05-08 11:34hgbotResolutionopen => fixed
2019-05-08 11:34hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR19Q2/rev/0746a92970dd0d63768d9e55d13cc5b7263c654c [^]
2019-05-08 11:35SandrahuguetReview Assigned To => Sandrahuguet
2019-05-08 11:35SandrahuguetNote Added: 0111564
2019-05-08 11:35SandrahuguetStatusresolved => closed
2019-05-08 11:35SandrahuguetFixed in Version => 3.0PR19Q2

Notes
(0111563)
hgbot   
2019-05-08 11:34   
Repository: erp/backports/3.0PR19Q2
Changeset: 0746a92970dd0d63768d9e55d13cc5b7263c654c
Author: Nono Carballo <nonofce <at> gmail.com>
Date: Mon Apr 22 16:23:50 2019 -0400
URL: http://code.openbravo.com/erp/backports/3.0PR19Q2/rev/0746a92970dd0d63768d9e55d13cc5b7263c654c [^]

Fixes issue 40775: Uses bind parameters in query

Instead of using string concatenation in query, bind parameters are used.

---
M src/org/openbravo/financial/ResetAccounting.java
---
(0111564)
Sandrahuguet   
2019-05-08 11:35   
Code review + testing OK