Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040772Openbravo ERP07. Sales managementpublic2019-04-09 20:292019-05-08 12:46
Reportershuehner 
Assigned Tononofrancisco 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR19Q2Fixed in Version3.0PR19Q2 
Merge Request Status
Review Assigned ToSandrahuguet
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0040772: SL_TaxCategory_Org.execute is not using bind-parameters
DescriptionThis method is not using bind-parameters in lines 49 + 58

      whereClause = "as tn where tn.node = '" + organization.getId() + "' and tn.client.id = '"
          + organization.getClient().getId() + "'";

        OBQuery<TreeNode> query = OBDal.getInstance().createQuery(TreeNode.class, whereClause);
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0040559 closed nonofrancisco SL_TaxCategory_Org.execute is not using bind-parameters 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-05-04 16:55nonofranciscoTypedefect => backport
2019-05-04 16:55nonofranciscoTarget Version => 3.0PR19Q2
2019-05-08 12:46hgbotCheckin
2019-05-08 12:46hgbotNote Added: 0111571
2019-05-08 12:46hgbotStatusscheduled => resolved
2019-05-08 12:46hgbotResolutionopen => fixed
2019-05-08 12:46hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR19Q2/rev/5b358f1d263fdea6b752ad6fcb32e3466aa8ffdf [^]
2019-05-08 12:46SandrahuguetReview Assigned To => Sandrahuguet
2019-05-08 12:46SandrahuguetNote Added: 0111572
2019-05-08 12:46SandrahuguetStatusresolved => closed
2019-05-08 12:46SandrahuguetFixed in Version => 3.0PR19Q2

Notes
(0111571)
hgbot   
2019-05-08 12:46   
Repository: erp/backports/3.0PR19Q2
Changeset: 5b358f1d263fdea6b752ad6fcb32e3466aa8ffdf
Author: Nono Carballo <nonofce <at> gmail.com>
Date: Mon Apr 22 15:04:05 2019 -0400
URL: http://code.openbravo.com/erp/backports/3.0PR19Q2/rev/5b358f1d263fdea6b752ad6fcb32e3466aa8ffdf [^]

Fixes issue 40772: Uses bind parameters in query

Instead of using string concatenation in client and organization filters in
where clause, bind parameters are used

---
M src/org/openbravo/erpCommon/ad_callouts/SL_TaxCategory_Org.java
---
(0111572)
Sandrahuguet   
2019-05-08 12:46   
code review + testing ok