Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040752Openbravo ERP09. Financial managementpublic2019-05-02 16:252019-08-22 14:45
Reportershuehner 
Assigned Todmiguelez 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR19Q4Fixed in Version3.0PR19Q4 
Merge Request Status
Review Assigned Tovmromanos
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0040752: Simplify oracle version specific code after no longer supporting Oracle 11.1
DescriptionIn issue 40750 support for Oracle 11.1 version was removed which allows to simplify some code which is specific for supporting this old version.

modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/utility/APRMSQLFunctionRegister.java

Specifically now the is11R2OrNewer will always return true so both the function itself as well as the 2 branches to supported oracle but older can be removed.
Note: That this also allows to the remove existsStrAgg function as well.

Note: While 40750 is planned to be backported for 19Q2 this cleanup here is not needed to be backported.
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on feature request 00407503.0PR19Q3 closed alostale Openbravo ERP Raise minimum supported Oracle database version from 11.1 to 11.2 
related to feature request 0040753 new Retail Retail Modules Simplify oracle version specific code after no longer supporting Oracle 11.1 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-05-02 16:25shuehnerNew Issue
2019-05-02 16:25shuehnerAssigned To => Triage Finance
2019-05-02 16:25shuehnerOBNetwork customer => No
2019-05-02 16:25shuehnerModules => Core
2019-05-02 16:25shuehnerTriggers an Emergency Pack => No
2019-05-02 16:25shuehnerRelationship addeddepends on 0040750
2019-05-02 16:27shuehnerRelationship addedrelated to 0040753
2019-05-02 16:27shuehnerTarget Version => 3.0PR19Q3
2019-06-25 17:49vmromanosAssigned ToTriage Finance => markmm82
2019-06-25 23:59markmm82Statusnew => scheduled
2019-07-18 15:38dmiguelezTarget Version3.0PR19Q3 => 3.0PR19Q4
2019-07-25 17:39vmromanosAssigned Tomarkmm82 => dmiguelez
2019-07-26 13:53hgbotCheckin
2019-07-26 13:53hgbotNote Added: 0113678
2019-07-26 13:53hgbotStatusscheduled => resolved
2019-07-26 13:53hgbotResolutionopen => fixed
2019-07-26 13:53hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/b4162532084b7d850b12e99b55a66e7d058b463c [^]
2019-07-26 13:54vmromanosReview Assigned To => vmromanos
2019-07-26 13:54vmromanosNote Added: 0113679
2019-07-26 13:54vmromanosStatusresolved => closed
2019-07-26 13:54vmromanosFixed in Version => 3.0PR19Q4
2019-08-22 14:45hudsonbotCheckin
2019-08-22 14:45hudsonbotNote Added: 0114179

Notes
(0113678)
hgbot   
2019-07-26 13:53   
Repository: erp/devel/pi
Changeset: b4162532084b7d850b12e99b55a66e7d058b463c
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Thu Jul 18 15:41:36 2019 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/b4162532084b7d850b12e99b55a66e7d058b463c [^]

Fixes Issue 40752. Older versions than Oracle 11.2 are no longer supported.
Therefore some of the code in this file is no longer needed.
This fix removes this code.

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/utility/APRMSQLFunctionRegister.java
---
(0113679)
vmromanos   
2019-07-26 13:54   
Code review + testing OK
(0114179)
hudsonbot   
2019-08-22 14:45   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ad3efd3bd07c [^]
Maturity status: Test