Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040739Retail ModulesCopy Retail Storepublic2019-05-02 09:582019-05-10 12:05
Reportercaristu 
Assigned Tocaristu 
PriorityhighSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR19Q3 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0040739: BlankProperties should not be annotated with @ApplicationScoped
DescriptionThe BlankProperties class is annotated with the @ApplicationScoped. Note that this is not needed as this annotation has no effect on interfaces.

Besides, because of this reason, the following warning may appear in the Openbravo log (after the Weld upgrade to version 3.1.0):

WARN org.jboss.weld.Bootstrap - WELD-000167: Class org.openbravo.retail.copystore.process.BlankProperties is annotated with @ApplicationScoped but it does not declare an appropriate constructor therefore is not registered as a bean!

See for example: http://ci.openbravo.com/job/mod-simple/38340/artifact/SANDBOX/tomcat-logs/mod-simple-ci23.18101.log [^]
Steps To ReproduceIn description
Proposed SolutionRemove the annotation and update the class javadoc to document that classes implementing the BlankProperties interface should be annotated as @ApplicationScoped.

See an example of a similar fix: https://code.openbravo.com/erp/devel/pi/diff/d5f700f4b718/src/org/openbravo/costing/CostAdjusmentProcessCheck.java [^]
Additional Information
TagsNo tags attached.
Relationships
related to feature request 0040193 closed caristu Openbravo ERP upgrade Weld to version 3.1.0.Final 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-05-02 09:58caristuNew Issue
2019-05-02 09:58caristuAssigned To => Retail
2019-05-02 09:58caristuTriggers an Emergency Pack => No
2019-05-02 09:59caristuDescription Updatedbug_revision_view_page.php?rev_id=18693#r18693
2019-05-02 10:00caristuDescription Updatedbug_revision_view_page.php?rev_id=18694#r18694
2019-05-02 10:00caristuRelationship addedrelated to 0040193
2019-05-02 10:03caristuProposed Solution updated
2019-05-02 18:03caristuAssigned ToRetail => caristu
2019-05-02 18:03caristuReview Assigned To => marvintm
2019-05-02 18:04hgbotCheckin
2019-05-02 18:04hgbotNote Added: 0111446
2019-05-02 18:04hgbotStatusnew => resolved
2019-05-02 18:04hgbotResolutionopen => fixed
2019-05-02 18:04hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.copystore/rev/18296453654461a5a8a47eb824b02a801950665d [^]
2019-05-10 12:05marvintmStatusresolved => closed
2019-05-10 12:05marvintmFixed in Version => RR19Q3

Notes
(0111446)
hgbot   
2019-05-02 18:04   
Repository: erp/pmods/org.openbravo.retail.copystore
Changeset: 18296453654461a5a8a47eb824b02a801950665d
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Thu May 02 18:04:13 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.copystore/rev/18296453654461a5a8a47eb824b02a801950665d [^]

fixes bug 40739: BlankProperties shouldn't be annotated with @ApplicationScoped

---
M src/org/openbravo/retail/copystore/process/BlankProperties.java
---