0040689: Wrong order status if calculate currentcash or updateDocumentSequenceWhenOrderSaved fails in syncrhonize mode

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0040689

Retail Modules

Web POS

public

2019-04-26 11:39

Reporter

jorge-garcia

Assigned To

Retail

Priority

normal

Severity

major

Reproducibility

have not tried

Status

new

Resolution

open

Platform

OS Version

Product Version

Target Version

Fixed in Version

Merge Request Status

Review Assigned To

OBNetwork customer

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0040689: Wrong order status if calculate currentcash or updateDocumentSequenceWhenOrderSaved fails in syncrhonize mode

Description

Wrong order status if calculate currentcash or updateDocumentSequenceWhenOrderSaved fails in syncrhonize mode

Steps To Reproduce

This code is inside dataordersave.js file:
if (OB.MobileApp.model.hasPermission('OBMOBC_SynchronizedMode', true)) {
  OB.Dal.transaction(function(tx) {
    OB.UTIL.calculateCurrentCash(null, tx);

    OB.MobileApp.model.updateDocumentSequenceWhenOrderSaved(frozenReceipt.get('documentnoSuffix'), frozenReceipt.get('quotationnoSuffix'), frozenReceipt.get('returnnoSuffix'), function() {
      // the trigger is fired on the receipt object, as there is only 1 that is being updated
      receipt.trigger('integrityOk', frozenReceipt); // Is important for module print last receipt. This module listen trigger.
      syncSuccessCallback(function() {
        serverMessageForQuotation(frozenReceipt);
        closeParamCallback();
      }, eventParams);
    }, tx);
  });
}

If the transaction fails, the order could enter in a wrong state.

Proposed Solution

Additional Information