Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040681Openbravo ERP09. Financial managementpublic2019-04-04 13:272019-04-25 16:54
Reporteralostale 
Assigned Tononofrancisco 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR19Q2Fixed in Version3.0PR19Q2 
Merge Request Status
Review Assigned ToSandrahuguet
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0040681: use bind-parameters in FIN_BankStatementImport
DescriptionFIN_BankStatementImport.matchBusinessPartnerByNameTokens method is generating a sql setting parameters by String concatenation, replace tokens by bind parameters.
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0040522 closed nonofrancisco use bind-parameters in FIN_BankStatementImport 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-04-25 13:20SandrahuguetTypedefect => backport
2019-04-25 13:20SandrahuguetTarget Version => 3.0PR19Q2
2019-04-25 16:36hgbotCheckin
2019-04-25 16:36hgbotNote Added: 0111321
2019-04-25 16:36hgbotStatusscheduled => resolved
2019-04-25 16:36hgbotResolutionopen => fixed
2019-04-25 16:36hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/a5d02171e10c523cfac9da2c54e6fb29ee292514 [^] => http://code.openbravo.com/erp/backports/3.0PR19Q2/rev/514d009e78978d3124ec6e5fef2598e1e1d967f8 [^]
2019-04-25 16:36hgbotCheckin
2019-04-25 16:36hgbotNote Added: 0111322
2019-04-25 16:54SandrahuguetReview Assigned To => Sandrahuguet
2019-04-25 16:54SandrahuguetNote Added: 0111325
2019-04-25 16:54SandrahuguetStatusresolved => closed
2019-04-25 16:54SandrahuguetFixed in Version => 3.0PR19Q2

Notes
(0111321)
hgbot   
2019-04-25 16:36   
Repository: erp/backports/3.0PR19Q2
Changeset: 514d009e78978d3124ec6e5fef2598e1e1d967f8
Author: Nono Carballo <nonofce <at> gmail.com>
Date: Thu Apr 25 12:39:23 2019 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR19Q2/rev/514d009e78978d3124ec6e5fef2598e1e1d967f8 [^]

Fixes issue 40681: Prevents use of string concatenation in query

Query to get business partners was formed using string concatenation.
This fix replaces the string concatenation by bind parameters in query.

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/utility/FIN_BankStatementImport.java
---
(0111322)
hgbot   
2019-04-25 16:36   
Repository: erp/backports/3.0PR19Q2
Changeset: 6182a34d4e8dbd3110b8e4138964405d410cb9c4
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Thu Apr 25 13:12:34 2019 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR19Q2/rev/6182a34d4e8dbd3110b8e4138964405d410cb9c4 [^]

related to issue 40681 code review changes

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/utility/FIN_BankStatementImport.java
---
(0111325)
Sandrahuguet   
2019-04-25 16:54   
Code review + testing OK