Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040646Openbravo ERPZ. Otherspublic2019-04-18 14:022019-06-05 13:41
Reporteralostale 
Assigned Tononofrancisco 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR19Q3 
Merge Request Status
Review Assigned ToSandrahuguet
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0040646: use proper html escape in old selectors
DescriptionOld 2.50 selectors should use standard html escape rather than ad-hoc one.

Files to review:

$ grep -l "extends HttpSecureAppServlet" src/org/openbravo/erpCommon/info/*.java
src/org/openbravo/erpCommon/info/AccountElementValue.java
src/org/openbravo/erpCommon/info/Account.java
src/org/openbravo/erpCommon/info/AttributeSetInstance.java
src/org/openbravo/erpCommon/info/BusinessPartner.java
src/org/openbravo/erpCommon/info/BusinessPartnerMultiple.java
src/org/openbravo/erpCommon/info/DebtPayment.java
src/org/openbravo/erpCommon/info/DocTypeMultiple.java
src/org/openbravo/erpCommon/info/ImageInfoBLOB.java
src/org/openbravo/erpCommon/info/ImageInfo.java
src/org/openbravo/erpCommon/info/Invoice.java
src/org/openbravo/erpCommon/info/InvoiceLine.java
src/org/openbravo/erpCommon/info/Location.java
src/org/openbravo/erpCommon/info/Locator.java
src/org/openbravo/erpCommon/info/LocatorMultiple.java
src/org/openbravo/erpCommon/info/ProductComplete.java
src/org/openbravo/erpCommon/info/Product.java
src/org/openbravo/erpCommon/info/ProductMultiple.java
src/org/openbravo/erpCommon/info/Project.java
src/org/openbravo/erpCommon/info/ProjectMultiple.java
src/org/openbravo/erpCommon/info/SalesOrder.java
src/org/openbravo/erpCommon/info/SalesOrderLine.java
src/org/openbravo/erpCommon/info/ShipmentReceipt.java
src/org/openbravo/erpCommon/info/ShipmentReceiptLine.java
Steps To Reproduce-
Proposed SolutionSee attached example.
Additional Information
TagsNo tags attached.
Relationships
related to defect 0040524 closed nonofrancisco use proper character escape 
depends on backport 00407713.0PR18Q4.4 closed nonofrancisco use proper html escape in old selectors 
depends on backport 00408443.0PR19Q2.1 closed nonofrancisco use proper html escape in old selectors 
depends on backport 00408453.0PR19Q1.2 closed nonofrancisco use proper html escape in old selectors 
related to defect 0040647 closed alostale escape formulas when exporting csv 
Attached Filesdiff 40646-example.diff (1,605) 2019-04-18 14:03
https://issues.openbravo.com/file_download.php?file_id=12875&type=bug
Issue History
Date ModifiedUsernameFieldChange
2019-04-18 14:02alostaleNew Issue
2019-04-18 14:02alostaleAssigned To => Triage Finance
2019-04-18 14:02alostaleModules => Core
2019-04-18 14:02alostaleTriggers an Emergency Pack => No
2019-04-18 14:03alostaleFile Added: 40646-example.diff
2019-04-18 14:03alostaleRelationship addedrelated to 0040524
2019-04-18 15:55alostaleRelationship addedrelated to 0040647
2019-04-25 10:17alostaleDescription Updatedbug_revision_view_page.php?rev_id=18675#r18675
2019-04-25 10:26SandrahuguetAssigned ToTriage Finance => nonofrancisco
2019-05-02 05:26nonofranciscoStatusnew => scheduled
2019-05-04 06:10nonofranciscoStatusscheduled => acknowledged
2019-05-04 06:11nonofranciscoStatusacknowledged => scheduled
2019-05-04 06:11nonofranciscoRelationship deleteddepends on 0040736
2019-05-04 06:12nonofranciscoRelationship deleteddepends on 0040737
2019-05-04 06:12nonofranciscoRelationship deleteddepends on 0040738
2019-05-04 06:13nonofranciscoNote Added: 0111479
2019-05-10 20:33nonofranciscoStatusscheduled => acknowledged
2019-05-10 20:34nonofranciscoRelationship deleteddepends on 0040769
2019-05-10 20:34nonofranciscoRelationship deleteddepends on 0040770
2019-05-10 20:34nonofranciscoStatusacknowledged => scheduled
2019-06-04 17:29hgbotCheckin
2019-06-04 17:29hgbotNote Added: 0112388
2019-06-04 17:29hgbotStatusscheduled => resolved
2019-06-04 17:29hgbotResolutionopen => fixed
2019-06-04 17:29hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/1fddb0a46a5b236687570b3e5f52613b37646a03 [^]
2019-06-04 17:57SandrahuguetReview Assigned To => Sandrahuguet
2019-06-04 17:57SandrahuguetNote Added: 0112394
2019-06-04 17:57SandrahuguetStatusresolved => closed
2019-06-04 17:57SandrahuguetFixed in Version => 3.0PR19Q3
2019-06-05 13:41hudsonbotCheckin
2019-06-05 13:41hudsonbotNote Added: 0112418

Notes
(0111479)
nonofrancisco   
2019-05-04 06:13   
Test Plan

Logged as System Administrator
Set Core module in development
Open Windows Tabs and Fields window
Search for "Account Combination"
Set Window Type : Maintain
Select Combination in Tabs tab
Select field Account in Fields tab
Set Read Only false
Rebuild the system

Logged as F&B International Group Admin
Open Account Combination window
Create a new record
Open Account selector
Verify selector shows data properly

Logged as System Administrator
Set Core module in development
Open Windows Tabs and Fields window
Search for "Business Partner"
Select tab "Volume Discount"
Set active = true
Select tab "Volume Discunt Settlement"
Set active = true

Logged as F&B International Group Admin
Open Business Partner window
Select a Business Partner
Select Volume Discount tab
Create a new record
Select Volume Discount Settlement tab
Create a new record
Open Invoice selector
Verify the selector show data properly

Logged as System Administrator
Set Core module in development
Open Windows Tabs and Fields window
Search for "Product" window
Select Field Storage Bin
Set Displayed = true

Logged as F&B International Group Admin
Open Product window
Select a product with type = "Item"
Open Storage Bin selector
Verify the selector show data properly

Logged as System Administrator
Set Core module in development
Open Tables and Columns window
Search for table c_orderline
Set Updatable = true to column Sales Order
Open Windows Tabs and Fields window
Search for "Sales Order" window
Select Lines tab
Select Sales Order field
Set Displayed = true
Set Read Only = false
Rebuild the system

Logged as F&B International Group Admin
Open Sales Order window
Create a new record
Select Lines tab
Create a new record
Open Sales Order selector
Verify the selector show data properly

Logged as System Administrator
Open Windows Tabs and Fields window
Search for "Sales Invoice" window
Select Lines tab
Select Sales Order Line field
Set Read Only = false

Logged as F&B International Group Admin
Open Sales Invoice window
Create a new record
Select Lines tab
Create a new record
Select Sales Order Line selector
Verify the selector show data properly
(0112388)
hgbot   
2019-06-04 17:29   
Repository: erp/devel/pi
Changeset: 1fddb0a46a5b236687570b3e5f52613b37646a03
Author: Nono Carballo <nonofce <at> gmail.com>
Date: Thu May 09 14:52:16 2019 -0400
URL: http://code.openbravo.com/erp/devel/pi/rev/1fddb0a46a5b236687570b3e5f52613b37646a03 [^]

Fixes issue 40646: Escapes properly HTML characters.

Instead of escape HTML characters manually, a function to do so is used.

---
M src/org/openbravo/erpCommon/info/Account.java
M src/org/openbravo/erpCommon/info/AccountElementValue.java
M src/org/openbravo/erpCommon/info/BusinessPartner.java
M src/org/openbravo/erpCommon/info/BusinessPartnerMultiple.java
M src/org/openbravo/erpCommon/info/DebtPayment.java
M src/org/openbravo/erpCommon/info/DocTypeMultiple.java
M src/org/openbravo/erpCommon/info/Invoice.java
M src/org/openbravo/erpCommon/info/InvoiceLine.java
M src/org/openbravo/erpCommon/info/Locator.java
M src/org/openbravo/erpCommon/info/LocatorMultiple.java
M src/org/openbravo/erpCommon/info/Product.java
M src/org/openbravo/erpCommon/info/ProductComplete.java
M src/org/openbravo/erpCommon/info/ProductMultiple.java
M src/org/openbravo/erpCommon/info/Project.java
M src/org/openbravo/erpCommon/info/ProjectMultiple.java
M src/org/openbravo/erpCommon/info/SalesOrder.java
M src/org/openbravo/erpCommon/info/SalesOrderLine.java
M src/org/openbravo/erpCommon/info/ShipmentReceipt.java
M src/org/openbravo/erpCommon/info/ShipmentReceiptLine.java
---
(0112394)
Sandrahuguet   
2019-06-04 17:57   
code review + testing ok
(0112418)
hudsonbot   
2019-06-05 13:41   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/8e20cc58f41d [^]
Maturity status: Test