Openbravo Issue Tracking System - Openbravo ERP |
View Issue Details |
|
ID | Project | Category | View Status | Date Submitted | Last Update |
0040629 | Openbravo ERP | A. Platform | public | 2019-04-17 09:24 | 2019-05-21 15:16 |
|
Reporter | alostale | |
Assigned To | alostale | |
Priority | normal | Severity | trivial | Reproducibility | have not tried |
Status | closed | Resolution | fixed | |
Platform | | OS | 5 | OS Version | |
Product Version | | |
Target Version | | Fixed in Version | 3.0PR19Q3 | |
Merge Request Status | |
Review Assigned To | caristu |
OBNetwork customer | |
Web browser | |
Modules | Core |
Support ticket | |
Regression level | |
Regression date | |
Regression introduced in release | |
Regression introduced by commit | |
Triggers an Emergency Pack | No |
|
Summary | 0040629: jdk11+: removal warning in HttpServletCalloutInformationProvider |
Description | When compiling with JDK11+ removal warnings appear in HttpServletCalloutInformationProvider because it makes use Nashorn objects which were deprecated for removal. |
Steps To Reproduce | 1. Set up JDK11
2. Compile
-> Check compilation log:
compileSqlc:
[javac] Compiling 4850 source files to /srv/ci/workspace/mod-simple-ci23.18103/build/classes
[javac] /srv/ci/workspace/mod-simple-ci23.18103/src/org/openbravo/erpCommon/ad_callouts/HttpServletCalloutInformationProvider.java:52:
warning: [removal] JSObject in jdk.nashorn.api.scripting has been deprecated and marked for removal
[javac] private List<JSObject> responseElements;
[javac] ^
...
|
Proposed Solution | As there is not yet any clear replacement for Nashorn, continue making use of it suppressing warnings.
Note warnings should not be shown with any supported JDK version (starting from 8). |
Additional Information | |
Tags | No tags attached. |
Relationships | related to | feature request | 0038130 | | closed | caristu | support JDK 11 | related to | design defect | 0040535 | | closed | alostale | old callouts should use OBScriptEngine to evaluate response |
|
Attached Files | |
|
Issue History |
Date Modified | Username | Field | Change |
2019-04-17 09:24 | alostale | New Issue | |
2019-04-17 09:24 | alostale | Assigned To | => platform |
2019-04-17 09:24 | alostale | Modules | => Core |
2019-04-17 09:24 | alostale | Triggers an Emergency Pack | => No |
2019-04-17 09:26 | alostale | Review Assigned To | => caristu |
2019-04-17 09:26 | alostale | Assigned To | platform => alostale |
2019-04-17 09:47 | alostale | Relationship added | related to 0038130 |
2019-04-17 09:47 | alostale | Relationship added | related to 0040535 |
2019-04-17 09:52 | hgbot | Checkin | |
2019-04-17 09:52 | hgbot | Note Added: 0111176 | |
2019-04-17 09:52 | hgbot | Status | new => resolved |
2019-04-17 09:52 | hgbot | Resolution | open => fixed |
2019-04-17 09:52 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/d91acd577d9621f028eda6ba2b8cee8f5e3d99a3 [^] |
2019-04-18 09:46 | hgbot | Checkin | |
2019-04-18 09:46 | hgbot | Note Added: 0111208 | |
2019-04-26 08:37 | caristu | Note Added: 0111337 | |
2019-04-26 08:37 | caristu | Status | resolved => closed |
2019-04-26 08:37 | caristu | Fixed in Version | => 3.0PR19Q3 |
2019-05-21 15:16 | hudsonbot | Checkin | |
2019-05-21 15:16 | hudsonbot | Note Added: 0111979 | |
2019-05-21 15:16 | hudsonbot | Checkin | |
2019-05-21 15:16 | hudsonbot | Note Added: 0111988 | |
Notes |
|
(0111176)
|
hgbot
|
2019-04-17 09:52
|
|
Repository: erp/devel/pi
Changeset: d91acd577d9621f028eda6ba2b8cee8f5e3d99a3
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Wed Apr 17 09:51:44 2019 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/d91acd577d9621f028eda6ba2b8cee8f5e3d99a3 [^]
fixed issue 40629: suppressed jdk11 removal warnings
Which appeared in HttpServletCalloutInformationProvider class that uses nashorn.
---
M src/org/openbravo/erpCommon/ad_callouts/HttpServletCalloutInformationProvider.java
---
|
|
|
(0111208)
|
hgbot
|
2019-04-18 09:46
|
|
Repository: erp/devel/pi
Changeset: 624df4ecc1c65a753ac0fdf92c794add91d539eb
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Apr 18 09:20:58 2019 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/624df4ecc1c65a753ac0fdf92c794add91d539eb [^]
related to issue 40629: added removal warning which to prevent warning in cli
When compiling in cli with JDK11, even having @SuppressWarnings("all"), removal
warning was displayed. Adding @SupressWarnings("removal") to explicilty avoid this
case.
---
M src/org/openbravo/erpCommon/ad_callouts/HttpServletCalloutInformationProvider.java
---
|
|
|
|
|
|
|
|
|
|
|