Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0040629Openbravo ERPA. Platformpublic2019-04-17 09:242019-05-21 15:16
alostale 
alostale 
normaltrivialhave not tried
closedfixed 
5
 
3.0PR19Q3 
caristu
Core
No
0040629: jdk11+: removal warning in HttpServletCalloutInformationProvider
When compiling with JDK11+ removal warnings appear in HttpServletCalloutInformationProvider because it makes use Nashorn objects which were deprecated for removal.
1. Set up JDK11
2. Compile
    -> Check compilation log:
compileSqlc:
    [javac] Compiling 4850 source files to /srv/ci/workspace/mod-simple-ci23.18103/build/classes
    [javac] /srv/ci/workspace/mod-simple-ci23.18103/src/org/openbravo/erpCommon/ad_callouts/HttpServletCalloutInformationProvider.java:52: 
warning: [removal] JSObject in jdk.nashorn.api.scripting has been deprecated and marked for removal
    
[javac]   private List<JSObject> responseElements;
    [javac]                ^

    ...
As there is not yet any clear replacement for Nashorn, continue making use of it suppressing warnings.

Note warnings should not be shown with any supported JDK version (starting from 8).
No tags attached.
related to feature request 0038130 closed caristu support JDK 11 
related to design defect 0040535 closed alostale old callouts should use OBScriptEngine to evaluate response 
Issue History
2019-04-17 09:24alostaleNew Issue
2019-04-17 09:24alostaleAssigned To => platform
2019-04-17 09:24alostaleModules => Core
2019-04-17 09:24alostaleTriggers an Emergency Pack => No
2019-04-17 09:26alostaleReview Assigned To => caristu
2019-04-17 09:26alostaleAssigned Toplatform => alostale
2019-04-17 09:47alostaleRelationship addedrelated to 0038130
2019-04-17 09:47alostaleRelationship addedrelated to 0040535
2019-04-17 09:52hgbotCheckin
2019-04-17 09:52hgbotNote Added: 0111176
2019-04-17 09:52hgbotStatusnew => resolved
2019-04-17 09:52hgbotResolutionopen => fixed
2019-04-17 09:52hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/d91acd577d9621f028eda6ba2b8cee8f5e3d99a3 [^]
2019-04-18 09:46hgbotCheckin
2019-04-18 09:46hgbotNote Added: 0111208
2019-04-26 08:37caristuNote Added: 0111337
2019-04-26 08:37caristuStatusresolved => closed
2019-04-26 08:37caristuFixed in Version => 3.0PR19Q3
2019-05-21 15:16hudsonbotCheckin
2019-05-21 15:16hudsonbotNote Added: 0111979
2019-05-21 15:16hudsonbotCheckin
2019-05-21 15:16hudsonbotNote Added: 0111988

Notes
(0111176)
hgbot   
2019-04-17 09:52   
Repository: erp/devel/pi
Changeset: d91acd577d9621f028eda6ba2b8cee8f5e3d99a3
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Wed Apr 17 09:51:44 2019 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/d91acd577d9621f028eda6ba2b8cee8f5e3d99a3 [^]

fixed issue 40629: suppressed jdk11 removal warnings

  Which appeared in HttpServletCalloutInformationProvider class that uses nashorn.

---
M src/org/openbravo/erpCommon/ad_callouts/HttpServletCalloutInformationProvider.java
---
(0111208)
hgbot   
2019-04-18 09:46   
Repository: erp/devel/pi
Changeset: 624df4ecc1c65a753ac0fdf92c794add91d539eb
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Apr 18 09:20:58 2019 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/624df4ecc1c65a753ac0fdf92c794add91d539eb [^]

related to issue 40629: added removal warning which to prevent warning in cli

  When compiling in cli with JDK11, even having @SuppressWarnings("all"), removal
  warning was displayed. Adding @SupressWarnings("removal") to explicilty avoid this
  case.

---
M src/org/openbravo/erpCommon/ad_callouts/HttpServletCalloutInformationProvider.java
---
(0111337)
caristu   
2019-04-26 08:37   
Reviewed
(0111979)
hudsonbot   
2019-05-21 15:16   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9b8f37d9d85e [^]
Maturity status: Test
(0111988)
hudsonbot   
2019-05-21 15:16   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9b8f37d9d85e [^]
Maturity status: Test