Openbravo Issue Tracking System - Retail Modules
View Issue Details
0040619Retail ModulesDelivery Modespublic2019-04-15 17:482019-05-23 18:51
guillermogil 
jorge-garcia 
normalmajoralways
closedfixed 
5
 
RR19Q3 
marvintm
No
0040619: [UI] Year is not shown depending on Resolution
Year is not shown depending on Resolution on the Delivery Mode Date Picker
Tested on a Huawei P Smart +

See attached image: https://drive.google.com/file/d/1nx6S-T8oi2w3kej8D6KkHMzsaC85MiY1/view?usp=sharing [^]
Login on livebuilds with modules
Add an Avalanche Transceiver
Open Stock Screen
Select Pickup in store with date
No tags attached.
jpg Selection_474.jpg (37,972) 2019-05-06 12:13
https://issues.openbravo.com/file_download.php?file_id=12919&type=bug
jpg
Issue History
2019-04-15 17:48guillermogilNew Issue
2019-04-15 17:48guillermogilAssigned To => Retail
2019-04-15 17:48guillermogilResolution time => 1557093600
2019-04-15 17:48guillermogilTriggers an Emergency Pack => No
2019-04-15 17:51guillermogilSummary[UX] Year is not shown depending on Resolution => [UI] Year is not shown depending on Resolution
2019-04-15 17:51guillermogilDescription Updatedbug_revision_view_page.php?rev_id=18631#r18631
2019-04-22 21:51rqueraltaAssigned ToRetail => rqueralta
2019-04-22 21:53rqueraltaStatusnew => scheduled
2019-05-03 15:54hgbotCheckin
2019-05-03 15:54hgbotNote Added: 0111478
2019-05-03 15:54hgbotStatusscheduled => resolved
2019-05-03 15:54hgbotResolutionopen => fixed
2019-05-03 15:54hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/61c35352f056bf361b4fc62987bd1b38403afd02 [^]
2019-05-06 12:13guilleaerNote Added: 0111496
2019-05-06 12:13guilleaerStatusresolved => new
2019-05-06 12:13guilleaerResolutionfixed => open
2019-05-06 12:13guilleaerFile Added: Selection_474.jpg
2019-05-06 12:13guilleaerNote Edited: 0111496bug_revision_view_page.php?bugnote_id=0111496#r18715
2019-05-07 08:35guilleaerStatusnew => scheduled
2019-05-07 14:39hgbotCheckin
2019-05-07 14:39hgbotNote Added: 0111544
2019-05-07 14:39hgbotStatusscheduled => resolved
2019-05-07 14:39hgbotResolutionopen => fixed
2019-05-07 14:39hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/61c35352f056bf361b4fc62987bd1b38403afd02 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3b27ce59f00b729ee9e692c338d572abe8b544bb [^]
2019-05-07 14:43hgbotCheckin
2019-05-07 14:43hgbotNote Added: 0111546
2019-05-07 14:43hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3b27ce59f00b729ee9e692c338d572abe8b544bb [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/83b10355267e6acda77be03b8b5196bca058829e [^]
2019-05-07 16:08guilleaerReview Assigned To => guilleaer
2019-05-07 16:08guilleaerStatusresolved => closed
2019-05-07 16:08guilleaerFixed in Version => RR19Q3
2019-05-16 10:38ucarrionNote Added: 0111711
2019-05-16 10:38ucarrionStatusclosed => new
2019-05-16 10:38ucarrionResolutionfixed => open
2019-05-16 10:38ucarrionFixed in VersionRR19Q3 =>
2019-05-17 11:26hgbotCheckin
2019-05-17 11:26hgbotNote Added: 0111770
2019-05-17 11:26hgbotStatusnew => resolved
2019-05-17 11:26hgbotResolutionopen => fixed
2019-05-17 11:26hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/83b10355267e6acda77be03b8b5196bca058829e [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.deliverymodes/rev/c1e9654342267a75f4438aa9e6eb463d1ab79da9 [^]
2019-05-17 13:59marvintmReview Assigned Toguilleaer => marvintm
2019-05-17 13:59marvintmStatusresolved => closed
2019-05-17 13:59marvintmFixed in Version => RR19Q3
2019-05-22 13:57ucarrionNote Added: 0112073
2019-05-22 13:57ucarrionStatusclosed => new
2019-05-22 13:57ucarrionResolutionfixed => open
2019-05-22 13:57ucarrionFixed in VersionRR19Q3 =>
2019-05-23 10:25hgbotCheckin
2019-05-23 10:25hgbotNote Added: 0112082
2019-05-23 10:26jorge-garciaStatusnew => scheduled
2019-05-23 10:26jorge-garciaAssigned Torqueralta => jorge-garcia
2019-05-23 10:28jorge-garciaNote Added: 0112083
2019-05-23 10:28jorge-garciaStatusscheduled => resolved
2019-05-23 10:28jorge-garciaFixed in Version => RR19Q3
2019-05-23 10:28jorge-garciaResolutionopen => fixed
2019-05-23 18:51marvintmStatusresolved => closed

Notes
(0111478)
hgbot   
2019-05-03 15:54   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 61c35352f056bf361b4fc62987bd1b38403afd02
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Thu May 02 15:25:57 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/61c35352f056bf361b4fc62987bd1b38403afd02 [^]

Fixed issue 40619: [UI] Year is not shown depending on Resolution

- The width of the columns was modified to show the Date component completely in
all resolutions.

---
M web/org.openbravo.mobile.core/assets/css/ob-standard.css
---
(0111496)
guilleaer   
2019-05-06 12:13   
Solution is not correct

General css class is being changed to resolve an specific problem.Other components can be affected.

New css class should be created to overwrite this behavior for this specific case.

Create new classes in css and use them in JS

.properties-label-thin {
  width: 32%;
}

.properties-component-wide {
  width: 78%;
}

With current solution, it is not shown fine in our min resolution
393x700 (check attached image)

using 32% and 78% works fine.

(0111544)
hgbot   
2019-05-07 14:39   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 3b27ce59f00b729ee9e692c338d572abe8b544bb
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Mon May 06 15:09:56 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3b27ce59f00b729ee9e692c338d572abe8b544bb [^]

Fixed issue 40619: [UI] Year is not shown depending on Resolution

- Removed in line width style

---
M web/org.openbravo.retail.posterminal/js/components/modalreceiptlineproperties.js
---
(0111546)
hgbot   
2019-05-07 14:43   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 83b10355267e6acda77be03b8b5196bca058829e
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Mon May 06 15:07:56 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/83b10355267e6acda77be03b8b5196bca058829e [^]

Fixed issue 40619: [UI] Year is not shown depending on Resolution

- Changed width of the label and component columns

---
M web/org.openbravo.mobile.core/assets/css/ob-standard.css
---
(0111711)
ucarrion   
2019-05-16 10:38   
Hi,

it is being displayed fine now if you login webpos from a browser. Otherwise, login from an app (where the screen has not toolbar) it is wrongly displayed again.

It can be reproduced by adding the web to a Kiosk mode
(0111770)
hgbot   
2019-05-17 11:26   
Repository: erp/pmods/org.openbravo.retail.deliverymodes
Changeset: c1e9654342267a75f4438aa9e6eb463d1ab79da9
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Fri May 17 10:27:27 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.deliverymodes/rev/c1e9654342267a75f4438aa9e6eb463d1ab79da9 [^]

Fixed issue 40619: [UI] Year is not shown depending on Resolution

To avoid year component from datepicker to go to next line, we should transform
the container into a flexbox, and let the CSS set the position and space
between components.

This inline style should be change in the future to a CSS class.

---
M web/org.openbravo.retail.deliverymodes/js/receiptMultiLineEdit.js
---
(0112073)
ucarrion   
2019-05-22 13:57   
Still reproduced for 'Home Delivery' delivery mode
(0112082)
hgbot   
2019-05-23 10:25   
Repository: erp/pmods/org.openbravo.retail.deliverymodes
Changeset: 643fd2b4176ef8bd5f33526145a7091f44f93dc8
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Thu May 23 10:25:19 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.deliverymodes/rev/643fd2b4176ef8bd5f33526145a7091f44f93dc8 [^]

Related issue 40619: [UI] Year is not shown depending on Resolution

To avoid year component from datepicker to go to next line, we should transform
the container into a flexbox, and let the CSS set the position and space
between components.

This commit affects to delivery modes in receipt properties popup.

This inline style should be change in the future to a CSS class.

---
M web/org.openbravo.retail.deliverymodes/js/receiptEdit.js
---
(0112083)
jorge-garcia   
2019-05-23 10:28   
The edit delivery modes problem was already fixed by this commit[1]

[1] https://code.openbravo.com/erp/pmods/org.openbravo.retail.deliverymodes/rev/c1e9654342267a75f4438aa9e6eb463d1ab79da9 [^]

If reproducible, it could be that the transplant of this commit was wrong.

We detect the same problem in receipt properties popup. This commit[2] should fix it

[2] https://code.openbravo.com/erp/pmods/org.openbravo.retail.deliverymodes/rev/643fd2b4176ef8bd5f33526145a7091f44f93dc8 [^]