Openbravo Issue Tracking System - Openbravo ERP
There is a problem in the 'm_rappel_invoice_create' function on the db.
1- Does not checks if the product category is active or not.
2- It does not checks that the product category nor the product is defined on the same rappel(Volume discount) that is being used for the creation of the invoice.
This can be seen in this piece of code from the 'm_rappel_invoice_create':
AND((COALESCE(R.INCLUDE_PRODUCT_CATEGORY, 'Y')='N' -- Just selected
AND EXISTS
(SELECT 1
FROM M_RAPPEL_PRODUCTCATEGORY RC, M_PRODUCT PROD
WHERE PROD.M_PRODUCT_ID=IL.M_PRODUCT_ID
AND RC.M_PRODUCT_CATEGORY_ID=PROD.M_PRODUCT_CATEGORY_ID ))
OR (COALESCE(R.INCLUDE_PRODUCT_CATEGORY, 'Y')='Y' -- Everyone except selected
AND NOT EXISTS
(SELECT 1
FROM M_RAPPEL_PRODUCTCATEGORY RC, M_PRODUCT PROD
WHERE PROD.M_PRODUCT_ID=IL.M_PRODUCT_ID
AND RC.M_PRODUCT_CATEGORY_ID=PROD.M_PRODUCT_CATEGORY_ID )))
AND((COALESCE(R.INCLUDE_PRODUCT, 'Y')='N' -- Just selected
AND EXISTS
(SELECT 1
FROM M_RAPPEL_PRODUCT RP
WHERE RP.M_PRODUCT_ID=IL.M_PRODUCT_ID
AND RP.ISACTIVE='Y'))
OR (COALESCE(R.INCLUDE_PRODUCT, 'Y')='Y' -- Everyone except selected
AND NOT EXISTS
(SELECT 1
FROM M_RAPPEL_PRODUCT RP
WHERE RP.M_PRODUCT_ID=IL.M_PRODUCT_ID
AND RP.ISACTIVE='Y')))
AND RP.ISSOTRX=I.ISSOTRX
AND RP.M_RAPPEL_BPARTNER_ID=v_Record_ID;
1- First of all, the rappels should be 'activated'. So, as System Administrator, go to the window 'Windows, Tabs, and fields' and search for the business partner window. Then search for the 'Volume Discount' tab and activate it. Then you will have to do a compile.complete.
2- Create a volume discount with the 'All excluding defined' on the 'Included product' and 'Included product category' fields.
3- Set the volume discount for a business partner 'x'
4- On the Scale, set a range of values, for example 1% discount for products between $1 and $1000.
5- Create a sales invoice and add a product.
6- On the business partner window, go to the volume discount tab and create a new one, selecting the volume discount created before.
7- Click on the 'Generate Invoice' button and set the date that is equals than the invoice created.
8- A new invoice will be generated, and it will be okay. But the problem gets when you create another volume discount, so:
9- Create a new volume discount for ANOTHER Business partner (let's call it 'y'), using the 'Only those defined' on the 'Included product' and 'Included product category' fields.
10- On the product category of this new volume discount use, for example, water product category.
11- Create a new invoice, for the first business partner ('x'), with a product that has the 'Water' product category.
12- Try the 'Create invoice' from the rappel again, and you can see that it will not find any invoice.
You can see an example attached.
...
AND((COALESCE(R.INCLUDE_PRODUCT_CATEGORY, 'Y')='N' -- Just selected
AND EXISTS
(SELECT 1
FROM M_RAPPEL_PRODUCTCATEGORY RC,
M_PRODUCT PROD
WHERE PROD.M_PRODUCT_ID=IL.M_PRODUCT_ID
AND RC.M_PRODUCT_CATEGORY_ID=PROD.M_PRODUCT_CATEGORY_ID
AND RC.ISACTIVE='Y' AND R.M_RAPPEL_ID=RC.M_RAPPEL_ID
))
OR (COALESCE(R.INCLUDE_PRODUCT_CATEGORY, 'Y')='Y' -- Everyone except selected
AND NOT EXISTS
(SELECT 1
FROM M_RAPPEL_PRODUCTCATEGORY RC,
M_PRODUCT PROD
WHERE PROD.M_PRODUCT_ID=IL.M_PRODUCT_ID
AND RC.M_PRODUCT_CATEGORY_ID=PROD.M_PRODUCT_CATEGORY_ID
AND RC.ISACTIVE='Y' AND R.M_RAPPEL_ID=RC.M_RAPPEL_ID
)))
AND((COALESCE(R.INCLUDE_PRODUCT, 'Y')='N' -- Just selected
AND EXISTS
(SELECT 1 FROM M_RAPPEL_PRODUCT RP WHERE RP.M_PRODUCT_ID=IL.M_PRODUCT_ID AND RP.ISACTIVE='Y'
AND R.M_RAPPEL_ID=RP.M_RAPPEL_ID))
OR (COALESCE(R.INCLUDE_PRODUCT, 'Y')='Y' -- Everyone except selected
AND NOT EXISTS
(SELECT 1 FROM M_RAPPEL_PRODUCT RP WHERE RP.M_PRODUCT_ID=IL.M_PRODUCT_ID AND RP.ISACTIVE='Y'
AND R.M_RAPPEL_ID=RP.M_RAPPEL_ID)))
AND RP.ISSOTRX=I.ISSOTRX
AND RP.M_RAPPEL_BPARTNER_ID=v_Record_ID;
...
To add the current rappel selected.
9107.zip (1,190,170) 2019-04-13 00:32https://issues.openbravo.com/file_download.php?file_id=12862&type=bug